upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-07-08 09:10:57 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't cast off_t to 32-bit type for output, bug fix

Browse source 
off_t is most likely a 64-bit integer, so casting it to a 32-bit type
for output could lose data.  There are more issues like this in the
tree, but this is an instance where this could actually happen in
practice, since base backups are routinely larger than 4 GB.  So this
is separated out as a bug fix.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org
This commit is contained in:
Peter Eisentraut 2026-07-01 09:40:16 +02:00
parent 182f6944d3
commit d4e2280b7e
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/backend/backup/basebackup_server.c
View file

@ -176,9 +176,9 @@ bbsink_server_archive_contents(bbsink *sink, size_t len)
/* short write: complain appropriately */
ereport(ERROR,
(errcode(ERRCODE_DISK_FULL),
errmsg("could not write file \"%s\": wrote only %d of %zu bytes at offset %u",
errmsg("could not write file \"%s\": wrote only %d of %zu bytes at offset %lld",
FilePathName(mysink->file),
nbytes, len, (unsigned) mysink->filepos),
nbytes, len, (long long) mysink->filepos),
errhint("Check free disk space.")));
}
@ -269,9 +269,9 @@ bbsink_server_manifest_contents(bbsink *sink, size_t len)
/* short write: complain appropriately */
ereport(ERROR,
(errcode(ERRCODE_DISK_FULL),
errmsg("could not write file \"%s\": wrote only %d of %zu bytes at offset %u",
errmsg("could not write file \"%s\": wrote only %d of %zu bytes at offset %lld",
FilePathName(mysink->file),
nbytes, len, (unsigned) mysink->filepos),
nbytes, len, (long long) mysink->filepos),
errhint("Check free disk space.")));
}