mirror of
https://github.com/postgres/postgres.git
synced 2026-05-28 04:35:45 -04:00
Fix shared memory size of template code for custom fixed-sized pgstats
On HEAD, the template code for custom fixed-sized pgstats is in the test module test_custom_stats. On REL_18_STABLE, this code lives in the test module injection_points. Both cases were underestimating the size of the shared memory area required for the storage of the stats data, using a single entry rather than the whole area. This underestimation meant that there was no memory allocated for the LWLock required for the stats, and even more. This problem would be also misleading for extension developers looking at this code. This issue has been noticed while digging into a different bug reported by Heikki Linnakangas, showing that the underestimation was causing failures in the TAP tests of the test modules for 32-bit builds. The other issue reported, related to the memory allocation of custom fixed-sized pgstats, will be fixed in a follow-up commit. Discussion: https://postgr.es/m/adMk_lWbnz3HDOA8@paquier.xyz Backpatch-through: 18
This commit is contained in:
parent
11c2c0cc8d
commit
af04b04f2f
1 changed files with 1 additions and 1 deletions
|
|
@ -52,7 +52,7 @@ static const PgStat_KindInfo injection_stats_fixed = {
|
|||
.fixed_amount = true,
|
||||
.write_to_file = true,
|
||||
|
||||
.shared_size = sizeof(PgStat_StatInjFixedEntry),
|
||||
.shared_size = sizeof(PgStatShared_InjectionPointFixed),
|
||||
.shared_data_off = offsetof(PgStatShared_InjectionPointFixed, stats),
|
||||
.shared_data_len = sizeof(((PgStatShared_InjectionPointFixed *) 0)->stats),
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue