upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-04-15 22:10:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Make ALTER DOMAIN VALIDATE CONSTRAINT no-op when constraint is already validated

Browse source 
Currently, AlterDomainValidateConstraint will re-validate a constraint
that has already been validated, which would just waste cycles.  This
operation should be a no-op when the constraint is already validated.
This also aligns with ATExecValidateConstraint.

Author: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxG=-Dv9fPJHqkA9c-wGZ2dDOWOXSp-X-0K_G7r-DgaASw@mail.gmail.com
This commit is contained in:
Peter Eisentraut 2026-02-24 10:56:17 +01:00
parent f80bedd52b
commit a99c6b56ff
1 changed files with 25 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
src/backend/commands/typecmds.c
View file

@ -3052,6 +3052,9 @@ AlterDomainAddConstraint(List *names, Node *newConstraint,
* AlterDomainValidateConstraint
*
* Implements the ALTER DOMAIN .. VALIDATE CONSTRAINT statement.
*
* Return value is the address of the validated constraint. If the constraint
* was already validated, InvalidObjectAddress is returned.
*/
ObjectAddress
AlterDomainValidateConstraint(List *names, const char *constrName)
@ -3069,7 +3072,7 @@ AlterDomainValidateConstraint(List *names, const char *constrName)
HeapTuple tuple;
HeapTuple copyTuple;
ScanKeyData skey[3];
ObjectAddress address;
ObjectAddress address = InvalidObjectAddress;
/* Make a TypeName so we can use standard type lookup machinery */
typename = makeTypeNameFromNameList(names);
@ -3120,29 +3123,32 @@ AlterDomainValidateConstraint(List *names, const char *constrName)
errmsg("constraint \"%s\" of domain \"%s\" is not a check constraint",
constrName, TypeNameToString(typename))));
val = SysCacheGetAttrNotNull(CONSTROID, tuple, Anum_pg_constraint_conbin);
conbin = TextDatumGetCString(val);
if (!con->convalidated)
{
val = SysCacheGetAttrNotNull(CONSTROID, tuple, Anum_pg_constraint_conbin);
conbin = TextDatumGetCString(val);
/*
* Locking related relations with ShareUpdateExclusiveLock is ok because
* not-yet-valid constraints are still enforced against concurrent inserts
* or updates.
*/
validateDomainCheckConstraint(domainoid, conbin, ShareUpdateExclusiveLock);
/*
* Locking related relations with ShareUpdateExclusiveLock is ok
* because not-yet-valid constraints are still enforced against
* concurrent inserts or updates.
*/
validateDomainCheckConstraint(domainoid, conbin, ShareUpdateExclusiveLock);
/*
* Now update the catalog, while we have the door open.
*/
copyTuple = heap_copytuple(tuple);
copy_con = (Form_pg_constraint) GETSTRUCT(copyTuple);
copy_con->convalidated = true;
CatalogTupleUpdate(conrel, &copyTuple->t_self, copyTuple);
/*
* Now update the catalog, while we have the door open.
*/
copyTuple = heap_copytuple(tuple);
copy_con = (Form_pg_constraint) GETSTRUCT(copyTuple);
copy_con->convalidated = true;
CatalogTupleUpdate(conrel, &copyTuple->t_self, copyTuple);
InvokeObjectPostAlterHook(ConstraintRelationId, con->oid, 0);
InvokeObjectPostAlterHook(ConstraintRelationId, con->oid, 0);
ObjectAddressSet(address, TypeRelationId, domainoid);
ObjectAddressSet(address, TypeRelationId, domainoid);
heap_freetuple(copyTuple);
heap_freetuple(copyTuple);
}
systable_endscan(scan);