upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-05-28 04:35:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update comments to reflect changes in 8e0d32a4a1.

Browse source 
Commit 8e0d32a4a1 fixed an issue by allowing the replication origin to be
created while marking the table sync state as SUBREL_STATE_DATASYNC.
Update the comment in check_old_cluster_subscription_state() to accurately
describe this corrected behavior.

Author: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Backpatch-through: 17, where the code was introduced
Discussion: https://postgr.es/m/CAA4eK1+KaSf5nV_tWy+SDGV6MnFnKMhdt41jJjSDWm6yCyOcTw@mail.gmail.com
Discussion: https://postgr.es/m/aUTekQTg4OYnw-Co@paquier.xyz
This commit is contained in:
Amit Kapila 2025-12-24 09:55:03 +00:00
parent 0ed8f1afb1
commit a1cdb81201
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/bin/pg_upgrade/check.c
View file

@ -2055,9 +2055,9 @@ check_old_cluster_subscription_state(void)
* other states listed below are not supported:
*
* a) SUBREL_STATE_DATASYNC: A relation upgraded while in this state
* would retain a replication slot, which could not be dropped by the
* sync worker spawned after the upgrade because the subscription ID
* used for the slot name won't match anymore.
* would retain a replication slot and origin. The sync worker spawned
* after the upgrade cannot be drop then because the subscription ID
* used for the slot and origin name no longer matches.
*
* b) SUBREL_STATE_SYNCDONE: A relation upgraded while in this state
* would retain the replication origin when there is a failure in