Simplify dxsyn_lexize().

There's no need to create and free a temporary copy of the input,
since str_tolower() is already able to cope with not-certainly-
nul-terminated input.  (Before v18, copying was needed because
this code used lowerstr(), but now we can do without.)

Author: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/19525-b0be8e4eb7dbaf07@postgresql.org
This commit is contained in:
Tom Lane 2026-07-05 16:22:40 -04:00
parent 0e4f0827f6
commit 9f03dab457

View file

@ -212,13 +212,8 @@ dxsyn_lexize(PG_FUNCTION_ARGS)
PG_RETURN_POINTER(NULL);
/* Create search pattern */
{
char *temp = pnstrdup(in, length);
word.key = str_tolower(temp, length, DEFAULT_COLLATION_OID);
pfree(temp);
word.value = NULL;
}
word.key = str_tolower(in, length, DEFAULT_COLLATION_OID);
word.value = NULL;
/* Look for matching syn */
found = (Syn *) bsearch(&word, d->syn, d->len, sizeof(Syn), compare_syn);