upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-06-11 09:40:25 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix harmless leftover in _hash_kill_items()

Browse source 
Checking for 'havePin' is sufficient here. An earlier version of the
patch didn't have the 'havePin' variable and used
'so->hashso_bucket_buf == so->currPos.buf' as the condition when both
locking and unlocking the page. The havePin variable was added later
during development, but the unlocking condition wasn't fully
updated. Tidy it up.

Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/b9de8d05-3b02-4a27-9b0b-03972fa4bfd3@iki.fi
This commit is contained in:
Heikki Linnakangas 2026-04-07 17:38:11 +03:00
parent 55890a9194
commit 979387f188
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/backend/access/hash/hashutil.c
View file

@ -625,8 +625,7 @@ _hash_kill_items(IndexScanDesc scan)
}
unlock_page:
if (so->hashso_bucket_buf == so->currPos.buf ||
havePin)
if (havePin)
LockBuffer(so->currPos.buf, BUFFER_LOCK_UNLOCK);
else
_hash_relbuf(rel, buf);