upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-04-15 22:10:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix snapshot handling bug in recent BRIN fix

Browse source 
Commit a95e3d84c0 added ActiveSnapshot push+pop when processing
work-items (BRIN autosummarization), but forgot to handle the case of
a transaction failing during the run, which drops the snapshot untimely.
Fix by making the pop conditional on an element being actually there.

Author: Álvaro Herrera <alvherre@kurilemu.de>
Backpatch-through: 13
Discussion: https://postgr.es/m/202511041648.nofajnuddmwk@alvherre.pgsql
This commit is contained in:
Álvaro Herrera 2025-11-04 20:31:43 +01:00
parent 640c59067e
commit 8733f0b54c
No known key found for this signature in database
GPG key ID: 1C20ACB9D5C564AE
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/backend/postmaster/autovacuum.c
View file

@ -2544,7 +2544,8 @@ deleted:
PushActiveSnapshot(GetTransactionSnapshot());
perform_work_item(workitem);
PopActiveSnapshot();
if (ActiveSnapshotSet()) /* transaction could have aborted */
PopActiveSnapshot();
/*
* Check for config changes before acquiring lock for further jobs.