Improve error message for checksum failures in pgstat_database.c

This log message was referring to conflicts, but it is about checksum
failures.  The log message improved in this commit should never show up,
due to the fact that pgstat_prepare_report_checksum_failure() should
always be called before pgstat_report_checksum_failures_in_db(), with a
stats entry already created in the pgstats shared hash table.  The three
code paths able to report database-level checksum failures follow
already this requirement.

Oversight in b96d3c3897.

Author: Wang Peng <215722532@qq.com>
Discussion: https://postgr.es/m/tencent_9B6CD6D9D34AE28CDEADEC6188DB3BA1FE07@qq.com
Backpatch-through: 18
This commit is contained in:
Michael Paquier 2026-02-13 12:17:08 +09:00
parent d7edcec35c
commit 775fc01415

View file

@ -200,7 +200,7 @@ pgstat_report_checksum_failures_in_db(Oid dboid, int failurecount)
Assert(entry_ref);
if (!entry_ref)
{
elog(WARNING, "could not report %d conflicts for DB %u",
elog(WARNING, "could not report %d checksum failures for database %u",
failurecount, dboid);
return;
}