upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-05-26 11:15:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix regex searching for page verification failures in tests

Browse source 
The test for finding page verification failures in the logfiles
were missing the /m modifier to make sure it anchors to every
newline in the search space buffer, and not just the last one.

Spotted while adding a test for the recently reported issue with
excessive WAL for unlogged relations.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Satyanarayana Narlapuram <satyanarlapuram@gmail.com>
Reviewed-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Discussion: https://postgr.es/m/CAHg+QDeGrpZbNZdLjd_T4b43xKEEXZN0HGhkFm-1bkBdyzK7AQ@mail.gmail.com
This commit is contained in:
Daniel Gustafsson 2026-05-06 12:38:15 +02:00
parent 9a39056c41
commit 486b9a9b9e
4 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/test/modules/test_checksums/t/006_pgbench_single.pl
View file

@ -211,7 +211,7 @@ for (my $i = 0; $i < $TEST_ITERATIONS; $i++)
$node_loglocation);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in primary log (during WAL recovery)"
);
$node_loglocation = -s $node->logfile;
@ -249,7 +249,7 @@ for (my $i = 0; $i < $TEST_ITERATIONS; $i++)
$node_loglocation);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in primary log (outside WAL recovery)"
);
$node_loglocation = -s $node->logfile;
@ -276,7 +276,7 @@ my $log =
PostgreSQL::Test::Utils::slurp_file($node->logfile, $node_loglocation);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in primary log");
$node_loglocation = -s $node->logfile;

12
src/test/modules/test_checksums/t/007_pgbench_standby.pl
View file

@ -270,7 +270,7 @@ for (my $i = 0; $i < $TEST_ITERATIONS; $i++)
$node_primary_loglocation);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in primary log (during WAL recovery)"
);
$node_primary_loglocation = -s $node_primary->logfile;
@ -299,7 +299,7 @@ for (my $i = 0; $i < $TEST_ITERATIONS; $i++)
$node_standby_loglocation);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in standby_1 log (during WAL recovery)"
);
$node_standby_loglocation = -s $node_standby->logfile;
@ -341,7 +341,7 @@ for (my $i = 0; $i < $TEST_ITERATIONS; $i++)
$node_primary_loglocation);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in primary log (outside WAL recovery)"
);
$node_primary_loglocation = -s $node_primary->logfile;
@ -363,7 +363,7 @@ for (my $i = 0; $i < $TEST_ITERATIONS; $i++)
$node_standby_loglocation);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in standby_1 log (outside WAL recovery)"
);
$node_standby_loglocation = -s $node_standby->logfile;
@ -394,14 +394,14 @@ my $log = PostgreSQL::Test::Utils::slurp_file($node_primary->logfile,
$node_primary_loglocation);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in primary log");
$node_primary_loglocation = -s $node_primary->logfile;
$log = PostgreSQL::Test::Utils::slurp_file($node_standby->logfile,
$node_standby_loglocation);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in standby_1 log");
$node_standby_loglocation = -s $node_standby->logfile;

2
src/test/modules/test_checksums/t/008_pitr.pl
View file

@ -186,7 +186,7 @@ $node_pitr->stop;
my $log = PostgreSQL::Test::Utils::slurp_file($node_pitr->logfile, 0);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in pitr log");
done_testing();

2
src/test/modules/test_checksums/t/009_fpi.pl
View file

@ -58,7 +58,7 @@ $node->stop;
my $log = PostgreSQL::Test::Utils::slurp_file($node->logfile, 0);
unlike(
$log,
qr/page verification failed,.+\d$/,
qr/page verification failed,.+\d$/m,
"no checksum validation errors in server log");
done_testing();