upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-05-28 04:35:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

postgres_fdw: Fix syntax error in fetch_attstats().

Browse source 
When importing remote stats for a foreign table backed by a pre-v17
remote server, the query built/executed in this function has three NULL
placeholders for the range stats supported in v17 at the end of the
SELECT list.  Previously, it included a trailing comma after the last
NULL, like "SELECT ..., NULL, NULL, NULL, FROM pg_catalog.pg_stats ...",
causing a syntax error on the remote server.  Fix by removing the comma.

Oversight in commit 28972b6fc.

Author: Satya Narlapuram <satyanarlapuram@gmail.com>
Discussion: https://postgr.es/m/CAHg%2BQDdEE7wp1S60Fn9Kmna8KfdMo5Tu6dROLpMn_-EOUBKmWQ%40mail.gmail.com
This commit is contained in:
Etsuro Fujita 2026-05-08 13:15:00 +09:00
parent a1b754558a
commit 3f7a1afbae
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
contrib/postgres_fdw/postgres_fdw.c
View file

@ -5876,7 +5876,7 @@ fetch_attstats(PGconn *conn, int server_version_num,
" range_bounds_histogram");
else
appendStringInfoString(&sql,
" NULL, NULL, NULL,");
" NULL, NULL, NULL");
appendStringInfoString(&sql,
" FROM pg_catalog.pg_stats"