upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-04-21 06:08:26 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

jit: Fix accidentally-harmless type confusion

Browse source 
In 2a0faed9d7, which added JIT compilation support for expressions, I
accidentally used sizeof(LLVMBasicBlockRef *) instead of
sizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. That
turns out to have no real negative consequences due to LLVMBasicBlockRef being
a pointer itself (and thus having the same size). It still is wrong and
confusing, so fix it.

Reported by coverity.

Backpatch-through: 13
This commit is contained in:
Andres Freund 2025-11-04 18:36:18 -05:00
parent 3b5007347b
commit 3e45d8c67f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/backend/jit/llvm/llvmjit_expr.c
View file

@ -2203,7 +2203,7 @@ llvm_compile_expr(ExprState *state)
v_nullsp = l_ptr_const(nulls, l_ptr(TypeStorageBool));
/* create blocks for checking args */
b_checknulls = palloc(sizeof(LLVMBasicBlockRef *) * nargs);
b_checknulls = palloc(sizeof(LLVMBasicBlockRef) * nargs);
for (int argno = 0; argno < nargs; argno++)
{
b_checknulls[argno] =