upstream/postgresql
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-07-12 02:55:34 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

pgcrypto: avoid recursive ResourceOwnerForget().

Browse source 
Raising an error within a function using an OSSLCipher object led
to a complaint from ResourceOwnerForget and then a double-free crash,
because ResOwnerReleaseOSSLCipher forgot to unhook the OSSLCipher
object from its owner.  (The sibling logic for OSSLDigest objects got
this right, as did every other ReleaseResource function AFAICS.)

Oversight in cd694f60d.

Bug: #19527
Reported-by: Yuelin Wang <3020001251@tju.edu.cn>
Author: Yuelin Wang <3020001251@tju.edu.cn>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/19527-6e7686960c6dce78@postgresql.org
Backpatch-through: 17
This commit is contained in:
Tom Lane 2026-06-22 12:59:16 -04:00
parent e025267955
commit 020426268f
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
contrib/pgcrypto/openssl.c
View file

@ -832,7 +832,10 @@ px_find_cipher(const char *name, PX_Cipher **res)
static void
ResOwnerReleaseOSSLCipher(Datum res)
{
free_openssl_cipher((OSSLCipher *) DatumGetPointer(res));
OSSLCipher *cipher = (OSSLCipher *) DatumGetPointer(res);
cipher->owner = NULL;
free_openssl_cipher(cipher);
}
/*