upstream/packer
1
0
Fork 0
mirror of https://github.com/hashicorp/packer.git synced 2026-06-13 18:50:11 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
packer/acctest
History
Wilken Rivera 9b2f520b2d
Fix basic datasource acceptance test flakiness (#11438) 
This change sets a region on the test datasource config to fix intermittent InvalidAMIID.NotFound errors.

Closes https://github.com/hashicorp/packer-internal-issues/issues/14

Failing results before change

```
> AWS_DEFAULT_REGION=us-west-1 make testacc
=== RUN   TestAccInitAndBuildBasicAmazonAmiDatasource
2021/12/07 20:40:05 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2021/12/07 20:40:05 Found region us-west-1
2021/12/07 20:40:05 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
    pluginacc.go:143: Error running plugin acceptance tests: Bad exit code. Logfile: packer_log_amazon-ami_basic_datasource_test.txt
        Logs can be found at /Users/wilkenrivera/Development/packer/acctest/plugin/packer_log_amazon-ami_basic_datasource_test.txt
        and the acceptance test template can be found at /Users/wilkenrivera/Development/packer/acctest/plugin/amazon-ami_basic_datasource_test.pkr.hcl
--- FAIL: TestAccInitAndBuildBasicAmazonAmiDatasource (9.87s)
FAIL
FAIL    github.com/hashicorp/packer/acctest/plugin      10.326s
```

Passing results after change
```
> AWS_DEFAULT_REGION=us-west-1 make testacc
=== RUN   TestAccInitAndBuildBasicAmazonAmiDatasource
2021/12/07 20:47:28 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2021/12/07 20:47:28 Found region us-west-1
2021/12/07 20:47:28 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
--- PASS: TestAccInitAndBuildBasicAmazonAmiDatasource (223.32s)
PASS

```
2021-12-08 10:13:16 +01:00
..
plugin Fix basic datasource acceptance test flakiness (#11438) 2021-12-08 10:13:16 +01:00
testing.go move acctest pkg from sdk to core and update acceptance tests 2021-04-07 11:52:19 +02:00
testing_test.go move acctest pkg from sdk to core and update acceptance tests 2021-04-07 11:52:19 +02:00