upstream/packer
1
0
Fork 0
mirror of https://github.com/hashicorp/packer.git synced 2026-05-28 04:35:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix basic datasource acceptance test flakiness (#11438)

Browse source 
This change sets a region on the test datasource config to fix intermittent InvalidAMIID.NotFound errors.

Closes https://github.com/hashicorp/packer-internal-issues/issues/14

Failing results before change

```
> AWS_DEFAULT_REGION=us-west-1 make testacc
=== RUN   TestAccInitAndBuildBasicAmazonAmiDatasource
2021/12/07 20:40:05 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2021/12/07 20:40:05 Found region us-west-1
2021/12/07 20:40:05 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
    pluginacc.go:143: Error running plugin acceptance tests: Bad exit code. Logfile: packer_log_amazon-ami_basic_datasource_test.txt
        Logs can be found at /Users/wilkenrivera/Development/packer/acctest/plugin/packer_log_amazon-ami_basic_datasource_test.txt
        and the acceptance test template can be found at /Users/wilkenrivera/Development/packer/acctest/plugin/amazon-ami_basic_datasource_test.pkr.hcl
--- FAIL: TestAccInitAndBuildBasicAmazonAmiDatasource (9.87s)
FAIL
FAIL    github.com/hashicorp/packer/acctest/plugin      10.326s
```

Passing results after change
```
> AWS_DEFAULT_REGION=us-west-1 make testacc
=== RUN   TestAccInitAndBuildBasicAmazonAmiDatasource
2021/12/07 20:47:28 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2021/12/07 20:47:28 Found region us-west-1
2021/12/07 20:47:28 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
--- PASS: TestAccInitAndBuildBasicAmazonAmiDatasource (223.32s)
PASS

```
This commit is contained in:
Wilken Rivera 2021-12-08 04:13:16 -05:00 committed by GitHub
parent 3661155b74
commit 9b2f520b2d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
acctest/plugin/test-fixtures/basic-amazon-ami-datasource.pkr.hcl
View file

@ -13,6 +13,7 @@ data "amazon-ami" "test" {
root-device-type = "ebs"
virtualization-type = "hvm"
}
region = "us-west-2"
most_recent = true
owners = ["099720109477"]
}