Commit graph

6 commits

Author SHA1 Message Date
Wilken Rivera
c65bb2fdca Remove amazon plugin from acceptance test 2023-10-24 06:00:42 -04:00
Wilken Rivera
8490333f55 Fix broken acctest for Amazon data source
This change updates the Ubuntu image being from 16.04 to something more recent.
2023-10-02 06:50:04 -04:00
Wilken Rivera
999d751793 Rename duplicate ami name to fix failing test 2023-08-17 11:12:56 -04:00
Lucas Bajolet
a2930bda4f packer: warn on bundled plugins usage
Since bundled plugins will be removed in an upcoming version of Packer,
this commit adds a new warning message whenever a template uses one such
plugin.

This warning has been implemented on build, validate, console and the
inspect subcommands.

In addition to warning about the upcoming change and potential issue
this will cause, this warning message proposes solutions to the user so
they know what they'll have to do in order not to rely on those bundled
plugins later.
2023-07-18 15:36:12 -04:00
Wilken Rivera
9b2f520b2d
Fix basic datasource acceptance test flakiness (#11438)
This change sets a region on the test datasource config to fix intermittent InvalidAMIID.NotFound errors.

Closes https://github.com/hashicorp/packer-internal-issues/issues/14

Failing results before change

```
> AWS_DEFAULT_REGION=us-west-1 make testacc
=== RUN   TestAccInitAndBuildBasicAmazonAmiDatasource
2021/12/07 20:40:05 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2021/12/07 20:40:05 Found region us-west-1
2021/12/07 20:40:05 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
    pluginacc.go:143: Error running plugin acceptance tests: Bad exit code. Logfile: packer_log_amazon-ami_basic_datasource_test.txt
        Logs can be found at /Users/wilkenrivera/Development/packer/acctest/plugin/packer_log_amazon-ami_basic_datasource_test.txt
        and the acceptance test template can be found at /Users/wilkenrivera/Development/packer/acctest/plugin/amazon-ami_basic_datasource_test.pkr.hcl
--- FAIL: TestAccInitAndBuildBasicAmazonAmiDatasource (9.87s)
FAIL
FAIL    github.com/hashicorp/packer/acctest/plugin      10.326s
```

Passing results after change
```
> AWS_DEFAULT_REGION=us-west-1 make testacc
=== RUN   TestAccInitAndBuildBasicAmazonAmiDatasource
2021/12/07 20:47:28 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2021/12/07 20:47:28 Found region us-west-1
2021/12/07 20:47:28 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
--- PASS: TestAccInitAndBuildBasicAmazonAmiDatasource (223.32s)
PASS

```
2021-12-08 10:13:16 +01:00
sylviamoss
49474f8f37 add plugin acceptance test using amazon plugin 2021-04-07 16:21:15 +02:00