Commit graph

68181 commits

Author SHA1 Message Date
Arthur Schiwon
ddb65be58f
chore: cleanup unused code
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 18:19:09 +02:00
Arthur Schiwon
be50bd1b0f
fix: ensure searchBySystemTag() is available
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 18:19:08 +02:00
Arthur Schiwon
783e32a64d
fix: favorites view and universal search against tags
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 18:19:08 +02:00
Arthur Schiwon
b0d1cf5730
fix: change if with conditionless else to switch; and a parameter value
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 18:19:08 +02:00
Arthur Schiwon
58f7fd2370
use efficient tag retrieval on DAV report request
- uses DAV search approach against valid files joined by systemtag selector
- reduced table join for tag/systemtag search
- supports pagination
- no changes to the output formats or similar

Example request body:

<?xml version="1.0"?>
<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
  <d:prop>
    <d:getcontentlength/>
    <d:getcontenttype/>
    <d:getetag/>
    <d:getlastmodified/>
    <d:resourcetype/>
    <nc:face-detections/>
    <nc:file-metadata-size/>
    <nc:has-preview/>
    <nc:realpath/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:permissions/>
    <nc:nbItems/>
  </d:prop>
  <oc:filter-rules>
    <oc:systemtag>32</oc:systemtag>
  </oc:filter-rules>
  <d:limit>
    <d:nresults>50</d:nresults>
    <nc:firstresult>0</nc:firstresult>
  </d:limit>
</oc:filter-files>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 18:19:08 +02:00
John Molakvoæ
a17d01951f
Merge pull request #38927 from nextcloud/bugfix/noid/package.json-editorconfig 2023-06-21 16:41:05 +02:00
Joas Schilling
41267873b6
chore: Adjust editorconfig for package.json and package-lock.json
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-21 14:57:48 +02:00
John Molakvoæ
32bbe3db81
Merge pull request #38806 from nextcloud/feat/f2v/actions-1 2023-06-21 11:36:11 +02:00
John Molakvoæ
a70aa61dff
chore: add __tests__ and __mocks__ to file checker and fix updated names
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 10:14:34 +02:00
John Molakvoæ
89711482c5
chore: update old codecov config
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:27:56 +02:00
John Molakvoæ
45ecd55d89
feat: prepare jest coverage support
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:20:50 +02:00
John Molakvoæ
70ee8de0ab
fix(jest): replace mock with jest.spyOn
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:20:50 +02:00
John Molakvoæ
809631539e
feat: add open folder action testing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:20:50 +02:00
John Molakvoæ
1b0848a7dd
feat: add download action testing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:20:50 +02:00
John Molakvoæ
9fbdc00274
feat: add delete action testing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:08:04 +02:00
John Molakvoæ
c31b2329dc
feat: add sidebar action testing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:08:04 +02:00
John Molakvoæ
f8e697ce4d
feat: prepare jest upgrade and ts testing
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:08:04 +02:00
John Molakvoæ
8b5ef98495
fix: delete action import
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-06-21 09:08:04 +02:00
Simon L
5fb7ea22be
Merge pull request #38915 from nextcloud/enh/noid/increase-https-warning
adjust admin setup check to increase warning to configure https
2023-06-21 04:41:14 +02:00
Nextcloud bot
5474387209
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-06-21 00:37:42 +00:00
Simon L
d25d5d34f7 adjust admin setup check to increase warning to set up https
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-06-20 22:54:48 +02:00
Louis
358ce60b10
Merge pull request #38762 from fsamapoor/constructor_property_promotion_in_core_command_part1
Uses PHP8's constructor property promotion in core/Command/Encryption
2023-06-20 18:56:39 +02:00
Louis
6d33356ede
Merge pull request #38768 from fsamapoor/constructor_property_promotion_in_core_command_part5
Uses PHP8's constructor property promotion in core/Command/Config and Group
2023-06-20 17:49:32 +02:00
Simon L
56c16b306f
Merge pull request #38639 from charno/bugfix/36644-pruneOutdatedSyncTokens-deletes-all-entries
Bugfix/36644 pruneOutdatedSyncTokens deletes all entries
2023-06-20 16:36:28 +02:00
Faraz Samapoor
90035e98c1 Update core/Command/Encryption/DecryptAll.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-20 16:24:46 +02:00
Faraz Samapoor
9c2abae59c Update core/Command/Encryption/EncryptAll.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-20 16:24:46 +02:00
Faraz Samapoor
bcfbcbb91c Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 16:24:46 +02:00
Faraz Samapoor
2ace19fc54 Fixes php-cs error.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 16:24:46 +02:00
Faraz Samapoor
f9a9ad50c3 Uses PHP8's constructor property promotion in core/Command/Encryption classes.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 16:24:46 +02:00
Côme Chilliet
14ac281acf
Merge pull request #38638 from fsamapoor/constructor_property_promotion_part3
[3/3] Refactors /core controllers using constructor property promotion.
2023-06-20 15:33:53 +02:00
Côme Chilliet
d9e9d4e123
Merge pull request #35424 from nextcloud/cleanup/comments
Cleanup comments code
2023-06-20 14:50:04 +02:00
Côme Chilliet
7aa97dcc23
Throw if creation date is read before inserting into database
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-06-20 12:14:57 +02:00
Carl Schwan
77355a8a79
Improve typing in ICommentsManager
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-06-20 10:55:26 +02:00
Carl Schwan
9725d00329
Cleanup comments code
- Fix various psalm issues
- Add as much typing as possible while preserving stable API

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-06-20 10:55:20 +02:00
Faraz Samapoor
4ce7173f7e Update core/Controller/SetupController.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-20 10:38:46 +02:00
Faraz Samapoor
2800436948 Applies agreed-upon indentation convention to the changed controllers.
Based on https://github.com/nextcloud/server/pull/38636#discussion_r1218167753

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-20 10:38:46 +02:00
Faraz Samapoor
9eedeb4012 Refactors controllers by using PHP8's constructor property promotion.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-20 10:38:46 +02:00
Côme Chilliet
5063bf37ed
Merge pull request #38774 from fsamapoor/constructor_property_promotion_in_core_command_part8
Uses PHP8's constructor property promotion in core/Command/Log, /Security, and /SystemTag
2023-06-20 10:12:52 +02:00
Faraz Samapoor
51aae7866c Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 09:29:50 +02:00
Faraz Samapoor
3519689d50 Uses PHP8's constructor property promotion in core/Command/Config and core/Command/Group classes.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-20 09:29:50 +02:00
Nextcloud bot
64c19ce3aa
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-06-20 00:22:52 +00:00
Simon L
892a837ecb
Merge pull request #38888 from nextcloud/artonge/fix/dont_disable_action_during_save
Don't disable actions when saving share permissions
2023-06-20 00:32:54 +02:00
Julius Härtl
bec4f76e6b
Merge pull request #38890 from nextcloud/obj-store-copy-list-source-cache 2023-06-19 22:40:55 +02:00
Louis
d9bf410762
Merge pull request #38769 from fsamapoor/constructor_property_promotion_in_core_command_part6
Uses PHP8's constructor property promotion core/Command/App,/Background, and /Broadcast
2023-06-19 21:09:24 +02:00
Simon L
f8cf61addf
Merge pull request #38876 from Freiheitswolke/style/config/alphabetise-preview-providers
style(config): alphabetise preview providers
2023-06-19 20:24:02 +02:00
Faraz Samapoor
f63c52a396 Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 17:44:48 +02:00
Faraz Samapoor
d83944fd10 Uses PHP8's constructor property promotion.
in core/Command/Log, /Security, and /SystemTag classes.

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 17:44:48 +02:00
Louis
81bb3362b2
Merge pull request #38767 from fsamapoor/constructor_property_promotion_in_core_command_part4
Uses PHP8's constructor property promotion in core/Command/Maintenance
2023-06-19 17:43:12 +02:00
Louis
98ea74bb40
Merge pull request #38764 from fsamapoor/constructor_property_promotion_in_core_command_part2
Uses PHP8's constructor property promotion in core/Command/Db classes.
2023-06-19 17:27:10 +02:00
Louis
c24e05f9c0
Merge pull request #38766 from fsamapoor/constructor_property_promotion_in_core_command_part3
Uses PHP8's constructor property promotion in core/Command/User classes.
2023-06-19 17:09:08 +02:00