Commit graph

715 commits

Author SHA1 Message Date
Ferdinand Thiessen
d535c377cf fix: recommended apps button test
Regression of https://github.com/nextcloud/server/pull/52703 where the
`>` was added by accident and thus the button has a wrong label
including the rest of the button HTML.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-28 13:54:10 +02:00
nfebe
04f227a102 fix(unified_search): Reset result limit for new search requests
Before now the result limit is never reset until the page is refreshed.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-05-16 10:52:40 +01:00
nfebe
b35fad7a03 fix(unified_search): Maintain non-provider filters when loading more results
Maintain existing non-provider filters (like date and person filters) while
loading more results for a specific provider.

This now works as the provider data passed to the `newResults` array after search
is built dynamically and not manually, the result of a manual build was that the
`provider.filters` properpy which is used in the `find` method was being left out
in the providers pushed into the results array.

Fixes #52081

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-05-16 10:52:28 +01:00
skjnldsv
3dbc479239 chore(cypress): add setup tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-05-09 21:59:23 +02:00
Ferdinand Thiessen
77b663231f
chore: migrate types to @simplewebauthn/browser (changes package layout)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-18 23:56:06 +02:00
nfebe
933b068f22 fix(login): Improve CSRF error message for better user understanding
This commit changes the CSRF error message displayed in the login form to
provide more specific information to the user. Instead of the generic less helpful error.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-03-25 14:26:13 +01:00
Ferdinand Thiessen
60dd89e04c
fix(core): adjust fronend code for changes in webauthn library
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 11:19:48 +01:00
Ferdinand Thiessen
fb52d0a02b
fix(login): simplify code and use consistent layout
- Simplify vue code
- Use nc buttons for consistent design

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-18 16:40:15 +01:00
Ferdinand Thiessen
8035c8d6b8
Merge pull request #51418 from nextcloud/fix/unified-search-bar
fix(unified-search): do not overlap search bar with button
2025-03-18 15:36:34 +01:00
skjnldsv
2eea322594 fix(core): setup fieldset spacing
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-13 20:51:00 +01:00
skjnldsv
0179cb4d8d feat(core): add setup cypress tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-13 20:51:00 +01:00
skjnldsv
cc12719df5 feat(core): migrate setup to vue
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-13 16:00:18 +01:00
Ferdinand Thiessen
9a006eb29c
fix(unified-search): do not overlap search with button
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-12 10:27:29 +01:00
Valdnet
45b0a0379e fix(l10n): remove unnecessary space
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2025-02-28 16:42:14 +01:00
Maksim Sukharev
afd27f4bc4 fix: wipe local storages on log out
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-02-24 10:37:19 +01:00
Ferdinand Thiessen
b06f5ba4c4
refactor: Migrate nextcloud-vue usage to new import schema
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-20 02:28:13 +01:00
Ferdinand Thiessen
917b77a026
fix(login): only show error state on login box if user interacted
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-17 10:50:27 +01:00
nfebe
d2fc45acbd fix(unified-search): filteredProviders now inherits all provider props
The main providers come from both the backend and client side plugins such as `in-folder` search.
The main providers may carry callbacks functions and other information that should be passed to the `filteredProviders`.
This is important because the current code does not make a distinction between `filteredProviders` and `providers`
rightly so, becuase they are the same thing!

Without the mentioned distinction above, sooner or later, we try to access a property on the `filteredProviders` which we
did not transfer with the manual property copy.

----

This fix prevents in-folder search from searching everywhere when "load more results" is clicked; Essentially ignoring the in-folder
search filter.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-03 12:48:00 +01:00
nfebe
8863b85420 fix: Use searchFrom property for client side plugins
The client-side plugin `in-folder` uses the `files` provider, this makes it
overlap with the main files provider itself.

This change follows eecda06f1a after it was discovered
that some apps/providers like `dav` use providers from another app like `contacts`

Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-30 17:35:00 +00:00
SebastianKrupinski
bf5a54d132 fix: unified search provider id
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-30 16:36:50 +01:00
nfebe
a5307ac512 fix(unified-search): Prevent multiple file picker triggers in in-folder search
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-29 12:50:12 +01:00
nfebe
d3dc6beb00 refactor: Drop deprecated use of defineStore
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-29 12:50:12 +01:00
nfebe
eecda06f1a fix(unified-search): Use appId for searching
Each provider may search from a particular app so we should use that for searching.

Before this commit, we used `provider.id` instead of `provider.appId` the problem with the previous
approach is that it forces the provider id to be a valid search provider (an app that supports search)
limiting the developers ability to use unique IDs to identify the different providers (especially plugin providers)
inside the places filter.

For example the Files search plugin "In folder" (search in folder plugin) was required to have id as `files` while the
files provider itself already has id as `files`.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-29 12:50:12 +01:00
Ferdinand Thiessen
c5c5f68f48 fix(unifiedsearch): Simplify and correct thumbnail styles
Ensure that the if a preview is available the maximum sizes are
respected (clickable area).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-27 18:17:53 +01:00
Maksim Sukharev
c464aeb228 fix(UnifiedSearch): request data only when opening modal
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-18 09:52:50 +01:00
Ferdinand Thiessen
24851d930d
chore: Resolve ESLint warnings
- Add default value to non-required Vue props
- Reformat function to async function if needed
- Add some documentation
- Allow `any` in places where it makes sense (tests)
- Order vue component sections as required

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-16 22:18:29 +01:00
nfebe
ed59ccea46 feat: Adapt providers disabled property to match user applied filters
Some filters are only available for certain providers, the UI should give the user
a hint to what providers such filters are available in.

Currently, if a filter (date or person) is not support by an a provider, the provider is
blurred out in the places dropdown.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-13 11:21:23 +01:00
Richard Steinmetz
f91446023d
feat(contacts-menu): implement custom javascript hook action
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-09 14:41:41 +01:00
Ferdinand Thiessen
1df23140b8 fix: Redirect user to login if session is terminated
If a session timed out or was closed in another tab,
then currently the user gets random error messages.
This intercepts 401 responses (should only happen if logged out, or the
users does something wrong).

If we get a 401, we make sure its because of the session,
by checking if the user can access the files app.
If that is also the case we forward the user to the login page
and set the redirect URL to the last used URL.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-12-19 18:56:46 +01:00
Ferdinand Thiessen
0945169e57 fix(recommended-apps): Typo "screen sharing" vs "screensharing"
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 15:14:15 +01:00
Ferdinand Thiessen
52769a47ed fix(core): Do not use v-html for translation output
The content that can be renderered does *not* include HTML (see
`recommended` object).
But `v-html` was used, this is potentially dangerous, even though we
sanitize the translation values, so no urgent harm but better safe than
sorry.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 09:35:23 +00:00
Ferdinand Thiessen
f6e6ba4851 refactor(styles): Adjust code style in SCSS sources to match our stylelint config
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-19 09:42:13 +01:00
skjnldsv
b15fdfd40e chore(profile): move profile app from core to apps
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-14 10:25:02 +01:00
Faisal Alghamdi
cccdaa10eb Fix(core): fix app menu alignment in RTL mode.
Signed-off-by: Faisal Alghamdi <falghamdi125@gmail.com>
2024-11-09 11:25:37 +01:00
skjnldsv
ed901604ab feat(core): offer clipboard fallback for non-secure environments
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-08 14:01:33 +01:00
Ferdinand Thiessen
d7376891a2
fix(unified-search): Close on second ctrl+f
Also only add the event listener if short-cuts are not disabled for accessibility reasons.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 13:24:07 +02:00
Ferdinand Thiessen
e8c1e2c611
fix(code-style): Adjust JS code to our code style
This resolves 68 ESLint warnings about invalid code style.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-16 22:11:59 +02:00
Grigorii K. Shartsev
7e03371dd7 chore(sass): migrate from deprecated mixed decls
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-14 18:52:36 +02:00
Christopher Ng
3c12d27c17 chore: Add text file icon class
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-09 14:34:53 -07:00
Louis Chemineau
c0e5635ade fix: Vue app names
This improves the debugging experience in the vue dev tool.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-10-09 19:49:07 +02:00
Ferdinand Thiessen
dec9a39a18
chore: Move legacy dialogs template from files to core until we can remove it
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-20 13:47:08 +02:00
Ferdinand Thiessen
085aab24ff
chore: fix usage of deprecated functions and adjust code style
This solves 57 ESLint warnings by replacing deprecated code with `@nextcloud/` libraries,
as well as adding missing type information, importing jQuery instead of relying on global one,
and the same with Moment.js.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-20 03:30:20 +02:00
John Molakvoæ (skjnldsv)
b24e02e5df
fix(core): profile design and pronouns support
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-18 00:15:19 +02:00
John Molakvoæ (skjnldsv)
26abc86eca
feat: add profile pronouns
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-17 22:20:36 +02:00
Christopher Ng
65ced2dd40 fix: Fix inaccessible content on public pages due to overlapping footer
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-05 16:19:22 -07:00
Ferdinand Thiessen
04b25ba59d
feat: Implement Vue UI for public page menu
This adds a Vue implementation of the public page menu,
that is the menu that can be added using `PublicTemplateResponse::setHeaderActions`.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-03 16:07:49 +02:00
fenn-cs
18d0f39109 fix(UnifiedSearch): Restore normal dialog size
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-08-30 10:08:58 +01:00
Ferdinand Thiessen
aea0e8df6a fix: Adjust more places for logical position
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 08:32:48 +00:00
Ferdinand Thiessen
7b048e0501 fix: Adjust some minor styles issues
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 08:32:48 +00:00
Mostafa Ahangarha
c5baf3d7ef Fix: float and clear
Fix other background-positions
Minor fix in link button icon position
Update header left and right to start and end

Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
2024-08-29 08:32:47 +00:00