upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-14 19:20:35 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

fix: recommended apps button test

Browse source 
Regression of https://github.com/nextcloud/server/pull/52703 where the
`>` was added by accident and thus the button has a wrong label
including the rest of the button HTML.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This commit is contained in:
Ferdinand Thiessen 2025-05-22 13:37:56 +02:00
parent f833e2d219
commit d535c377cf
2 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
core/src/components/setup/RecommendedApps.vue
View file

@ -38,17 +38,16 @@
<div class="dialog-row">
<NcButton v-if="showInstallButton && !installingApps"
type="tertiary"
role="link"
data-cy-setup-recommended-apps-skip
:href="defaultPageUrl"
data-cy-setup-recommended-apps-skip>
variant="tertiary">
{{ t('core', 'Skip') }}
</NcButton>
<NcButton v-if="showInstallButton"
type="primary"
data-cy-setup-recommended-apps-install
:disabled="installingApps || !isAnyAppSelected"
data-cy-setup-recommended-apps-install>
variant="primary"
@click.stop.prevent="installApps">
{{ installingApps ? t('core', 'Installing apps …') : t('core', 'Install recommended apps') }}
</NcButton>

13
cypress/e2e/core/setup.ts
View file

@ -124,8 +124,19 @@ function sharedSetup() {
cy.location('pathname', { timeout: 10000 })
.should('include', '/core/apps/recommended')
// See the apps setup
cy.get('[data-cy-setup-recommended-apps]')
.should('be.visible')
.within(() => {
cy.findByRole('heading', { name: 'Recommended apps' })
.should('be.visible')
cy.findByRole('link', { name: 'Skip' })
.should('be.visible')
cy.findByRole('button', { name: 'Install recommended apps' })
.should('be.visible')
})
// Skip the setup apps
cy.get('[data-cy-setup-recommended-apps]').should('be.visible')
cy.get('[data-cy-setup-recommended-apps-skip]').click()
// Go to files