Commit graph

1762 commits

Author SHA1 Message Date
Maxence Lange
ba6d74b6de fix(share): assume download enabled on federated share
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-05-29 14:52:00 +02:00
Ferdinand Thiessen
e51e4d6c3e
fix(files_sharing): show note, label and list of uploaded files on file drop
This was missing from the Vue migration of the public share view:
- Show the note as the description of the file drop
- Show the label as the heading of the file drop if available
- Show list of uploaded files for verification

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-26 14:14:40 +02:00
Louis Chemineau
617af2f3cc fix: Replace the deprecated direct download link with the public DAV endpoint
Follow-up of #48098

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-22 08:30:36 +00:00
Robin Appelman
9a52cfc25e
Merge pull request #52689 from nextcloud/backport/52133/stable31
[stable31] fix: disable direct download for shares
2025-05-16 10:23:24 +02:00
Robin Appelman
465486e335 fix: fix unjailedroot of nested jails if there are other wrappers in between
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-15 14:57:05 +02:00
Robin Appelman
9f77860b54 fix: disable direct download for shares
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-08 13:14:31 +00:00
nfebe
80c901a08a fix(files_sharing): Move ConfigLexicon to Config dir, update sharing input
- Fix autoloading for new `ConfigLexicon`
- Ensure that sharing input in sharing tab respect `show-federated-shares-as-internal`:
This is important, because when federated shares are shown as internal the users should add them from the internal shares section

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-05-06 15:53:07 +01:00
Maxence Lange
cac0f1cdcd refactor: use config lexicon
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-05-06 15:37:34 +01:00
nfebe
67ef7e1653 feat(files_sharing): Add toggle for federated share display area
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-05-06 15:37:34 +01:00
skjnldsv
206f9fba0b fix(files_sharing): bring back owner and ownerDisplayName initial state
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-30 09:32:15 +00:00
Ferdinand Thiessen
2f7e0dc09b revert: do not unify hide-download and prevent-download permissions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 14:26:16 +02:00
Ferdinand Thiessen
c412f2ab72 fix(files_sharing): do not show download button if hide-download is enabled
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 14:26:16 +02:00
John Molakvoæ
3f528a2726 fix(files_sharing): adjust rate limit share creation to 20 over 10 minutes
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-04-15 08:58:17 +00:00
skjnldsv
aec6eeb5b8 fix(files_sharing): rate limit share creation 10 times per 10 minutes
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-15 08:58:17 +00:00
skjnldsv
f81ef274dd fix(files_sharing): fix share creation error handling
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-09 15:22:32 +00:00
Marcel Klehr
0273b4d0ba perf(sharing): Use oc_share.{item_type, share_type} IN instead of OR equals
to improve performance by using the db index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-03-28 14:46:30 +01:00
Côme Chilliet
8b41055297
fix(files_sharing): Use session id as part of cache key to avoid concurrency issues
If several people are watching and seeking the same video file we do not
 want the cache key to be the same or it would flood activity again.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-27 12:19:02 +01:00
Côme Chilliet
d9b2178ee1
fix(files_sharing): Set higher priority for listeners that may abort the request
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-27 12:18:56 +01:00
Côme Chilliet
0c293b3569
fix: Avoid triggering several activities for Range request on the same file
Avoids flooding activities when someone browse a video in the web player.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-27 12:18:51 +01:00
Côme Chilliet
97dbbe4768
fix: Fix download activity for folders
Remove duplicate activity publishing from share controller download,
 listen to BeforeZipCreatedEvent to publish activity for folders, and
 cache folders activity to avoid sending activity for each file in the
 folder.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-27 12:18:46 +01:00
Côme Chilliet
6ff8d1e43b
fix(sharing): Publish activity for download by public link
Even if dav endpoint is now used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-27 12:18:23 +01:00
Luka Trovic
833ec55728 fix(files_sharing): skip expiration notify for invalid share record
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2025-03-21 07:15:49 +01:00
Ferdinand Thiessen
324582729a
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:54:06 +01:00
Ferdinand Thiessen
aa7300b53d
fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:39:33 +01:00
Ferdinand Thiessen
77ba2a6d75 fix(files_sharing): Also list deleted team shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-20 15:02:48 +00:00
Andy Scherzinger
f0a229c92f
Merge pull request #50880 from nextcloud/backport/50873/stable31
[stable31] fix(files_sharing): block downloading if needed
2025-02-19 20:45:17 +01:00
Ferdinand Thiessen
28fd638017 fix(files_sharing): block downloading if needed
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-18 13:31:31 +00:00
Git'Fellow
b2b37ba604 fix(SharedStorage): Check if storage ID is set on cache
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-02-14 15:01:39 +00:00
Robin Appelman
5eac86afec fix: don't use cached root info from shared cache if the watcher has detected an update
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-11 20:35:46 +01:00
nfebe
ba2a1ec72f refactor: Remove some deprecated containers and exceptions
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-06 12:55:10 +00:00
Ferdinand Thiessen
8fc1b6f1cd fix(sharing): Ensure download restrictions are not dropped
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-04 15:06:11 +00:00
Andy Scherzinger
c99c135520
Merge pull request #50508 from nextcloud/backport/50436/stable31
[stable31] fix: Harden files scanner for invalid null access
2025-01-28 23:52:39 +01:00
Ferdinand Thiessen
26c93519f2 fix: Harden files scanner for invalid null access
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 19:49:03 +00:00
Ferdinand Thiessen
2926fe270a fix(files_sharing): Respect permissions passed when creating link shares
Given:
User creates a link or email share with permissions=4 (create only = file drop).

Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.

Solution:
Respect what the user is requesting, create a file drop share.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 17:26:28 +00:00
Ferdinand Thiessen
57949b2e22 fix: Ensure label is always a string
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-26 20:00:33 +00:00
Anna
d9a7124592
Merge pull request #49898 from nextcloud/fix/noid/no-emails-for-user-shares
fix(sharing): send share emails for internal users too
2025-01-16 18:50:30 +01:00
Christopher Ng
0eb39d7b9c feat(sharing): Respect admin custom tokens setting
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 -08:00
Christopher Ng
4d78de497f feat(sharing): Add custom_tokens capability
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 -08:00
Christopher Ng
beffb26266 feat(sharing): Fetch a unique generated token
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:49:19 -08:00
Christopher Ng
f92875cf6a feat(sharing): Allow updating share token
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:49:19 -08:00
provokateurin
90c608bdc7
fix(files_sharing): Fix sharee search result types
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-13 15:21:21 +01:00
provokateurin
9f59204148
fix(files_sharing): Gracefully handle fetching non-existent share
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-13 15:21:20 +01:00
provokateurin
4dfa02c29d
fix(files_sharing): Handle null userId
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-13 15:19:54 +01:00
Anna Larch
236e084fbb fix(sharing): send share emails for internal users too
Signed-off-by: Anna Larch <anna@nextcloud.com>
2025-01-13 14:13:02 +01:00
skjnldsv
5c359e424f feat(federatedfilesharing): auto-accept shares from trusted servers
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-09 12:54:51 +01:00
provokateurin
085d4c9364
refactor(OpenAPI): Adjust scopes to match previous behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-06 14:30:40 +01:00
skjnldsv
bc0ad5efbf fix(federatedfilesharing): get share by token fallback
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-28 09:27:30 +01:00
skjnldsv
8089de5fcf fix(activity): make emails for link share uploads true by default
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-06 12:34:52 +01:00
Maxence Lange
4591430c9c feat(ocm): signing ocm requests
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-12-04 09:30:55 -01:00
Stephan Orbaugh
e87ed9b5fb
Merge pull request #49569 from nextcloud/shared-watcher-perf
perf: improve performance of SharedStorage::getWatcher
2024-12-03 09:57:56 +01:00