upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

fix(files_sharing): Gracefully handle fetching non-existent share

Browse source 
Signed-off-by: provokateurin <kate@provokateurin.de>
This commit is contained in:
provokateurin 2025-01-06 12:47:21 +01:00
parent 4dfa02c29d
commit 9f59204148
No known key found for this signature in database
1 changed files with 5 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
apps/files_sharing/lib/External/Manager.php vendored
View file

@ -160,13 +160,7 @@ class Manager {
$query->execute([$remote, $token, $password, $name, $owner, $user, $mountPoint, $hash, $accepted, $remoteId, $parent, $shareType]);
}
/**
* get share
*
* @param int $id share id
* @return mixed share of false
*/
private function fetchShare($id) {
private function fetchShare(int $id): array|false {
$getShare = $this->connection->prepare('
SELECT `id`, `remote`, `remote_id`, `share_token`, `name`, `owner`, `user`, `mountpoint`, `accepted`, `parent`, `share_type`, `password`, `mountpoint_hash`
FROM `*PREFIX*share_external`
@ -208,15 +202,12 @@ class Manager {
return null;
}
/**
* get share
*
* @param int $id share id
* @return mixed share of false
*/
public function getShare(int $id, ?string $user = null): array|false {
$user = $user ?? $this->uid;
$share = $this->fetchShare($id);
if ($share === false) {
return false;
}
// check if the user is allowed to access it
if ($this->canAccessShare($share, $user)) {
@ -256,7 +247,7 @@ class Manager {
&& $share['user'] === $user) {
return true;
}
// If the share is a group share, check if the user is in the group
if ((int)$share['share_type'] === IShare::TYPE_GROUP) {
$parentId = (int)$share['parent'];