Côme Chilliet
a51886569e
chore: Pass correct type for alias in QueryBuilderTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:31 +02:00
Côme Chilliet
4eed4bff3a
chore: Fix test in user_ldap passing wrong type
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:30 +02:00
Côme Chilliet
1b53179ba9
chore: Update guest avatar test image
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:30 +02:00
Côme Chilliet
b2a69d0095
fix: Silence PHP warnings from fopen and mkdir
...
We are testing the result and logging our own error anyway.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:30 +02:00
Côme Chilliet
6515fa638a
fix: Add explicit getToken method for PublicKeyToken entity
...
This allows mocking the method in tests, and makes sure typing is
respected
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:30 +02:00
Benjamin Gaussorgues
d089bc7d4c
chore(users): add stricter return types to IUser
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:30 +02:00
Côme Chilliet
1f246dec14
chore(tests): Set a token string to avoid getToken returning null from tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:29 +02:00
Benjamin Gaussorgues
10e9fe13d5
chore(workflows): add APCu extension on no db tests
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:29 +02:00
Côme Chilliet
ee8227762c
chore: Exclude S3 groups from test:db composer command
...
These groups need a specific setup and are not supported by our main DB
testing workflows.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:29 +02:00
Côme Chilliet
805902eed3
chore: Re-enable tests failing on drone
...
We do not use drone anymore, let’s see if we can fix these tests or if
they should be removed.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:29 +02:00
Côme Chilliet
c0a822df26
chore: Exclude skipped groups from nodb test suite
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:29 +02:00
Côme Chilliet
23e9a81477
fix(cache): Improve typing of ICache and CappedMemoryCache
...
For CappedMemoryCache we allow string|int to be consistent with PHP
array keys, for ICache we strictly apply the previously stated string
type for keys.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:28 +02:00
Côme Chilliet
5cbf113315
chore: List skipped tests in PHPUnit output
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:28 +02:00
Benjamin Gaussorgues
a8fb722b0e
chore: add strict types in IAddressBook::getKey
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:28 +02:00
Benjamin Gaussorgues
a07634e383
chore(L10N): add strict types in L10N::localeExists
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:28 +02:00
Côme Chilliet
c6452f01a5
chore(tests): Fix User UID mocking in TwoFactorAuth/ManagerTest.php
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:28 +02:00
Côme Chilliet
b4f86c032c
chore(tests): Avoid deprecation in PublicKeyTokenProvider
...
Also cleaned up the test a bit.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:27 +02:00
Benjamin Gaussorgues
73506e8486
chore(deprecated): remove Reflection*::setAccessible as it's noop since PHP 8.1
...
Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:27 +02:00
Benjamin Gaussorgues
83b863499a
chore(deprecated): remove imagedestroy as it's noop since PHP 8.0
...
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:05 +02:00
Kate
0302d60f0c
Merge pull request #61176 from nextcloud/fix/deprecated-85
...
fix: resolve PHP deprecation of `imagedestroy`
2026-06-11 08:14:34 +02:00
Nextcloud bot
bb8bc057ac
fix(l10n): Update translations from Transifex
...
CodeQL Advanced / Analyze (actions) (push) Waiting to run
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Integration sqlite / changes (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, --tags ~@large files_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, capabilities_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, collaboration_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, comments_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, dav_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, federation_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, file_conversions) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, files_reminders) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, filesdrop_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, guests_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, ldap_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, openldap_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, openldap_numerical_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, routing_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, setup_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, sharees_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, sharing_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, theming_features) (push) Has been cancelled
Integration sqlite / integration-sqlite (master, main, 8.4, main, videoverification_features) (push) Has been cancelled
Integration sqlite / integration-sqlite-summary (push) Has been cancelled
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2026-06-11 00:23:13 +00:00
Ferdinand Thiessen
2a5fc73ca9
fix: resolve PHP deprecation of imagedestroy
...
> Prior to PHP 8.0.0, imagedestroy() freed any memory associated with the image resource.
> As of 8.0.0, the GD extension uses objects instead of resources, and objects cannot be explicitly closed.
With PHP 8.5 this is deprecated and causes a deprecation warning!
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-06-11 00:59:15 +02:00
Benjamin Gaussorgues
2b7415ef4d
Merge pull request #60960 from nextcloud/carl/querybuilder-magic-number
...
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Integration sqlite / changes (push) Waiting to run
Integration sqlite / integration-sqlite (master, main, 8.4, main, --tags ~@large files_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, capabilities_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, collaboration_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, comments_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, dav_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, federation_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, file_conversions) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, files_reminders) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, filesdrop_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, guests_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, ldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, openldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, openldap_numerical_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, routing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, setup_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, sharees_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, sharing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, theming_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, videoverification_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite-summary (push) Blocked by required conditions
Psalm static code analysis / changes (push) Waiting to run
Psalm static code analysis / static-code-analysis (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis-security (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis-ocp (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis-ncu (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis-strict (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis-summary (push) Blocked by required conditions
refactor: Use new IQueryBuilder::MAX_IN_PARAMETERS
2026-06-10 23:09:30 +02:00
Kate
8948e923e8
Merge pull request #61169 from nextcloud/test/parent-setup
...
test: Add missing calls to the parent setUp method
2026-06-10 22:12:55 +02:00
provokateurin
405d250aef
test: Add missing calls to the parent setUp method
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2026-06-10 18:07:52 +02:00
Louis
8fc2e1c2b3
Merge pull request #61153 from nextcloud/test/migrate-files-regression-playwright
...
test(files): migrate recent-view and regression specs from Cypress to…
2026-06-10 17:56:13 +02:00
Louis
954fc50274
Merge pull request #61152 from nextcloud/test/migrate-files-actions-playwright
...
test(files): migrate files actions e2e from Cypress to Playwright
2026-06-10 17:45:27 +02:00
Carl Schwan
6fc428a512
Merge pull request #61145 from nextcloud/test/migrate-favorites-playwright
...
test(files): migrate favorites e2e from Cypress to Playwright
2026-06-10 17:38:04 +02:00
Stephan Orbaugh
1cf3e362b2
Merge pull request #40407 from haslersn/revert-pr-12573
...
Revert "Do not do redirect handling when loggin out"
2026-06-10 17:33:10 +02:00
Louis
250635a9a8
Merge pull request #61150 from nextcloud/carl/speedup-tests
...
Speedup tests execution
2026-06-10 17:23:13 +02:00
Joas Schilling
3b89bf256e
Merge pull request #61149 from nextcloud/dependabot/composer/symfony/dom-crawler-7.4.12
...
build(deps): bump symfony/dom-crawler from 6.4.32 to 7.4.12
2026-06-10 17:17:46 +02:00
Peter R.
20c9360c58
Merge pull request #61109 from nextcloud/fix/waffle-current-app-icon-light-bg
...
fix(core): keep app menu settings icon legible on light backgrounds
2026-06-10 17:14:33 +02:00
Carl Schwan
c02a231e7f
perf(CheckSetupController): Remove BackupStaticProperties
...
It's so slow 25s per test cases
Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-10 16:36:06 +02:00
Cristian Scheid
3592f83218
Merge pull request #60844 from nextcloud/fix/noid/files-join-ext-cache-select-fields
...
feat(file-search): add property to SearchQuery and check select fields to decide wheter to join extended cache
2026-06-10 16:26:55 +02:00
Ferdinand Thiessen
9848f9e65a
Merge pull request #61143 from nextcloud/ci/playwright
...
docs(tests): Add some general documentation for PlayWright
2026-06-10 16:11:36 +02:00
Joas Schilling
92ad5b1081
build(deps): bump symfony/dom-crawler from 6.4.32 to 7.4.12
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2026-06-10 15:57:02 +02:00
Louis
20926ea9dd
Merge pull request #61141 from nextcloud/artonge/test/warn_about_slow_startup_time
...
test: Warn about slow startup time for phpunit tests
2026-06-10 15:53:00 +02:00
Louis Chmn
6bb9ad60f2
test(View): Setup users and groups once
...
Signed-off-by: Louis Chmn <louis@chmn.me>
2026-06-10 15:48:24 +02:00
Carl Schwan
8bff1b4968
perf(UserConfigTest): Don't recreate database between invocation
...
Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-10 15:48:24 +02:00
Louis Chmn
442777762d
test(App): Setup users and groups once
...
Signed-off-by: Louis Chmn <louis@chmn.me>
2026-06-10 15:48:24 +02:00
Louis Chmn
f2b91fce0b
test: Warn about slow startup time for phpunit tests
...
Signed-off-by: Louis Chmn <louis@chmn.me>
2026-06-10 15:07:25 +02:00
Peter Ringelmann
b256bbe7ad
test(files): migrate recent-view and regression specs from Cypress to Playwright
...
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
2026-06-10 14:58:49 +02:00
Louis
782f3f7838
Merge pull request #61144 from nextcloud/fix/noid/workflow-db-versions
...
CodeQL Advanced / Analyze (javascript-typescript) (push) Waiting to run
Integration sqlite / changes (push) Waiting to run
Integration sqlite / integration-sqlite (master, main, 8.4, main, --tags ~@large files_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, capabilities_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, collaboration_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, comments_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, dav_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, federation_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, file_conversions) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, files_reminders) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, filesdrop_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, guests_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, ldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, openldap_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, openldap_numerical_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, routing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, setup_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, sharees_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, sharing_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, theming_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite (master, main, 8.4, main, videoverification_features) (push) Blocked by required conditions
Integration sqlite / integration-sqlite-summary (push) Blocked by required conditions
Psalm static code analysis / changes (push) Waiting to run
Psalm static code analysis / static-code-analysis (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis-security (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis-ocp (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis-ncu (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis-strict (push) Blocked by required conditions
Psalm static code analysis / static-code-analysis-summary (push) Blocked by required conditions
chore(workflows): keep only lowest and highest supported versions of dbs
2026-06-10 14:46:11 +02:00
Peter Ringelmann
4ea6917b7b
fix(core): keep app menu settings icon legible on light backgrounds
...
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2026-06-10 12:29:23 +00:00
Ferdinand Thiessen
7e1adfb1fa
test(playwright): reduce potential flakiness of appstore tests
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-06-10 13:59:16 +02:00
Ferdinand Thiessen
b70a151778
ci: improve playwright workflow speed
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-06-10 13:59:16 +02:00
Peter Ringelmann
ad93216416
test(files): migrate files actions e2e from Cypress to Playwright
...
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
2026-06-10 12:43:28 +02:00
Carl Schwan
3b7ca63f43
perf(AppConfigIntegrationTest): Avoid creating too many times AppConfig
...
Reuse instance by merging some tests based on DataProviders
Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-10 12:17:08 +02:00
Cristian Scheid
750779c075
chore(workflows): keep only lowest and highest supported versions of dbs
...
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
2026-06-10 12:12:17 +02:00
Peter Ringelmann
87f8d78424
test(files): migrate favorites e2e from Cypress to Playwright
...
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
2026-06-10 12:09:32 +02:00