Commit graph

63501 commits

Author SHA1 Message Date
Vincent Petry
89cb450c84
Detect leading spaces in config files
Because those will cause PHP to output to stdout and will cause
unrelated error messages.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-03 10:51:10 +02:00
Julius Härtl
9475cc02b2
Merge pull request #32958 from nextcloud/fix/noid/permission-update-allow-public-uploads 2022-08-02 16:49:27 +02:00
Côme Chilliet
5cce1dfc60
Merge pull request #33425 from nextcloud/fix/fix-dynamic-properties-in-tests
Fix dynamic property creations in test files
2022-08-02 16:01:09 +02:00
Vincent Petry
6aec09e0c5
Merge pull request #33428 from nextcloud/improve-accessibility-device
Improve Devices & sessions settings
2022-08-02 15:33:19 +02:00
Vincent Petry
fbc6000913
Merge pull request #33432 from nextcloud/nickvergessen-patch-1
Remove "needs info" label when the issue is not stale anymore
2022-08-02 14:53:34 +02:00
Côme Chilliet
7ae6791737
Document all getIncomplete implementations as returning string|false
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-02 14:23:14 +02:00
Joas Schilling
b6f23ce9b4
Remove "needs info" label when the issue is not stale anymore
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2022-08-02 11:33:20 +02:00
Julien Veyssier
acc68e9f93
fix share manager tests
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-08-02 01:35:10 +02:00
Carl Schwan
256c78374f
Improve Devices & sessions settings
- Add label for better accessibility
- Only allow to add app token with a name
- Align in rows

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-02 00:38:28 +02:00
Julius Härtl
e750137a9a
Merge pull request #33405 from nextcloud/perf/new-index-mounts-class 2022-08-01 21:27:09 +02:00
Côme Chilliet
cb271b759e
Fix dynamic property creations in test files
This fixes warnings in PHP 8.2

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-01 15:07:53 +02:00
Julien Veyssier
e251e0c314
don't reduce file public link permissions if public upload is not enabled
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-08-01 15:00:51 +02:00
Marcel Klehr
047cc708d4 DB mounts table: Add index for mount_provider_class
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2022-08-01 14:27:34 +02:00
Carl Schwan
f74e89bde5
Merge pull request #32482 from nextcloud/enh/noid/share-attributes
Add share attributes + prevent download permission
2022-08-01 09:44:31 +02:00
Carl Schwan
7b723813ce
Multiple fixes
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-31 19:37:59 +02:00
Carl Schwan
952acd4d27
Merge pull request #33225 from nextcloud/fix/handle-one-time-passwords
Handle one time password better
2022-07-29 12:26:52 +02:00
Carl Schwan
ab1a20522b
Enforcing permission during resharing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-28 16:54:13 +02:00
Vincent Petry
bbb5043c07
Inherit hide download from share attributes
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:54:13 +02:00
Vincent Petry
3cfb4cbf94
Block download when needed on direct download endpoint
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:54:13 +02:00
Vincent Petry
2ee659e547
Fix view-only code after code review comments
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:24 +02:00
Julius Härtl
2fb7a1feeb
Fix adding to empty attributes and duplicate request
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-07-28 16:53:23 +02:00
Vincent Petry
a11c6e7cc3
Add share attrs + download permission support in frontend
Added download permission checkbox in frontend
Added share attributes parsing and setting in frontend.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:23 +02:00
Vincent Petry
92e60e3858
Add nc:share-attributes Webdav property
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:23 +02:00
Vincent Petry
54a0d8fe64
Don't reset share attributes when not specified
When not specified in the OCS call, don't reset the share attributes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:23 +02:00
Vincent Petry
dbbc426f75
Attempt to fix sqlite json issue
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:23 +02:00
Vincent Petry
03b1791cca
Fix share attribute related tests + code style
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +02:00
Vincent Petry
9493f86de3
Fix share controller to accept share attributes alone
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +02:00
Vincent Petry
a95c19e14b
Add share attributes + prevent download permission
Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +02:00
Julia Kirschenheuter
532ea001a5
Merge pull request #33394 from nextcloud/fix/fix-370-Label_not_connected_to_form-element_in_file_listing
Connect ```input``` checkbox with corresponding file name via ```aria-describedby```
2022-07-28 15:59:47 +02:00
Carl Schwan
702445ba3b
Handle one time password better
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-28 14:26:25 +02:00
julia.kirschenheuter
ef3fb28446 Connect ``input` checkbox with corresponding file name via `aria-describedby``
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2022-07-28 14:20:32 +02:00
Louis
ee23f41abe
Merge pull request #33385 from nextcloud/fix/transfer-aria-label-from-nav-settings-to-settings-icon
Transfer `aria-label` from nav settings menu to settings menu icon-button
2022-07-28 14:11:13 +02:00
Vincent Petry
7566692e3b
Merge pull request #33081 from nextcloud/techdebt/noid/ocp-security-bruteforce-ithrottler
Add a public interface for the bruteforce throttler and register for …
2022-07-28 13:34:55 +02:00
Vincent Petry
a1bf9b9757
Merge pull request #33280 from nextcloud/externalStorageWithoutVersioning
handle AccessDenied error when checking if external s3 support versions
2022-07-28 12:13:43 +02:00
julia.kirschenheuter
f22427be89 Transfer aria-label from nav settings menu to settings menu icon-button
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2022-07-28 11:20:34 +02:00
Matthieu Gallien
54c05bcdb9 handle AccessDenied error when checking if external s3 support versions
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-07-28 09:20:12 +00:00
Louis
d2d408bba7
Merge pull request #33299 from nextcloud/fix/files-dark-color-theme
[files app]: Fix dark color mode detection for filelist
2022-07-28 11:04:16 +02:00
Joas Schilling
c0f47af2d0
Add a public interface for the bruteforce throttler and register for injection
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-28 10:57:10 +02:00
Côme Chilliet
472f4cad47
Merge pull request #33380 from luzpaz/fix/lib-private-typos
Fix typos in lib/private subdirectory
2022-07-28 09:17:48 +02:00
dependabot[bot]
97e88f34e9
Merge pull request #32244 from nextcloud/dependabot/npm_and_yarn/core-js-3.22.3 2022-07-27 20:53:11 +00:00
dependabot[bot]
ef7ffa5157 Bump core-js from 3.22.0 to 3.22.3
Bumps [core-js](https://github.com/zloirock/core-js) from 3.22.0 to 3.22.3.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.22.0...v3.22.3)

---
updated-dependencies:
- dependency-name: core-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-07-27 20:16:28 +00:00
Julius Härtl
365df8999d
Merge pull request #33386 from nextcloud/fix/noid/delete-user-value 2022-07-27 18:31:01 +02:00
Vincent Petry
3094ee94fe
Merge pull request #33379 from nextcloud/techdebt/noid/goodbye-legacy-ids
Remove more legacy ids
2022-07-27 17:14:46 +02:00
Vincent Petry
a02dee7c69
Merge pull request #32956 from nextcloud/fix/upload-folder-wrong-content
Handle file contained inside the uploads folder
2022-07-27 17:06:39 +02:00
Julien Veyssier
361e69f19f
fix mistake in db query to delete a user config value
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-07-27 16:45:10 +02:00
Daniel
d24823bda5
Merge pull request #33378 from nextcloud/s3-no-null-bundle
don't set `null` as a bundle path
2022-07-27 15:43:08 +02:00
luz paz
368f83095d Fix typos in lib/private subdirectory
Found via `codespell -q 3 -S l10n -L jus ./lib/private`

Signed-off-by: luz paz <luzpaz@github.com>
2022-07-27 08:52:17 -04:00
Vincent Petry
3e9c52ae5f
Merge pull request #33316 from nextcloud/bugfix/noid/aria-label-share-link-buttons
Accessible names for share panel buttons
2022-07-27 14:31:48 +02:00
Vincent Petry
00066cbeaf
Remove more legacy ids
Remove more unused legacy ids from early ownCloud times.

This reduces the number of duplicate ids in the DOM.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-27 14:29:26 +02:00
Vincent Petry
fc276ba42f
Merge pull request #33373 from nextcloud/techdebt/noid/remove-legacy-dir
Remove legacy #dir element in files list
2022-07-27 13:44:52 +02:00