Commit graph

370 commits

Author SHA1 Message Date
Côme Chilliet
ca3e1a531a
Merge gmp and bcmath module checks with the existing PHP modules setup check
Also add description for why each module is recommended

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:07:21 +01:00
provokateurin
b64ab5fba8
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-01-18 16:14:17 +01:00
Côme Chilliet
a77bab2f95
Migrate set_time_limit setup check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 12:36:53 +01:00
Côme Chilliet
5ad549a72f
Migrate memcached PHP module setup check to new API
Merged it with the other existing memcache setup check as it fits

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 09:40:43 +01:00
Côme Chilliet
0e889da4a8
Remove obsolete check of curl SSL version
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 16:14:40 +01:00
Côme Chilliet
46ebe16c83 Migrate Cron checks to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 10:49:19 +01:00
Côme Chilliet
0483064f07 Migrate overwrite.cli.url setup check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 09:05:40 +01:00
Côme Chilliet
24f8b04908
Remove CSRF check from code integrity rescan
Did not find a way to get a valid token from SetupCheck

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +01:00
Côme Chilliet
f06b8da249
Migrate code integrity to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:38 +01:00
Côme Chilliet
f789732922
Merge pull request #42640 from nextcloud/fix/fix-authentication-exceptions-2
Always catch OCP versions of authentication exceptions
2024-01-11 18:51:43 +01:00
Côme Chilliet
8fc39aeb1c Use IToken from OCP instead of OC
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +01:00
Côme Chilliet
95ea6188dc Suppress or fix psalm errors related to InvalidTokenException
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +01:00
Côme Chilliet
eee9f1eec4 Always catch OCP versions of authentication exceptions
And always throw OC versions for BC

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +01:00
Côme Chilliet
d1f2add10c Migrate PHP imagick module check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 11:28:59 +01:00
Joas Schilling
2c815256f2
Merge pull request #42590 from nextcloud/add-settings-section-type-attribute
Add settings section type attribute on settings app-content section
2024-01-10 09:23:26 +01:00
Côme Chilliet
3d4c4f19b4
Migrate app dir owner check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 17:37:14 +01:00
Côme Chilliet
989b5ffbab
Remove unused properties from CheckSetupControllerTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +01:00
Côme Chilliet
3f13a1a47e
Migrate opcache check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +01:00
Thomas Citharel
c75fbf8a83
Add data-active-section-type attribute to app-content settings section
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-01-05 09:58:46 +01:00
Côme Chilliet
95ea46c99c Merge SQlite warning to existing SupportedDatabase setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-12-07 15:45:27 +01:00
1 Man Projects
6ef5958007
Fix AppSettingsController.php overwriting currentLanguage
Fix for CurrentLanguage being overwritten by currentVersion thus breaking App-View

Signed-off-by: 1 Man Projects <reed@1manprojects.de>
2023-12-05 20:24:35 +01:00
Côme Chilliet
51758117a7
Migrate database pending bigint conversions check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-28 14:07:47 +01:00
Côme Chilliet
1b547c7db8 Migrate missing primary key database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
ad88c04f2d Migrate missing index database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
2cb1c0f2dc Migrate missing column database check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Côme Chilliet
0107c7ea24 Migrate Forwarded For Headers check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 11:36:42 +01:00
Côme Chilliet
fe8b5d47ae
Migrate Bruteforce Throttle check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 16:26:59 +01:00
Côme Chilliet
7495236034
Migrate memory_limit check to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 15:55:46 +01:00
Côme Chilliet
00d3856b92
Revert "Migrate code integrity to SetupCheck API"
This reverts commit aa2d315d95d37b48752d0e92d0ce79913be1d4f1.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:04 +01:00
Côme Chilliet
0fd5ed9854
Migrate 32bit check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
ac3da13b38
Migrate Freetype check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
086d3ceecc
Migrate code integrity to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
147b29fca2
Migrate Randomness secure check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +01:00
Côme Chilliet
ddd13a90d8
Migrate memcache check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:02 +01:00
Côme Chilliet
6911dc30e6
Migrated both file locking checks to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +01:00
Côme Chilliet
f9770b8ef2
Remove duplicate fileinfo PHP module check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +01:00
Côme Chilliet
3c75075eba
Migrate database transaction level check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +01:00
Côme Chilliet
5957a2bf6b
Migrate email test to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +01:00
Côme Chilliet
506f3961ec
Remove duplicated ReadOnlyConfig setup check
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +01:00
Côme Chilliet
dec52f6979
Migrate getenv test to new SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +01:00
Côme Chilliet
d0ed5ea2f3
Merge pull request #40889 from nextcloud/feat/check-for-more-php-modules
Check for more php modules
2023-10-26 19:13:28 +02:00
Joas Schilling
2b7f78fc2e
Merge pull request #40326 from nextcloud/enh/text-to-image-api
Implement TextToImage OCP API
2023-10-26 15:53:30 +02:00
Joas Schilling
db8e57a727
Don't duplicate notification warning
Ref https://github.com/nextcloud/notifications/pull/1699

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-26 09:46:28 +02:00
Côme Chilliet
1bdf952fde
Make sure that OC interfaces returns OC interfaces for backward compatibility
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-23 11:08:23 +02:00
Marcel Klehr
9787f9dba0 enh(Text2Image): Add AI settings section to text2image
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-10-22 11:10:24 +02:00
Côme Chilliet
0c346849f3
Migrate missing PHP modules check to new API and improve it
Test all modules listed as required in our documentation

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 15:58:45 +02:00
Côme Chilliet
efa2dfa641
Add OCP interface for SetupCheckManager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:02 +02:00
Côme Chilliet
bd37067821
Migrate InternetConnectivity check to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:01 +02:00
Côme Chilliet
05cb1415e1
Merge setupchecks from new API into old UI
This will allow migrating checks to the new API without touching the UI
 for now.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:01 +02:00
Côme Chilliet
8bfa0935b4
Migrate NeedsSystemAddressBookSync to new ISetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:00 +02:00
Côme Chilliet
a4618cfea0
Move existing setup checks to new API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:00 +02:00
Carl Schwan
c71e47f5c3
Progress
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-10-19 11:43:58 +02:00
Carl Schwan
eb1d612d96
Add api to register setup checks
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-10-19 11:43:58 +02:00
Simon L
e5b11ced4a address review
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-10-06 16:22:02 +02:00
Simon L
6439fdf5b6 Move inline docs to online documentation
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-10-05 15:42:47 +02:00
Christoph Wurst
dd3cd29224
Merge pull request #39175 from shdehnavi/settings_app_users_controller_square_bracket_syntax
use square bracket syntax to modify array
2023-09-27 20:31:11 +02:00
jld3103
c2d45cb172
Add single status code descriptions for OpenAPI
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-09-27 08:05:21 +02:00
Côme Chilliet
0a9371f99f
Migrate applications away from deprecated ILogger
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-21 11:57:21 +02:00
Anna Larch
56419d94f8 enh(db): provide database providers via API
To avoid leaking internals (OC), wrap the getDatabasePlatform and provide the
associated constants

fixes https://github.com/nextcloud/server/issues/30877

Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-19 11:56:44 +02:00
Anna Larch
7f11ee8c4a fix(CardDAV): only run upgrade sync if 1000 users or less
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-26 17:21:50 +02:00
Joas Schilling
bed3ffb312
feat(admin): Show an error when the admin is throttled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +02:00
Joas Schilling
93f0399a92
fix(memcache): Fix comparison of Memcache configs to classes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-16 16:05:50 +02:00
Côme Chilliet
487f5963a1 Use Server::get instead of new to avoid troubles with encryption constructors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-08-08 09:14:16 +02:00
Marcel Klehr
f72f3f7df4
AI admin settings: strict_types
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-02 12:37:35 +02:00
Marcel Klehr
a840e8c6e5
AI admin settings: Add save mechanism
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-02 12:37:35 +02:00
Marcel Klehr
fc9780a41d
First pass at ai admin settings
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-08-02 12:37:35 +02:00
Joas Schilling
ab70bbd3ff
fix(db)!: Remove private legacy event because we can not keep it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:35 +02:00
Joas Schilling
bd0a149a4f
feat(dispatcher): Add typed event for "db:add-missing-primary-keys"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:32 +02:00
Joas Schilling
2eded24eff
feat(dispatcher): Add typed event for "db:add-missing-columns"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:32 +02:00
Daniel
0411cc64aa
Merge pull request #38606 from fsamapoor/replace_strpos_calls_in_settings_app
Refactors "strpos" calls in /apps/settings
2023-07-24 12:52:21 +02:00
Julius Härtl
925bcebcb6
feat: Add public event for missing indices
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-07-14 13:11:22 +02:00
jld3103
da7062b939
settings: Add OpenAPI spec
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-10 17:06:32 +02:00
Hamid Dehnavi
8850c66ab8 use square bracket syntax to modify array
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-07-05 21:36:45 +03:30
Faraz Samapoor
8778f2912f
Merge branch 'master' into replace_strpos_calls_in_settings_app
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-12 16:52:06 +03:30
Simon L
c93be182dc
Merge pull request #38543 from fsamapoor/use_null_coalescing_operator
Uses "Null Coalescing Operator" to improve code readability.
2023-06-12 09:42:43 +02:00
Faraz Samapoor
ff0b3feb2e Refactors "strpos" calls in /apps/settings to improve code readability.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-05 14:39:40 +02:00
Daniel Kesselberg
5a23b429dd
feat: remove check for OpenSSL 1.0.1d and 1.0.2b
OpenSSL 1.0.1d: 2013-02-05
OpenSSL 1.0.2b: 2015-06-11

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-04 18:44:47 +02:00
Faraz Samapoor
716a659468 Uses "Null Coalescing Operator" to improve code readability.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-05-31 14:51:52 +03:30
Andy Scherzinger
f5c4f55576
Merge pull request #37451 from Fenn-CS/fix/36437/deprecate-php-8.0
Deprecate PHP8.0
2023-04-19 15:28:12 +02:00
fenn-cs
60a710c91c Deprecate PHP8.0
PHP8.0 would stop receiving security support on 26 Nov 2023
 hence this deprecation. Next, is the eventual drop of PHP8.0 before its EOL.

This commit also updates the message type from INFO to WARNING if the php
 on file has reached its EOL.

See: https://www.php.net/supported-versions.php

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-04-17 23:45:59 +01:00
Simon L
80645a591a add an admin check for db file locking
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 12:51:33 +02:00
jld3103
d9f8522003
Fix types for reading and writing config values
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +02:00
Varun Patil
35ea5025dd check-setup: recommend exif extension
JPEG previews are not correctly oriented when exif is not enabled
along with other issues. There's no easy way to discover this either.

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-03-24 18:30:37 -07:00
julia.kirschenheuter
0cfbe54a5a Create headings for settings pages
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-03-07 17:51:19 +01:00
MichaIng
7e725c5d94
Check for opcache.file_cache_only=1
which disables shared memory based OPcache with disk file cache used only, if enabled. In this case, "opcache.memory_consumption" and others do not apply, so show the correct performance recommendation to enable memory cache.

Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 18:55:50 +01:00
Côme Chilliet
dde5c46a3e
Migrate to Symfony Mailer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +01:00
MichaIng
03390ee791 Fix interned strings buffer check if 0 free bytes
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely.

This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched.

Signed-off-by: MichaIng <micha@dietpi.com>
2023-01-23 08:55:35 +00:00
Côme Chilliet
7ebbb6b2ca
Remove workarounds specific to 7.4
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:08 +01:00
Joas Schilling
b4a29644cc
Add a const for the max user password length
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 11:23:43 +01:00
Carl Schwan
7f44a66296
Fix case sensitivity of email when saving settings
Otherwise we detect a email change all the time and since email are
immutable in ldap this prevent updating other fields.

Related: https://github.com/nextcloud/server/pull/33813

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-12-16 17:47:42 +01:00
Thomas Citharel
0cc50aff49
Add section-id and section-type data attributes to settings <li> navigation items
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-12-05 12:19:21 +01:00
Carl Schwan
8dcd992ad4
Merge pull request #34940 from nextcloud/feat/add-mastodon
Add mastodon and reorganize profile info section
2022-11-22 17:47:04 +01:00
julia.kirschenheuter
3559334fec Help pages: set window title for sidebar sections
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2022-11-22 09:31:28 +01:00
Carl Schwan
d1209d8302 Rename mastodon to fediverse
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 08:40:12 +01:00
Carl Schwan
86d9626901 Add mastodon personal info field
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-21 16:28:56 +01:00
Côme Chilliet
c2cb790532
Merge pull request #34745 from nextcloud/optimize-show-apps
Extract $ignoreMaxApps from array_map callback in AppSettingsController
2022-11-21 15:20:11 +01:00
Simon L
73c5591f68
Merge pull request #35024 from nextcloud/deprecate/php74
Deprecate PHP7.4
2022-11-14 20:35:54 +01:00
Robin Appelman
abaa3ef61b
Merge pull request #34485 from michaelkuhn/hasBigIntConversionPendingColumns-files_trash
Fix hasBigIntConversionPendingColumns missing files_trash
2022-11-11 17:09:26 +01:00
Christoph Wurst
75a1721d7d
Deprecate PHP7.4
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-10 09:56:32 +01:00
szaimen
f9e9cd270d
Limit-number-of-concurrent-preview-generations
Signed-off-by: Bowen Ding <dbw9580@live.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-11-05 16:03:01 +08:00
Thomas Citharel
3eab7ca3d4
Extract $ignoreMaxApps from array_map callback in AppSettingsController
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-10-22 20:03:02 +02:00
Michael Kuhn
9a205bdc84 Fix hasBigIntConversionPendingColumns missing files_trash
The two tables seem to have gone out of sync, causing the web interface
to miss `files_trash.auto_id` not being a bigint.

Signed-off-by: Michael Kuhn <github@ikkoku.de>
2022-10-09 13:37:05 +02:00
acsfer
4207b80141 Harden some PHP functions
To avoid things like https://github.com/nextcloud/server/issues/26034

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-10-04 13:22:03 +02:00
Vincent Petry
cd21caf846
Merge pull request #34067 from nextcloud/timm2k-patch-1
Convert file_metadata.id from int(11) to bigint(20)
2022-09-15 14:03:30 +02:00
Vincent Petry
da01494a37
Add accessibility entry in user menu
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-14 15:05:35 +02:00
timm2k
0c407b58db
Update CheckSetupController.php
file_metadata.id needs to be bigint(20).

Signed-off-by: timm2k <timm2k@gmx.de>
2022-09-14 10:10:12 +02:00
Carl Schwan
2397ea7219
Merge branch 'master' into fix/setting/accessibility-title
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-02 12:05:51 +02:00
Carl Schwan
9689f734e8
Merge pull request #33429 from nextcloud/port-password-vue
Port password settings to vue
2022-08-31 20:47:25 +02:00
Carl Schwan
60c42914d8
Port password settings to vue
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-31 17:42:36 +02:00
szaimen
955b6bb82e add a way to open the admin settings overview directly
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-08-30 15:46:09 +02:00
Arthur Schiwon
1a781ccf56
Fix opening Help page throws Exception
- Commit 458c2fa297 provoked the error,
  because the "core" "app" was not found. Previously, false was
  returned, but now an AppPathNotFoundException
- IUrlGenerator::linkTo() accepts an empty app argument however, moving
  the "core" portion to the path solves it and avoids apps lookup

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-08-24 18:55:34 +02:00
szaimen
cf9b1082ed add a setup check for 64 bit
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-13 09:33:33 +00:00
Carl Schwan
f99a06c89a Don't allow setting password bigger than 469 characters
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 11:47:25 +02:00
szaimen
f8bebb62ca do not display the buffer_size info if the size is already set to a certain threshold
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2022-06-17 22:15:28 +02:00
Valdnet
dfe7243338
l10n: Delete apostrophe
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-07 16:41:38 +02:00
Valdnet
1bc6fb2c58
l10n: Change to a capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-03 09:34:15 +02:00
Carl Schwan
046d5451b1 Improve accessibility of the title of the settings
Before every setting page had the same title and this is causing issues
for screenreaders since they can't differenciate the title of page. Now
a new variable is available for apps to declare the page subtitle.

This new variable is implemented for the settings app and while at it I
added a bit more type hinting to the stuff I touched :)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-16 22:47:37 +02:00
Louis Chemineau
8a2cf5bb68 Do not dispatch postSetPassword when setPassword fails
Also Improve error message when setPassword fails

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-05 17:21:23 +02:00
rakekniven
d2830612d0
l10n: Improve grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-04-27 08:19:19 +02:00
Vincent Petry
4511bd4bf6
Merge pull request #30950 from nextcloud/enh/opcache-recommends-translation
Add OPcache recommendations to Transifex
2022-03-24 17:56:09 +01:00
Joas Schilling
a0c7798c7d
Limit the length of app password names
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 10:47:56 +01:00
MichaIng
31606c9861 Add OPcache recommendations to Transifex
Fixes: https://github.com/nextcloud/server/issues/30941

Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-22 10:42:51 +00:00
Simon L
3a0b934f84
Merge pull request #31430 from nextcloud/enh/31429/improve-overwrite-cli-url-check
Validate `overwrite.cli.url` to be a url in setup check
2022-03-10 12:40:59 +01:00
szaimen
4191a178dd improve overwrite cli url setup check
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-09 22:26:00 +01:00
John Molakvoæ
23e8ae15aa
Merge pull request #31470 from nextcloud/enh/13099/allow-disable-imagick-warning 2022-03-08 08:53:12 +01:00
szaimen
7dca146b58 allow to disable the imagick warning
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2022-03-07 17:35:12 +01:00
Julien Veyssier
d5574cf189
allow adding protocol to domains in 'connectivity_check_domains' config
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-03-07 14:13:11 +01:00
MichaIng
3980322621
Merge pull request #31267 from nextcloud/enh/docs-link-for-opcache-recommends
Add Nextcloud docs link to OPcache recommends
2022-03-04 01:24:10 +01:00
MichaIng
5ac91f1cb8 Add Nextcloud docs link to OPcache recommends
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.

Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.

Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-03 23:00:07 +00:00
Mickey Knox
f63eb4261f Fix permittedPath comparison
Signed-off-by: Mickey Knox <mickey@netfreaks.org>
2022-03-02 22:38:11 +01:00
Carl Schwan
7c8a901b84 Cleanup admin settings js files
* Move admin.js to webpack, so that this use the bundled jquery files
  instead of the deprecated window.$ Also fixing formatting

* Remove log.js that seems to be from a time where logreader was bundled
  with server and I couldn't find an usage of it anymore

* Fix recent regression in rebuild navigation function (now not depending on
  jquery anymore and bundled by webpack).

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-17 17:52:03 +01:00
Arthur Schiwon
b28aa52b28
Setup warning for invalid LDAP user or group UUIDs.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:15:01 +01:00
szaimen
84cf39f582 show if the mail server settings are not set or verified
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-03 20:16:35 +01:00
MichaIng
79cdb565dc Avoid zero division in setup checks
Fixes: https://github.com/nextcloud/server/issues/30532

Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-11 10:26:57 +00:00
MichaIng
82c1beaacb Enhance and complement OPcache setup checks
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.

With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.

The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.

A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.

OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.

Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +01:00
Joas Schilling
19d070850b
Make sure trusted_proxies is an array
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +01:00
Vitor Mattos
e55ceb2bb1
Show warning on admin settings page
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:50 +02:00
Julien Veyssier
facb50ebcc
fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-18 12:39:43 +02:00
Christoph Wurst
4b8f8c5203
Deprecate PHP7.3 for Nextcloud 23
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-18 09:15:54 +02:00
Bjoern Schiessle
664bd5802f add 'supported'-label to all supported apps, also if they are not downloaded yet
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2021-10-06 22:17:50 +02:00
Carl Schwan
6958d8005a
Add admin privilege delegation for admin settings
This makes it possible for selected groups to access some settings
pages.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +02:00
Stefan
eb46011680 Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +02:00
Stefan
8758b36ebb Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +02:00
Arthur Schiwon
27865d03c0
use specific email getter where necessary
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +02:00
Carl Schwan
07ccccecad
Only recommand for php-sodium on >= PHP 7.4
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.

So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-08-06 14:22:09 +02:00
Christoph Wurst
43e41ca532
Merge pull request #28259 from nextcloud/work/carl/sodium-check
Check that php was compiled with argon2 support or that the php-sodium extensions is installed
2021-07-30 17:34:10 +02:00
Carl Schwan
8e51a5feda
Check that php was compiled with argon2 support or that the php-sodium
extensions is installed

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-07-30 15:11:55 +02:00
Julien Veyssier
416d10f76c refs #21045 add app config to disable unlimited quota and to set max quota
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-29 19:31:36 +00:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 -04:00