upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-22 23:03:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 78

Add a const for the max user password length

Browse source 
Signed-off-by: Joas Schilling <coding@schilljs.com>
This commit is contained in:
Joas Schilling 2023-01-04 11:23:43 +01:00
parent ce50acd9b2
commit b4a29644cc
No known key found for this signature in database
GPG key ID: 74434EFE0D2E2205
5 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/provisioning_api/lib/Controller/UsersController.php
View file

@ -389,7 +389,7 @@ class UsersController extends AUserData {
}
$generatePasswordResetToken = false;
if (strlen($password) > 469) {
if (strlen($password) > IUserManager::MAX_PASSWORD_LENGTH) {
throw new OCSException('Invalid password value', 101);
}
if ($password === '') {
@ -889,7 +889,7 @@ class UsersController extends AUserData {
break;
case self::USER_FIELD_PASSWORD:
try {
if (strlen($value) > 469) {
if (strlen($value) > IUserManager::MAX_PASSWORD_LENGTH) {
throw new OCSException('Invalid password value', 102);
}
if (!$targetUser->canChangePassword()) {

4
apps/settings/lib/Controller/ChangePasswordController.php
View file

@ -95,7 +95,7 @@ class ChangePasswordController extends Controller {
}
try {
if ($newpassword === null || strlen($newpassword) > 469 || $user->setPassword($newpassword) === false) {
if ($newpassword === null || strlen($newpassword) > IUserManager::MAX_PASSWORD_LENGTH || $user->setPassword($newpassword) === false) {
return new JSONResponse([
'status' => 'error',
'data' => [
@ -146,7 +146,7 @@ class ChangePasswordController extends Controller {
]);
}
if (strlen($password) > 469) {
if (strlen($password) > IUserManager::MAX_PASSWORD_LENGTH) {
return new JSONResponse([
'status' => 'error',
'data' => [

2
core/Controller/LostController.php
View file

@ -240,7 +240,7 @@ class LostController extends Controller {
$this->eventDispatcher->dispatchTyped(new BeforePasswordResetEvent($user, $password));
\OC_Hook::emit('\OC\Core\LostPassword\Controller\LostController', 'pre_passwordReset', ['uid' => $userId, 'password' => $password]);
if (strlen($password) > 469) {
if (strlen($password) > IUserManager::MAX_PASSWORD_LENGTH) {
throw new HintException('Password too long', $this->l10n->t('Password is too long. Maximum allowed length is 469 characters.'));
}

3
lib/private/Authentication/Token/PublicKeyTokenProvider.php
View file

@ -40,6 +40,7 @@ use OCP\AppFramework\Db\DoesNotExistException;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\IConfig;
use OCP\IDBConnection;
use OCP\IUserManager;
use OCP\Security\ICrypto;
use Psr\Log\LoggerInterface;
@ -397,7 +398,7 @@ class PublicKeyTokenProvider implements IProvider {
$dbToken->setPrivateKey($this->encrypt($privateKey, $token));
if (!is_null($password) && $this->config->getSystemValueBool('auth.storeCryptedPassword', true)) {
if (strlen($password) > 469) {
if (strlen($password) > IUserManager::MAX_PASSWORD_LENGTH) {
throw new \RuntimeException('Trying to save a password with more than 469 characters is not supported. If you want to use big passwords, disable the auth.storeCryptedPassword option in config.php');
}
$dbToken->setPassword($this->encryptPassword($password, $publicKey));

6
lib/public/IUserManager.php
View file

@ -46,6 +46,12 @@ namespace OCP;
* @since 8.0.0
*/
interface IUserManager {
/**
* @since 26.0.0
*/
public const MAX_PASSWORD_LENGTH = 469;
/**
* register a user backend
*