Commit graph

65065 commits

Author SHA1 Message Date
John Molakvoæ
5c8453928a
Merge pull request #35269 from nextcloud/fix/remove-pending
Remove completed comments
2022-11-19 00:05:18 +01:00
blizzz
eac6378646
Merge pull request #34677 from nextcloud/fix/34602/background-image-migration
optimize background image migration job
2022-11-18 23:14:37 +01:00
Arthur Schiwon
9892bdc3c3
rename placeholder
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-11-18 22:30:03 +01:00
Arthur Schiwon
0297a03698
fix const visibility
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-11-18 22:24:59 +01:00
blizzz
df8ed46cce
use const
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: blizzz <blizzz@arthur-schiwon.de>
2022-11-18 22:24:59 +01:00
blizzz
9bdf4c2254
use const
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: blizzz <blizzz@arthur-schiwon.de>
2022-11-18 22:24:59 +01:00
blizzz
a2bce2c6fc
use .json extentions
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: blizzz <blizzz@arthur-schiwon.de>
2022-11-18 22:24:59 +01:00
Arthur Schiwon
dbd573e1b0
do not store state in appconfig
- and use count over isset for better understanding

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-11-18 22:24:59 +01:00
Arthur Schiwon
a7ffdcd3dd
remove dashboard check, as fallback did not consider it either
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-11-18 22:24:59 +01:00
Arthur Schiwon
b725c777aa
optimize background image migration job
- separate in two stages: to prepare, and to actually migrate
- in step one, prepare a list of users to be migrated, and store it
  compressed as app config
  - gzcompress can be used, because we already require zlib
- upon the next calls (step two), slice off the first 5000 users
  and migrate them. Re-add job if necessary to repeat.
- downside is that an app config value will in the beginning use the
  RAM with any request, until it thins out. Examples: 2m UUIDs (75 MiB)
  result in ~40 MiB compressed data, while 0.2Mib for 10 000 UUIDs,
  0.4MiB for 20 000 and 4.1 MiB for 200 000. Acceptable.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-11-18 22:24:58 +01:00
Christopher Ng
a32ce79204 Remove completed comments
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-18 19:00:50 +00:00
Pytal
4767551509
Merge pull request #35253 from nextcloud/bugfix/noid/remove-warnings-loginpage 2022-11-18 10:27:12 -08:00
Simon L
b4ab2a9358
Merge pull request #35259 from nextcloud/bugfix/32354/fix-upload-actually-cancel-xhr
Also cancel XHR when cancelling uploads
2022-11-18 18:06:05 +01:00
Simon L
8e80f0433c
Merge pull request #35182 from nextcloud/enh/34654/try-go-generate-user-themed-icons
generate user themed icons
2022-11-18 16:02:51 +01:00
Vincent Petry
feda03b6ed
Also cancel XHR when cancelling uploads
Fixes issue when cancelling a long list of uploads.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-18 15:47:19 +01:00
Vincent Petry
09e55c717b
Merge pull request #35218 from nextcloud/storage-setup-providers
delay updating setup providers untill we register the mounts
2022-11-18 15:24:14 +01:00
Vincent Petry
4083a507e7
Fix warnings on login page
Check for app menu container before mounting.
Fix "isError" in LoginForm being a number when the throttleDelay is
zero. In fact, there is no need for existence check because both
undefined and null are not greater than a number.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-18 15:20:40 +01:00
Simon L
04b236e320 generate user themed icons
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Co-Authored-By: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2022-11-18 15:03:41 +01:00
Nextcloud bot
473647a467
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-18 02:13:28 +00:00
Pytal
fe18b5bfa4
Merge pull request #35170 from nextcloud/fix/fix-33745-Focus_and_active_state_needs_to_look_different_from_each_other 2022-11-17 11:08:04 -08:00
Christoph Wurst
183487a52e
Merge pull request #35186 from nextcloud/fix/oauth2-add-client-button-native-submit
Fix missing native submit type from OAuth client add button
2022-11-17 18:23:39 +01:00
julia.kirschenheuter
e056cd621d User status dialog a11y: make different focus and active state for OnlineStatusSelect and PredefinedStatus
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-11-17 17:08:24 +00:00
Simon L
beba3d04e4
Merge pull request #35227 from nextcloud/bugfix/35152/fix-toggle-grid-file-picker
Limit toggle grid view button scope
2022-11-17 17:43:48 +01:00
Vincent Petry
dceb562d9c
Merge pull request #35090 from nextcloud/enh/a11y-close-on-focusout
Close global search menu when keyboard focus leaves
2022-11-17 16:56:31 +01:00
Louis
ea24e2a323
Merge pull request #35225 from nextcloud/chore/package-lock-git-merge-strategy
Do not auto merge package-lock.json, but treat as text file
2022-11-17 16:53:07 +01:00
Côme Chilliet
6868cfbc2e
Merge pull request #35009 from nextcloud/fix/check-quota-on-copy
Check quota on file copy
2022-11-17 15:40:21 +01:00
Robin Appelman
841a6a084e
delay updating setup providers untill we register the mounts
otherwise the fallback to a full setup for a missing cached mount provider will lead to a race condition

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-17 15:21:57 +01:00
Côme Chilliet
feafa63afb Apply the same fix as on beforeCopy on beforeMove
Let’s be safe

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-17 13:22:50 +00:00
Robin Appelman
9150082eb7 fix dirname usage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-17 13:22:50 +00:00
Côme Chilliet
81d3a76d5d Fix psalm issues
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-17 13:22:50 +00:00
Côme Chilliet
5ed840ed23 Check quota on file copy
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-17 13:22:49 +00:00
Vincent Petry
9a948a6b39
Limit toggle grid view button scope
Limit the button action scope to the file picker dialog so that it
doesn't touch the file list present in the page.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-17 14:09:52 +01:00
Julius Härtl
301af07e2f
Merge pull request #35224 from nextcloud/chore/drop-deprecatd-node-sass 2022-11-17 13:13:00 +01:00
Côme Chilliet
55232de1ac
Merge pull request #35194 from nextcloud/automated/noid/master-update-psalm-baseline
[master] Update psalm-baseline.xml
2022-11-17 12:38:19 +01:00
Christoph Wurst
5ae8f6326c
Do not auto merge package-lock.json, but treat as text file
If package-lock is specified to be a binary file, it becomes impossible
to diff any changes. Since we only want to prevent git from merging
changes in the lockfile, we can be more specific and tell it that binary
handling is only required as merge strategy.

[skip ci]

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-17 12:32:03 +01:00
Christopher Ng
d7c4bdc46e
Close global search menu when focus leaves
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-17 11:51:41 +01:00
Christoph Wurst
ab8b6cff01
Fix missing native submit type from OAuth client add button
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-11-17 10:55:26 +01:00
Christoph Wurst
bb728aca31
Drop deprecated node-sass
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-17 10:44:38 +01:00
John Molakvoæ
f021172eab
Merge pull request #35203 from nextcloud/jpeg-80
Default Jpeg quality to 80
2022-11-17 08:41:34 +01:00
John Molakvoæ
d27a39271e
getAppValue expects string
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2022-11-17 08:03:05 +01:00
nextcloud-command
ca695385ca Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2022-11-17 04:11:54 +00:00
Nextcloud bot
d0f9eab647
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-17 02:14:28 +00:00
John Molakvoæ
3aa16d60d5
Merge pull request #35207 from nextcloud/fix/date-picker
Fix sharing expiration date handling and saving
2022-11-16 19:06:30 +01:00
John Molakvoæ
2b4ce7b95d
Fix date handling and saving
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-16 17:19:58 +01:00
Simon L
3d77e386cd
Merge pull request #34615 from nextcloud/enh/noid/logo-inverted
fix logo not correctly inverted
2022-11-16 15:54:06 +01:00
blizzz
e3822e1160
Merge pull request #35184 from nextcloud/s3-copy-dir-shadow
fix s3 directory copy
2022-11-16 15:41:19 +01:00
Robin Appelman
7e36002a93
Merge pull request #35210 from nextcloud/bugfix/noid/fix-settings-set-default-expiration-date
Fix settings for setting default expiration date
2022-11-16 15:38:02 +01:00
Julius Härtl
b62d3c4f39
Merge pull request #35192 from pserwylo/fix-performance-github-action
Fix github action "performance-8.0" when PR is from a fork.
2022-11-16 15:05:08 +01:00
Peter Serwylo
56aee55f9b Fix github action "performance-8.0" when PR is from a fork.
There is an assumption that the PR is from the same remote as
the base it is being merged into. This is fixed so that instead
of doing a `git fetch origin`, it now fetches from the `clone_url`
of the PR head.

Signed-off-by: Peter Serwylo <peter@serwylo.com>
2022-11-16 23:50:40 +11:00
Vincent Petry
2853e0887c
Fix settings for setting default expiration date
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-16 13:02:31 +01:00