Commit graph

60660 commits

Author SHA1 Message Date
Carl Schwan
3c060e54fa The storage is not static anymore
Don't call twice $cache->getId

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-14 14:17:04 +00:00
Carl Schwan
88774cfbba Optimize FileSystemTags workflow for groupfolder
In https://github.com/nextcloud/server/pull/28774 we disabled the
caching for the groupfolder application since it worked due to the fact
that in groupfolders, getFileIds could be called with the same $cacheId
and path for actually different groupfolders.

This revert this change and instead add the folderId from the
groupFolder to the cacheId. This solve the issue of the uniqueness of
the cacheId inside GroupFolder. Downside is that we introduce
groupfolder specific implementation inside the server repo.

The seconf optimization is to not consider paths starting with
__groupfolders in executeCheck. This is due to the fact that files in
the groupfolder application call two times executeCheck one time with
the url __groupfolder/<folderId>/<path> and the other time with <path>.
The first time will always return an empty systemTags array while the
second call will return the correct system tags.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-14 14:17:00 +00:00
Vincent Petry
3bdd8aeba0
Merge pull request #30662 from nextcloud/backport/30530/stable23
[stable23] Fix wrong unified search link to folder
2022-01-14 12:21:22 +01:00
blizzz
c36ae149a0
Merge pull request #30663 from nextcloud/backport/30568/stable23
[stable23] Fix primary key change in user_ldap migration
2022-01-14 12:04:06 +01:00
Julius Härtl
1938c41ace
Merge pull request #30659 from nextcloud/backport/29622/stable23 2022-01-14 10:41:46 +01:00
Carl Schwan
f4fcbaa8b9
Merge pull request #30643 from nextcloud/backport/30600/stable23
[stable23] Fix idn emails not working in shares
2022-01-14 10:08:19 +01:00
Côme Chilliet
101338063e Remove useless indexes with duplicated names on backup table
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-14 08:31:42 +00:00
Joas Schilling
9a9c8602e4 Update autoloader
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-14 08:31:41 +00:00
Côme Chilliet
e4235bdeba Fix user_ldap migration for long DNs support
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-14 08:31:40 +00:00
Côme Chilliet
66ca2925e7 Move duplicated code to a base class for group_mapping migrations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2022-01-14 08:31:38 +00:00
Côme Chilliet
03a570a500 Split dropTable and createTable in two migrations
It is not possible to drop and create the same table in one migration

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-14 08:31:38 +00:00
Côme Chilliet
d90e9088d0 Fix primary key change in user_ldap migration
Use a backup table to copy the data, drop table and recreate it with
 correct primary key, then copy the data back and drop the backup table.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-14 08:31:36 +00:00
John Molakvoæ
c124c27cdf Fix wrong unified search link to folder
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-01-14 08:22:29 +00:00
John Molakvoæ
05a13d3dc6
Implement multibucket shift for ObjectStore
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-01-14 08:31:38 +01:00
Carl Schwan
2b2d23ce21
Fix idn emails not working in shares
And add check before sending email that email address is valid

Fix #30595

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-13 17:10:43 +01:00
Vincent Petry
26b5949102
Merge pull request #30636 from nextcloud/backport/30620/stable23
[stable23] Properly abort uploads
2022-01-13 11:35:38 +01:00
Vincent Petry
ac9ad51b10 Properly hide progress bar after error
Whenever an error occurs, also hide the progress bar.

The logic was also adjusted to properly detect uploads that are pending
deletion, in which case the progress bar can already be hidden.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-13 08:29:29 +00:00
Vincent Petry
c78d542596 Properly abort uploads
Add a new approach for flagging an upload as aborted because we can't
rely on the browser fully cancelling the request as we now seem to
receive an error response from the server instead of a jQuery "abort"
message.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-13 08:29:28 +00:00
Vincent Petry
c2f3f37f69
Merge pull request #30627 from nextcloud/backport/30593/stable23
[stable23] Trigger "changeDirectory" event on URL change
2022-01-12 17:42:45 +01:00
MichaIng
0323ced93a
Merge pull request #30621 from nextcloud/backport/30358/stable23
[stable23] Reset job disabling timer on adding the job again
2022-01-12 16:01:56 +01:00
Vincent Petry
3340861c82 Trigger "changeDirectory" even on URL change
When using the browser back button or clicking on sections on the left
sidebar (like favorites), the "changeDirectory" jQuery event did not get
called, so apps like recommendations would not notice the directory
change.

This fixes the issue by also setting changeUrl to true when the file
list's directory got changed as a result from a URL change.

Added optional changedThroughUrl argument to make sure the event
recipient knows if the change was done through a URL change and make it
possible prevent a loop in the onDirectoryChange handler that actually
changes the URL when the origin was already from a URL change.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-12 13:46:13 +00:00
Carl Schwan
693771fd81
Merge pull request #30619 from nextcloud/backport/30609/stable23
[stable23] Fix RequestURL check for cli commands
2022-01-12 14:01:00 +01:00
Joas Schilling
b89e743976
Merge pull request #30611 from nextcloud/backport/30588/stable23
[stable23] Fix undefined/unset scope in account properties
2022-01-12 13:51:07 +01:00
Louis
141524a0e2
Merge pull request #30623 from nextcloud/backport/30485/stable23
[stable23] Set the file's mtime from the headers in bulk upload
2022-01-12 13:36:38 +01:00
Louis Chemineau
bb81f7afd8 Set the file's mtime from the headers in bulk upload
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-12 11:00:50 +00:00
Julius Härtl
d7cb3d0643 Reset job disabling timer on adding the job again
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-01-12 10:52:51 +00:00
blizzz
6d2b690881
Merge pull request #30602 from nextcloud/backport/30291/stable23
[stable23] Prevent loading images that would require too much memory.
2022-01-12 11:16:48 +01:00
Carl Schwan
1b8f9420a3 Fix RequestURL check for cli commands
Fix https://github.com/nextcloud/files_automatedtagging/issues/526

Fix https://github.com/nextcloud/groupfolders/issues/1855

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 09:07:31 +00:00
Joas Schilling
08037eac25 Fix test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-11 18:44:56 +00:00
Joas Schilling
8fde21460f Fix undefined/unset scope in account properties
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-11 18:44:52 +00:00
Joachim Bauch
cebac86ecd Prevent loading images that would require too much memory.
For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.

The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
2022-01-11 14:49:08 +00:00
MichaIng
c5ea067795
Merge pull request #30594 from nextcloud/backport/30533/stable23
[stable23] Avoid zero division in setup checks
2022-01-11 15:35:18 +01:00
Louis
4846f5d33e
Merge pull request #30592 from nextcloud/backport/30571/stable23
[stable23] fix: only use jquery once it is available
2022-01-11 14:18:28 +01:00
MichaIng
755381a4c2 Avoid zero division in setup checks
Fixes: https://github.com/nextcloud/server/issues/30532

Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-11 12:42:02 +00:00
Azul
08016ac02d fix: only use jquery once it is available
publicpage.js is loaded very early and cannot rely on jquery being loaded already.

Move the use of `$` into the `DomContentLoaded` handler.

Signed-off-by: Azul <azul@riseup.net>
2022-01-11 10:34:44 +00:00
Louis
ad5501a464
Merge pull request #30576 from nextcloud/backport/30565/stable23
[stable23] Fix fail when keys/files folder already exists
2022-01-11 10:44:10 +01:00
Vincent Petry
9eeaed0051 Fix fail when keys/files folder already exists
Fixes an issue with transfer ownership in move mode where the folder
"files_encryption/keys/files" already exists.

Instead of failing, its existence is checked before calling mkdir.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-01-11 08:20:41 +00:00
Vincent Petry
67fcbacd4f
Merge pull request #30580 from nextcloud/bugfix/noid/npm-ci-for-karma/stable23
[stable23] Use npm ci when running JS tests
2022-01-11 08:53:48 +01:00
Vincent Petry
035d73db11
Make chokidar happy with fsevents
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 18:00:24 +01:00
Vincent Petry
c948ceee60
Recompile JS
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 17:38:16 +01:00
Vincent Petry
4e4797b5b9
Fix JS tests after test lib updates
Prevent XHR during load by checking window.TESTING.
Adjust some expected values.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 17:30:32 +01:00
Vincent Petry
60e364018f
Update node deps for JS tests
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 17:28:16 +01:00
Vincent Petry
7dcbcd21e1
Use npm ci when running JS tests
This makes sure that the pinned versions are selected correctly.
Fixes the colors.js incident.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 17:26:23 +01:00
John Molakvoæ
ed1fcf1982
Merge pull request #30557 from nextcloud/backport/30468/stable23 2022-01-10 08:35:01 +01:00
Carl Schwan
b054321fc0 Handle LocalServerException when scanning external shares
When remoteIsOwnCloud trows LocalServerException, the storage is
unavailable and instead of crashing the scanner, ignore the specific
storage.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-09 17:40:39 +00:00
blizzz
99b400c733
Merge pull request #30528 from nextcloud/backport/30511/stable23
[stable23]  update CRL after revocation of sharerenamer.crt
2022-01-08 00:55:12 +01:00
Pytal
cc9a2e0558
Merge pull request #30525 from nextcloud/backport/30491/stable23 2022-01-07 11:21:43 -08:00
John Molakvoæ
7d8be4d044
Merge pull request #30518 from nextcloud/release/23.0.1 2022-01-07 14:57:27 +01:00
Vitor Mattos
e2d9fb9d01 Update crl
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-07 11:25:47 +00:00
Christopher Ng
c699f1bec2 Fix email verification
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-01-07 10:52:36 +00:00