Commit graph

29906 commits

Author SHA1 Message Date
Christoph Wurst
2e252476d8
Merge pull request #41046 from nextcloud/fix/recently-contacted-duplicates
Fix: duplicating contacts with the Recently contacted feature
2023-10-24 20:45:20 +02:00
Louis
c5d82409b4
Merge pull request #41062 from nextcloud/artonge/fix/return_fals_if_touch_fails
Return correct status if touch failed
2023-10-24 18:08:24 +02:00
Robin Appelman
efe68d012c
Merge pull request #39044 from nextcloud/more-empty-mount-checking
Fix root mounts not being setup in some cases
2023-10-24 16:54:05 +02:00
Julia Kirschenheuter
970ac3d7eb
Merge pull request #41068 from nextcloud/fix/37092/user-status--html-validation
fix(user_status): separate user menu and dashboard status layout for HTML validation
2023-10-24 15:35:33 +02:00
Ferdinand Thiessen
6753aaf33e
Merge pull request #41035 from nextcloud/fix/37092/apps-list--html-validation
fix(settings): apps list html validation and loading icon
2023-10-24 14:06:03 +02:00
hamza221
6ab76917c9 Fix: duplicating contacts with the Recently contacted feature
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
2023-10-24 13:03:59 +02:00
Joas Schilling
7a55ea7823
Merge pull request #41061 from nextcloud/bugfix/noid/dont-use-indirect-dependency
fix(3rdparty): Don't use indirect dependency "Safe/" for functions
2023-10-24 12:12:36 +02:00
Grigorii K. Shartsev
230830b1e6 fix(settings): apps list loading classes
- fix setting loading classes
- also removes invalid HTML attributes, there is no such props in `NcContent`

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-24 11:07:04 +02:00
Grigorii K. Shartsev
668e35f155 fix(settings): apps list html validation
- Replace invalid `width="100%"` attribute
- Add empty required `alt`

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-24 11:07:04 +02:00
Grigorii K. Shartsev
c834d98d34 fix(user_status): separate user menu and dashboard status layout
- Remove href="#" from a button for HTML validation
- Use @nextcloud/vue NcButton instead of custom button in Dashboard

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-24 10:57:17 +02:00
Pytal
450985fc74
Merge pull request #40938 from nextcloud/fix/a11y/change-scope-actions
fix(settings): Account property scope actions
2023-10-23 18:11:25 -07:00
Nextcloud bot
d772537d90
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-10-24 00:25:42 +00:00
Christopher Ng
f0bb5e7e76 fix(settings): Styles for scope button
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-23 15:53:30 -07:00
Christopher Ng
a9fdc52f69 fix(settings): Name for scope button
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-23 15:53:30 -07:00
Christopher Ng
18a2391cab fix(settings): Remove aria-label on scope actions
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-23 15:53:30 -07:00
Christopher Ng
3b097f0658 fix(tests): Update dav snapshot
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-23 15:18:09 -07:00
Christopher Ng
590daccca3 fix: Share select search globally icon
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-10-23 15:14:49 -07:00
Julius Härtl
45d7612423
Merge pull request #40482 from nextcloud/fix/workflowengine_fileaccess 2023-10-23 23:25:18 +02:00
Pytal
8a1546c703
Merge pull request #41064 from nextcloud/fix/40705-_increase_contrast_on_Device_and_Last_activity
Remove opacity on table header
2023-10-23 11:53:35 -07:00
Jonas
7441ce2b11
enh(IMountManager): Add method to get MountPoint from CachedMountInfo
Signed-off-by: Jonas <jonas@freesources.org>
2023-10-23 20:50:24 +02:00
Jonas
9193d8be40
fix(isLegitimatedForUserId): Setup mountpoints to check file access
This fixes workflows on groupfolders, as it will consider access to
files in groupfolders.

It also fixes false positives where access to files was limited by other
means not taken into account before, e.g. access control.

For postDelete events, check for permissions of the parent folder
instead, as the file itself no longer exists.

Fixes: nextcloud/flow_notifications#71

Signed-off-by: Jonas <jonas@freesources.org>
2023-10-23 20:47:16 +02:00
Julius Härtl
f88c34b604
Merge pull request #40495 from nextcloud/fix/master-name-in-share-cache 2023-10-23 19:29:17 +02:00
Simon L
8bd1294550
Merge pull request #41063 from nextcloud/fix/37092/dashboard-html-validation 2023-10-23 18:43:01 +02:00
Côme Chilliet
5245d2000a
Merge pull request #41017 from nextcloud/fix/move-token-iprovider-to-ocp
Move IToken and IProvider::getToken to OCP
2023-10-23 18:01:52 +02:00
Ferdinand Thiessen
d43c66e96a
Merge pull request #41034 from nextcloud/fix/37092/users--html-validation
fix(settings): users page html validation
2023-10-23 17:16:43 +02:00
julia.kirschenheuter
521e66edc0 Remove opacity on table header
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-10-23 16:30:50 +02:00
Grigorii K. Shartsev
3b017ec3ff fix(dashboard): use span instead of div for icon to html
- div is not valid in h2
- div is not valid in label

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-23 16:20:47 +02:00
Louis Chemineau
e66e8bad1a
Return correct status if touch failed
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-10-23 15:26:43 +02:00
Joas Schilling
3a265cee30
fix(3rdparty): Don't use indirect dependency "Safe/" for functions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-23 15:25:14 +02:00
Côme Chilliet
1bdf952fde
Make sure that OC interfaces returns OC interfaces for backward compatibility
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-23 11:08:23 +02:00
jld3103
d019392645
fix(provisioning_api): Fix quota fields in OpenAPI
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-10-23 10:33:37 +02:00
Côme Chilliet
61143644a4
Merge pull request #40933 from nextcloud/check-datemax-enforcement-pubshare
Check expiry enforcement for all share types
2023-10-23 09:32:27 +02:00
Nextcloud bot
1de151abd9
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-10-23 00:26:23 +00:00
fenn-cs
8dfcf2e02a Do not treat isDefaultExpireDateEnforced as fallback
`isDefaultExpireDateEnforced` and its corresponding `defaultExpirationDate`
is currently treated as the enforcement fallback when share type enforcements are not
set.

However, `isDefaultExpireDateEnforced` and `defaultExpirationDate` are actually more like
`isDefaultPublicExpireDateEnforced` and `defaultPublicExpirationDate` and therefore only applies
to public shares.

It might be ideal to rename this variables all the way from the backend config to the way we use
them in the frontend code.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-10-22 16:47:32 +00:00
fenn-cs
46308e96f3 Fix has expiration date logic
Current expiration date errorneously assumes that `defaultExpirationDate`
applies to all kinds of shares. But it only really applies to public shares despite
its name.

This commit, fixes that by paring expiration dates with the correct share types during
new share initialization and simplifying the `hasExpirationDate` (check) property.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-10-22 15:47:45 +01:00
fenn-cs
92417cd594 Check expiry enforcement for all share types
We should check that a maximum expiry date has been enforced for
all shares and NOT JUST FOR internal shares before enforcing a UI max date,
like in commit 9757e680e2

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-10-22 15:47:43 +01:00
John Molakvoæ
4b70f19837
Merge pull request #41024 from nextcloud/fix/follow-up-app-order 2023-10-22 12:58:57 +02:00
Nextcloud bot
b76ecf3781
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-10-22 00:28:37 +00:00
Varun Patil
4d578f37e6 fix(files): correct item height
1. grid: typo? The icon size is 160 - 44 + (44 / 2) = 138px
2. non-grid: border is already included in height because the tr
   is a border-box (made this explicit to be safe)

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-10-21 22:42:06 +00:00
Grigorii K. Shartsev
d33ce8a8d5 fix(settings): label user quota progress with aria-labelledby
Labeling with `<label>` doesn't work in some screen readers.
`<label>` also doesn't work as a clickable link here.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-21 04:16:45 +02:00
Ferdinand Thiessen
615a6846da
feat(theming): Allow to reset the user defined app order to the default value
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-21 03:52:25 +02:00
Ferdinand Thiessen
9697df1ea5
fix(theming): App order settings - ensure the focus is kept on button
When pressing a button for changing the app order that button should keep the focus after reordering the list.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-10-21 03:52:18 +02:00
Grigorii K. Shartsev
5249c3376e fix(settings): users page html validation
- Remove non-existing `button-class` from `NcAppNavigationNew`
- Type: use `input-id` instead of `id` on `NcSelect` to be labeled
- Encode uniqueId with user's ID, because user.id may contain space

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-21 03:49:01 +02:00
Nextcloud bot
5c2610af7d
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-10-21 00:27:09 +00:00
Grigorii K. Shartsev
641d52dae7
fix(settings): remove unused savePrimaryEmailScope on Personal Settings page
If was replaced with universal `savePrimaryAccountPropertyScope`.
`<HeaderBar>` has no `handle-scope-change` prop.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-20 20:31:57 +02:00
Grigorii K. Shartsev
d4c37d5c4c
fix(settings): remove placeholder from select
There is no placeholder attribute on select element

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-20 20:31:57 +02:00
Grigorii K. Shartsev
73e675d145
fix(settings): typo in avatar prop
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-20 20:31:57 +02:00
Grigorii K. Shartsev
f214a7e332
fix(settings): remove invalid avatar prop
There was a typo, it must have been disable-menu, not disableD-menu.
But it is not required, because the menu is disabled for the current user anyway.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-20 20:31:57 +02:00
Grigorii K. Shartsev
9154367761
fix(settings): fix ids and aria-labels in personal emails
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-20 20:31:56 +02:00
Grigorii K. Shartsev
4a85113cac
fix(settings): remove empty aria-describedby
Empty string `''` is still rendered and is not a valid ID.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-20 20:31:56 +02:00