upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

fix(settings): remove unused savePrimaryEmailScope on Personal Settings page

Browse source 
If was replaced with universal `savePrimaryAccountPropertyScope`.
`<HeaderBar>` has no `handle-scope-change` prop.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
This commit is contained in:
Grigorii K. Shartsev 2023-10-19 16:42:36 +02:00 committed by Ferdinand Thiessen
parent d4c37d5c4c
commit 641d52dae7
No known key found for this signature in database
GPG key ID: 45FAE7268762B400
2 changed files with 1 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/settings/src/components/PersonalInfo/EmailSection/EmailSection.vue
View file

@ -24,7 +24,6 @@
<section>
<HeaderBar :input-id="inputId"
:readable="primaryEmail.readable"
:handle-scope-change="savePrimaryEmailScope"
:is-editable="true"
:is-multi-value-supported="true"
:is-valid-section="isValidSection"
@ -69,7 +68,7 @@ import Email from './Email.vue'
import HeaderBar from '../shared/HeaderBar.vue'
import { ACCOUNT_PROPERTY_READABLE_ENUM, DEFAULT_ADDITIONAL_EMAIL_SCOPE, NAME_READABLE_ENUM } from '../../../constants/AccountPropertyConstants.js'
import { savePrimaryEmail, savePrimaryEmailScope, removeAdditionalEmail } from '../../../service/PersonalInfo/EmailService.js'
import { savePrimaryEmail, removeAdditionalEmail } from '../../../service/PersonalInfo/EmailService.js'
import { validateEmail } from '../../../utils/validate.js'
import { handleError } from '../../../utils/handlers.js'
@ -90,7 +89,6 @@ export default {
additionalEmails: additionalEmails.map(properties => ({ ...properties, key: this.generateUniqueKey() })),
displayNameChangeSupported,
primaryEmail: { ...primaryEmail, readable: NAME_READABLE_ENUM[primaryEmail.name] },
savePrimaryEmailScope,
notificationEmail,
}
},

20
apps/settings/src/service/PersonalInfo/EmailService.js
View file

@ -131,26 +131,6 @@ export const updateAdditionalEmail = async (prevEmail, newEmail) => {
return res.data
}
/**
* Save the federation scope for the primary email of the user
*
* @param {string} scope the federation scope
* @return {object}
*/
export const savePrimaryEmailScope = async (scope) => {
const userId = getCurrentUser().uid
const url = generateOcsUrl('cloud/users/{userId}', { userId })
await confirmPassword()
const res = await axios.put(url, {
key: `${ACCOUNT_PROPERTY_ENUM.EMAIL}${SCOPE_SUFFIX}`,
value: scope,
})
return res.data
}
/**
* Save the federation scope for the additional email of the user
*