Côme Chilliet
ab6afe0111
fix: Fix new psalm errors from update
...
Not sure about the SimpleContainer modification, let’s see what CI says
about that.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-08 11:29:09 +02:00
Daniel
c0d21b4443
Merge pull request #44511 from nextcloud/perf/noid/skip-tree-lookup-for-non-calendar-requests
...
perf(dav): skip non-calendar requests in webcal caching plugin
2024-04-03 07:44:33 +02:00
Côme Chilliet
9aa7225ed3
Merge pull request #44332 from nextcloud/fix/fix-chunkupload-quota-check
...
fix(dav): Fix quota check for chunk upload
2024-04-02 17:44:21 +02:00
Côme Chilliet
81319e78bf
chore: Improve phpdoc typing to silence psalm errors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +02:00
Côme Chilliet
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +02:00
Côme Chilliet
516fb702c9
fix(dav): Fix quota check for chunk upload
...
Do not ignore OC-Total-Length when Content-Length and
X-Expected-Entity-Length are missing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:13 +02:00
Daniel Kesselberg
4bdb473aae
perf(dav): skip non-calendar requests in webcal caching plugin
...
The webcal caching plugin is active when the X-NC-CalDAV-Webcal-Caching header is there.
findPrincipalByUrl sends a request for /remote.php/dav/principals/users/admin/ using the caldavService which sets the header by default.[^1]
As X-NC-CalDAV-Webcal-Caching only impacts calendar requests, we can skip non-calendar requests.
[^1]: b3670f1805/src/services/caldavService.js (L43)
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-03-27 20:04:23 +01:00
Robert C. Schaller
fa6e6131ee
fix(dav): wrong comparison method between two events
...
Old comparison implementation compares each element of the array against each other with no respect for the associated array label, which leads to wrongful removals because one value is accidentally present in a completely different label. New comparison works 'by-label' individually.
Partly fixes #41084 because changes between 'SEQUENCE' not present, 'SEQUENCE:0' and 'SEQUENCE:1' were not detected in the old implementation and thus no email update sent.
Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
Signed-off-by: Robert C. Schaller <gtbc_robert.schaller@rsxc.de>
2024-03-25 13:18:58 +01:00
Christoph Wurst
3dea99f42b
fix(dav): Add retention time to sync token cleanup
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-21 18:37:21 +01:00
Anna
bdd4ac2c17
Merge pull request #44360 from nextcloud/fix/add-exdate-exrule-to-confidential-object
...
fix(caldav): add EXDATE and EXRULE to confidential object
2024-03-21 14:34:08 +01:00
Hamza
007b54afed
Merge pull request #44376 from nextcloud/fix/dav/acls-shared-addressbook
...
fix(dav): ACLs for shared addressbooks
2024-03-21 14:33:43 +01:00
Christoph Wurst
b6e1685683
fix(dav): ACLs for shared addressbooks
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-21 11:50:35 +01:00
Anna Larch
a96f8f7fee
fix(caldav): add EXDATE and EXRULE to confidential object
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-03-21 10:01:33 +01:00
Côme Chilliet
c1b451ea86
chore: Break closure call on two lines to make it readable
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 16:01:25 +01:00
Côme Chilliet
fa8efd5df8
fix(systemtags): Forbid tagging of readonly files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 16:01:12 +01:00
Côme Chilliet
443b26761d
fix: Migrate WebDAV endpoint check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-14 16:20:17 +01:00
Christoph Wurst
f40f962c2e
fix(dav): Add occ command to fix missing caldav sync tokens
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-12 12:44:00 +01:00
Maxence Lange
f4beb95cdc
Merge pull request #42707 from nextcloud/enh/noid/store-file-etag-at-metadata-creation
...
enh(metadata): store current file etag
2024-03-11 12:46:29 -01:00
Julius Härtl
ca453f5b84
fix: Use proper path when trying to check if a file needs to get copied
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-08 10:02:45 +01:00
Maxence Lange
3fa5e598a8
feat(metadata): get deprecated status using file etag
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-07 12:49:06 -01:00
John Molakvoæ
65a05834cf
Merge pull request #43903 from nextcloud/fix/dav/dirty-address-book-update
...
fix(dav): Fix atomic addressbook update
2024-03-05 22:00:08 +01:00
Richard Steinmetz
00e0fa48a0
Merge pull request #43904 from nextcloud/fix/dav/dirty-caldav-updates
...
fix(dav): Fix atomic calendar/subscription updates
2024-03-05 21:44:40 +01:00
Robin Appelman
e7a7b4a401
perf: switch places that always use the first getById result to getFirstNodeById
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-04 13:57:31 +01:00
Christoph Wurst
a2fcf50f43
fix(dav): Fix atomic calendar/subscription updates
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-29 09:42:51 +01:00
Christoph Wurst
09031211da
fix(dav): Fix atomic addressbook update
...
Sabre executes the proppatch callback *after* calling updateAddressbook
and not synchronously. That means the code inside the callback was run
outside a database transaction. This moves the atomic helper into the
callback to create the expected transaction span.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-29 09:27:49 +01:00
Richard Steinmetz
53ef6c5f71
feat(dav): update a principal's schedule-default-calendar-URL
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-02-28 14:51:10 +01:00
Louis Chemineau
5137757053
fix(dav): Init ViewOnlyPlugin after auth
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-27 09:22:29 +01:00
John Molakvoæ
9eece36235
Merge pull request #39553 from zero0cool0/fix/caldavbackend_getChangesForCalendar
2024-02-23 21:35:43 +01:00
John Molakvoæ
54e6ad6e63
Merge pull request #39750 from nextcloud/Jerome-Herbinet-to-dos-wording-change
2024-02-23 21:30:06 +01:00
John Molakvoæ
b91fb12258
Merge pull request #39214 from shdehnavi/replace_substr_calls_in_dav_app
2024-02-23 21:29:15 +01:00
John Molakvoæ
3cc50790bc
Merge pull request #32466 from nextcloud/fix/skip-dav-migrator
2024-02-23 21:28:53 +01:00
John Molakvoæ
db9fd9439e
Merge pull request #42459 from nextcloud/fix/dav/fallback-realm
2024-02-23 19:42:41 +01:00
Jérôme Herbinet
678c003546
"Taks" to fit calendar wording
...
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2024-02-23 17:05:56 +01:00
Patrick Fischer
0f16153e4a
Bug fix: Select the correct table based on CALENDAR_TYPE_CALENDAR
...
Signed-off-by: Patrick Fischer <mail@patrickfischer.ch>
2024-02-23 16:18:01 +01:00
Hamid Dehnavi
7bf31df0bc
Refactors "substr" calls to improve code readability
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2024-02-23 15:54:10 +01:00
Christopher Ng
a770fd8236
Skip instead of throwing on invalid address book migration
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-02-23 15:24:46 +01:00
Christopher Ng
07bf129809
Skip instead of throwing on invalid calendar migration
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-02-23 15:22:31 +01:00
Christoph Wurst
f1c79cd264
Merge pull request #43732 from nextcloud/fix/dav/rate-limit-create-calendar
...
fix(dav): Rate limit calendar/subscription creation
2024-02-23 13:54:17 +01:00
Richard Steinmetz
3814ef6d06
Merge pull request #43340 from nextcloud/fix/43118/remove-redundant-index
...
fix(db): remove redundant index in cards
2024-02-23 10:44:49 +01:00
Christoph Wurst
dc7f2baf26
fix(dav): Rate limit calendar/subscription creation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-23 08:52:59 +01:00
Louis Chemineau
8e95d0f3ae
Check share attributes when downloading versions
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-02-21 15:06:01 +01:00
Richard Steinmetz
8cce736dcb
perf: skip request without read permission
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-02-19 20:44:17 +01:00
Johannes Merkel
631f2b48ea
fix(db): remove redundant index in cards
...
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-02-18 20:51:43 +01:00
Anna Larch
dce69154ba
enh(sharing): enable unsharing for sharees for DAV shares (addressbooks and calendars)
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-02-15 18:01:12 +01:00
MichaIng
91127edcc8
fix(dav): fallback realm for HTTP authentication
...
By default, the name of the Nextcloud instance is an empty string, until changed by the admin. This leads to an empty realm sent with the WWW-Authenticate header, while the realm is mandatory for Basic HTTP authentication. Some clients have issues with an empty realm, e.g. Thunderbird cannot store passwords in this case.
This commit applies "Nextcloud" as fallback for the realm, in case the name of the Nextcloud instance is not set.
Solves: https://help.nextcloud.com/t/thunderbird-dont-save-caldav-password-because-of-missing-httprealm-or-formsubmiturl/93233
Signed-off-by: MichaIng <micha@dietpi.com>
2024-02-14 16:49:39 +01:00
John Molakvoæ
524ed97d62
fix: replace Account name by Login
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +01:00
Côme Chilliet
303e2febc7
Merge pull request #43387 from nextcloud/fix/migrate-away-from-ilogger-in-jobs
2024-02-08 18:27:44 +01:00
Louis Chemineau
898df41de9
Revert "Merge branch 'master' of github.com:nextcloud/server"
...
This reverts commit d9d60238c7 , reversing
changes made to ba3fdb0cdc .
2024-02-08 15:31:19 +01:00
Côme Chilliet
166773879b
fix!: Migrate jobs away from deprecated interfaces
...
BREAKING CHANGE: Removed ILogFactory::getCustomLogger deprecated method
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +01:00
John Molakvoæ
6cf4fe19a0
fix(files): add mount root property and adjust delete wording
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-06 17:43:35 +01:00