upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-28 17:48:40 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 29

fix(dav): fallback realm for HTTP authentication

Browse source 
By default, the name of the Nextcloud instance is an empty string, until changed by the admin. This leads to an empty realm sent with the WWW-Authenticate header, while the realm is mandatory for Basic HTTP authentication. Some clients have issues with an empty realm, e.g. Thunderbird cannot store passwords in this case.

This commit applies "Nextcloud" as fallback for the realm, in case the name of the Nextcloud instance is not set.

Solves: https://help.nextcloud.com/t/thunderbird-dont-save-caldav-password-because-of-missing-httprealm-or-formsubmiturl/93233

Signed-off-by: MichaIng <micha@dietpi.com>
This commit is contained in:
MichaIng 2023-12-22 04:10:07 +01:00
parent de4e48370f
commit 91127edcc8
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/dav/lib/Connector/LegacyPublicAuth.php
View file

@ -63,7 +63,7 @@ class LegacyPublicAuth extends AbstractBasic {
// setup realm
$defaults = new \OCP\Defaults();
$this->realm = $defaults->getName();
$this->realm = $defaults->getName() ?: 'Nextcloud';
}
/**

2
apps/dav/lib/Connector/Sabre/Auth.php
View file

@ -75,7 +75,7 @@ class Auth extends AbstractBasic {
// setup realm
$defaults = new \OCP\Defaults();
$this->realm = $defaults->getName();
$this->realm = $defaults->getName() ?: 'Nextcloud';
}
/**

2
apps/dav/lib/Connector/Sabre/BearerAuth.php
View file

@ -47,7 +47,7 @@ class BearerAuth extends AbstractBearer {
// setup realm
$defaults = new \OCP\Defaults();
$this->realm = $defaults->getName();
$this->realm = $defaults->getName() ?: 'Nextcloud';
}
private function setupUserFs($userId) {