upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-11 09:42:09 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 40
69654 commits 1029 branches 1221 tags 8.3 GiB
Commit graph

6767 commits

Author SHA1 Message Date
Anna Larch
5d4efb4d5f
Do not set up filesystem on every call 
Also remove old Oc_FileChunking logis that produced GC- collectable chunks

Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-02-17 19:18:37 +01:00
Julius Härtl
47bc024885
Revert the token scope to not end up with storing the user used in the session 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-02-17 10:18:18 +01:00
Julius Härtl
90d2cb09b1
Merge pull request #36396 from nextcloud/fix/cors 2023-02-17 09:42:08 +01:00
Ferdinand Thiessen
f655f83c84 fix(CORS): CORS should only be bypassed on PublicPage if not logged in to prevent CSRF attack vectors 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-16 22:55:18 +01:00
Louis
98b998a2de
Merge pull request #36735 from nextcloud/fix/32635/fix-vcf-contacts 
fix the contacts-menu vcf-contact avatars
 2023-02-16 14:01:19 +01:00
Simon L
b38d2daede fix the contacts-menu vcf-contact avatars 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-02-15 23:16:43 +01:00
MichaIng
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow" 
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240

Signed-off-by: MichaIng <micha@dietpi.com>
 2023-02-15 20:16:51 +01:00
Julius Härtl
a705132c8d
Merge pull request #36656 from nextcloud/route-instrumentation 2023-02-14 10:12:19 +01:00
Robin Appelman
b911da3e1e
DI for Router 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-13 22:51:14 +01:00
Robin Appelman
936f634069
Merge pull request #36643 from nextcloud/fs-setup-instrimuntion 
more filesystem setup performance instrumentation
 2023-02-13 14:37:57 +01:00
Robin Appelman
91d5f6a826 more filesystem setup performance instrumentation 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-10 11:11:13 +01:00
Christopher Ng
c77998209f Port user menu to Vue 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-02-09 17:54:59 -08:00
Joas Schilling
a81d8ecef5
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-09 16:15:47 +01:00
Julius Härtl
08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id 2023-02-08 20:04:57 +01:00
Joas Schilling
dcfc96f0cc
Merge pull request #36417 from nextcloud/fix/psr-container 
Make the container fully fulfill PSR container interface
 2023-02-07 20:38:19 +01:00
Robin Appelman
9f3dbb699a fix tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-07 15:50:10 +01:00
Côme Chilliet
892e6c642a
Skip buggy tests for 32bits CI 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:33 +01:00
Côme Chilliet
77c8c9c805
Improve error output on failed Router test 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:31 +01:00
Côme Chilliet
94ecae4ade
Add helper to cast to int|float, fix MemoryInfo on 32bits 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Côme Chilliet
0f8c34cdc6
Fix filesize return type error in ViewTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Côme Chilliet
5cfab229db
Improve test failure output for RouterTest.php 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Côme Chilliet
2d8e696c24
Add apcu and ffmpeg to have less skipped tests 
Also exclude test groups which rely on a service

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:28 +01:00
Joas Schilling
59578817f5
Merge pull request #36489 from nextcloud/bugfix/noid/brute-force-protection-password-reset 
Add bruteforce protection to password reset page
 2023-02-06 22:12:25 +01:00
Ferdinand Thiessen
ba8a50c059 fix: Throw NotFoundExceptionInterface to fulfill PSR container interface if class not found 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-06 14:16:35 +01:00
Joas Schilling
875e6cf7e6
fix(CI): Adjust expected result 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-06 11:26:38 +01:00
Christoph Wurst
88d116ba84
fix(client-login-flow): Handle missing stateToken gracefully 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-02-06 09:42:15 +01:00
Joas Schilling
47880b143d
Remove failing test that works with mocks only anyway 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-02 18:06:31 +01:00
Côme Chilliet
dde5c46a3e
Migrate to Symfony Mailer 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-02 10:30:06 +01:00
Maxence Lange
1a655e88d9 use php8.0 images 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-01-31 15:44:12 -01:00
Julius Härtl
c246edece6
tests(oci): Test where statement on longtext column 
Signed-off-by: Julius Härtl <jus@bitgrid.net>

test: try with just passing the type to eq which should also cast

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-01-31 11:57:54 +01:00
Louis
2f3007205d
Merge pull request #35160 from nextcloud/artonge/feat/version_naming_backend 
Allow to name a version
 2023-01-30 10:40:49 +01:00
Joas Schilling
959e2aaa17
fix(tests): Fix method name in unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-30 09:12:50 +01:00
Christoph Wurst
20e00cdf17
feat(app-framework): Add UseSession attribute to replace annotation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-27 09:40:35 +01:00
Christoph Wurst
8d9af3e262
feat(app-framework): Add support for global middlewares 
This allows apps to register middlewares that always register, not just
for the app's own requests

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-26 11:54:28 +01:00
Louis Chemineau
d8b479752d Fix hookconnector tests 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-01-26 10:12:23 +00:00
Christoph Wurst
907ff68bfc
perf(app-framework): Make the app middleware registration lazy 
Before this patch, app middlewares were registered on the dispatcher for
every app loaded in a Nextcloud process. With the patch, only
middlewares belonging to the same app of a dispatcher instance are
loaded.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-25 09:27:24 +01:00
Christopher Ng
0236c9e8cd Port files sharing selector 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-01-24 17:40:17 -08:00
Côme Chilliet
003cc2b45a
Fix tests failures (number of calls differed with last rebase) 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-24 09:38:20 +01:00
Carl Schwan
a23cd7b961
Fix a bunch of deprecation in the phpunit for core 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2023-01-24 09:34:09 +01:00
Joas Schilling
1c099c7f17
Fix broken user:setting command unit test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-23 07:01:22 +01:00
Côme Chilliet
f5c361cf44
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
Joas Schilling
89dbc629ff
Fix integrity check 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-20 11:22:11 +01:00
Côme Chilliet
de68fc6347
Update test file for mimetypes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:11 +01:00
Côme Chilliet
b22b6431d2
Fix gzip mimetype mapping 
PHP now detects it as application/gzip and not application/x-gzip anymore

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:11 +01:00
Côme Chilliet
7ebbb6b2ca
Remove workarounds specific to 7.4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:08 +01:00
Joas Schilling
1e2441ff6b
Disable unreliable acceptance tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-19 09:21:33 +01:00
Christoph Wurst
20fcfb5739
feat(app framework)!: Inject services into controller methods 
Usually Nextcloud DI goes through constructor injection. This has the
implication that each instance of a class builds the full DI tree. That
is the injected services, their services, etc. Occasionally there is a
service that is only needed for one controller method. Then the DI tree
is build regardless if used or not.

If services are injected into the method, we only build the DI tree if
that method gets executed.

This is also how Laravel allows injection.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-18 14:00:38 +01:00
Christoph Wurst
f22101d421
Fix login loop if login CSRF fails and user is not logged in 
If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-18 09:39:17 +01:00
blizzz
dbfe7b1816
Merge pull request #36073 from nextcloud/fix/fix-background-job-list 
Use a Generator for job list to fix background-job:list command
 2023-01-16 11:10:10 +01:00
Christopher Ng
f6aa5224c4 Focus trap contacts menu with NcHeaderMenu port 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-01-13 23:19:28 +00:00
Joas Schilling
238e9cf3a8
feat(CI): Enforce colored output for acceptance tests on drone CI 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-13 11:31:13 +01:00
Côme Chilliet
d74044f634
Fix API breakage by using a new method instead 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-12 17:18:59 +01:00
Côme Chilliet
75fca38e66
Fix BackgroundJob list tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-12 11:40:18 +01:00
Simon L
7271ec7acf spaces are allowed in userids 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-01-10 13:25:27 +01:00
Vincent Petry
42d9e087fb
Remove unused legacy ajax/list.php in files app 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2023-01-09 15:18:37 +01:00
Julius Härtl
18164ae516
Merge pull request #33898 from nextcloud/fix/authtoken-password-update 
PublickKeyTokenProvider: Fix password update routine with password hash
 2023-01-05 08:01:47 +01:00
Joas Schilling
97e33c2bd4
Fix unit tests of the ActionProviderStore 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-04 16:17:43 +01:00
Joas Schilling
8eca26012f
Show local time in avatar menu 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-04 11:09:58 +01:00
Marcel Klehr
adfe367106
PublickKeyTokenProvider: Fix password update routine with password hash 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-01-04 08:30:53 +01:00
Bennet Becker
4dc0957164
refactor AutoSubmittedValue to Headers\AutoSubmitted and adding 
header name to constants

Signed-off-by: Bennet Becker <dev@bennet.cc>
 2023-01-03 15:15:35 +01:00
Bennet Becker
411467af57
fix static-analysis error and formatting code 
Signed-off-by: Bennet Becker <dev@bennet.cc>
 2022-12-23 21:48:52 +01:00
Bennet Becker
c1c6d215c7
fix getAutoSubmitted return type and adding unit tests 
Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
 2022-12-23 19:26:49 +01:00
Simon L
bfb3b2af9f increase preview_max_memory and make it easier to debug 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2022-12-22 09:52:46 +01:00
Daniel Kesselberg
e2285acd04 Update behat and friends 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2022-12-21 15:27:59 +00:00
Stanimir Bozhilov
7dcd6eb561
Merge branch 'master' into add-scim-json-support 
Signed-off-by: Stanimir Bozhilov <stanimir.bozhilov.1998@gmail.com>
 2022-12-19 09:07:38 +01:00
Vincent Petry
ae6fe874ed
Merge pull request #35780 from nextcloud/fix/http-dispatcher-double-parameter-cast 
Fix missing cast of double controller parameters
 2022-12-16 16:18:35 +01:00
Vincent Petry
6737deabbf
Merge pull request #35784 from nextcloud/chore/strict-login-controller 
Make the LoginController strict
 2022-12-16 16:16:31 +01:00
Christoph Wurst
138deec333
chore: Make the LoginController strict 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-12-15 10:52:28 +01:00
Christoph Wurst
b6dd1a1d7b
fix(app framework): Fix missing cast of double controller parameters 
``settype`` allows 'double' as alias of 'float'.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-12-15 09:33:52 +01:00
Artur Neumann
81f2857f34
check if params given to API are really an array 
Signed-off-by: Artur Neumann <artur@jankaritech.com>
 2022-12-15 13:45:22 +05:45
Christopher Ng
fb2fb0d2d5 Revert "Copy to clipboard with button instead of link" 
This reverts commit 4ffc022c8b.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2022-12-14 00:57:57 +00:00
Joas Schilling
2f7a1fca5f
Merge pull request #34477 from nextcloud/bugfix/noid/sharee-recommendations-show-group-id 
Show group name instead of group id as recommendation
 2022-12-09 22:39:28 +01:00
Julius Härtl
4bcaeb6c2c
Drop 3rdparty root since it is unused and adjust tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-12-07 23:55:32 +01:00
Julius Härtl
306d7829b5
Cache available languages locally 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-12-07 22:32:06 +01:00
Julius Härtl
87e638b1f8
Merge pull request #35649 from nextcloud/bugfix/object-storage-master-key-enc 
Update the unencrypted file size when closing streams
 2022-12-07 22:03:13 +01:00
Julius Härtl
3c8fb59fa4
Merge pull request #35620 from nextcloud/fix/fix-calendar-imip-tests 2022-12-07 20:39:41 +01:00
Julius Härtl
59ae6e9dd6
Also update the unencrypted size of files when creating them with empty content 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-12-07 19:12:06 +01:00
Julien Veyssier
4a3f3beb0b
use bruteforce protection on all methods wrapped by PublicShareMiddleware 
if an invalid token is provided or when share password is wrong

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
 2022-12-07 13:24:50 +01:00
Côme Chilliet
7cf1dec842
Fix errors in calendar tests saying function handleIMipMessage does not exists on ICreateFromString 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-06 13:52:13 +01:00
Côme Chilliet
1821712615
Merge pull request #35596 from nextcloud/fix/move-to-ocp-timedjob 
Use TimedJob from OCP instead of OC
 2022-12-06 12:14:43 +01:00
Côme Chilliet
ee06261b82
Fix codestyle in modified files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 16:08:40 +01:00
Côme Chilliet
30560d3165
Merge branch 'master' into tests/fix-phpunit-warnings 
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2022-12-05 12:03:39 +01:00
Côme Chilliet
578648a062
Adapt tests to new job constructors 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 10:41:13 +01:00
J0WI
a4d0700bf2 Fix test image default quality 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2022-12-04 14:51:33 +01:00
John Molakvoæ
a869259e41
More theming cypress tests and some fixes 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-11-29 11:26:27 +01:00
Anna Larch
7c4ceb444c Add group display name cache 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2022-11-28 11:52:55 +00:00
Christopher Ng
4ffc022c8b Copy to clipboard with button instead of link 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2022-11-24 23:50:54 +00:00
Christopher Ng
20da3d081e Add label to sharing search field 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2022-11-23 02:04:18 +00:00
Carl Schwan
e35bcc9381 Fix tests 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-11-22 10:06:19 +01:00
Joas Schilling
d1f2e5e967
Increase the fair-use push limit to 1.000 users 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-11-18 15:39:23 +01:00
John Molakvoæ
d27a39271e
getAppValue expects string 
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2022-11-17 08:03:05 +01:00
Git'Fellow
0f3150cff7
Tests adjustement 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2022-11-16 11:01:32 +01:00
Côme Chilliet
68363f6944
Fix some more problems with tests under PHP 8.2 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-15 16:02:24 +01:00
Côme Chilliet
324126888e
Add Union types for properties in tests/lib/Encryption/Keys/StorageTest.php 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-15 09:29:35 +01:00
Côme Chilliet
0f7e56b3b3
Fix syntax in VerificationTokenTest.php 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-15 09:25:56 +01:00
Côme Chilliet
c79a6b3f62
Fix errors from PHP 8.2 testing 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-14 17:08:21 +01:00
Côme Chilliet
70e2217d1c
Fix dynamic properties and other problems in tests for PHP 8.2 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-14 16:14:35 +01:00
Simon L
4bf1f4e484
Merge pull request #35093 from nextcloud/nickvergessen-patch-1 
Run integration tests on 3rdparty bump
 2022-11-14 09:45:55 +01:00
Joas Schilling
9dd0d0ba57
Run integration tests on 3rdparty bump 
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
 2022-11-11 07:54:26 +01:00
Christoph Wurst
9d0e79f10d
Fix PublicKeyTokenProviderTest import and mock 
* IDBConnection import missing
* Atomic doesn't need a mock

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-11-10 15:40:35 +01:00
Julius Härtl
908b7aa70a
Attempt to fix CalendarImpl tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-11-09 16:37:34 +01:00
Julius Härtl
2a684f6741
Fix some phpunit test warnings 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-11-09 16:37:34 +01:00
szaimen
f9e9cd270d
Limit-number-of-concurrent-preview-generations 
Signed-off-by: Bowen Ding <dbw9580@live.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-11-05 16:03:01 +08:00
Julius Härtl
5c4a66f0c1
Merge pull request #34775 from nextcloud/bugfix/noid/mailer-set-to 
Do not throw errors when invalid setTo email is provided
 2022-11-04 18:24:55 +01:00
Julius Härtl
fd036f774f
Do not throw errors when invalid setTo email is provided 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-11-03 16:59:12 +01:00
Côme Chilliet
2e83a21cd2
Merge pull request #34678 from pulsejet/patch-jpeg 
Interlace all output JPEG
 2022-11-03 16:11:03 +01:00
Côme Chilliet
8a2e52e7f8
Merge pull request #34330 from nextcloud/fix/fix-contacts-test-php8 
Fix ContactsStoreTests under PHP 8.2
 2022-11-03 14:55:06 +01:00
Christoph Wurst
ac92d00da8
Merge pull request #32565 from nextcloud/chore/modernize-error-handler 
Modernize the error handler
 2022-11-03 14:42:51 +01:00
Christoph Wurst
052dcdebe8
Refactor the ErrorHandler into a dynamic class 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-11-02 09:49:37 +01:00
Christoph Wurst
8aea25b5b9
Add remote host validation API 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-10-31 16:13:28 +01:00
Christopher Ng
4a2bbc7af9 Rewrite admin theming in Vue 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2022-10-28 00:18:47 +00:00
Joas Schilling
d007088cf5
Merge pull request #34847 from nextcloud/refactor/local-address-checker-method-capitalization 
Rename LocalAddressChecker methods to lower case
 2022-10-27 15:57:58 +02:00
Julius Härtl
07e94eca6f
Emit typed event when preview is requested 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-10-27 14:31:33 +02:00
Christoph Wurst
d4b9b010b0
Rename LocalAddressChecker methods to lower case 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-10-27 13:24:28 +02:00
Côme Chilliet
0d9c1510ca Fix ContactsStoreTests under PHP 8.2 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-10-26 20:03:49 +00:00
Robin Appelman
3357c8e783 test disabling write check 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-10-26 18:45:59 +00:00
Julius Härtl
aec8dce61a
Merge pull request #34788 from nextcloud/bugfix/noid/preview-attributes 2022-10-26 15:11:01 +02:00
Julius Härtl
298d2b9b58
Skip general login with email for non-valid addresses and LDAP 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-10-26 12:30:25 +02:00
Varun Patil
48917e718e Interlace all output JPEG 
Progressive images are both smaller and faster to load.

Signed-off-by: Varun Patil <radialapps@gmail.com>
 2022-10-25 09:40:20 -07:00
Julius Härtl
8629d8e44f
Check share attributes on preview endpoints 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-10-25 11:35:31 +02:00
Simon L
11108e8032 Revert "fix external storages access" 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-10-23 22:36:34 +02:00
John Molakvoæ
304c1b9b61
Merge pull request #33087 from nextcloud/fix/30282/external-storages 
fix external storages access
 2022-10-23 10:42:46 +02:00
John Molakvoæ
2d98cd1daf
Add config and fix selenium 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-10-19 10:04:51 +02:00
Côme Chilliet
1cb0c2ac52 Fix LostController test 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-10-18 14:49:02 +00:00
Christoph Wurst
c671466422
Merge pull request #34379 from nextcloud/fix/transactional-session-token-renewal 
Run session token renewals in a database transaction
 2022-10-18 11:19:33 +02:00
blizzz
d29332469a
Merge pull request #34609 from nextcloud/enh/noid/always-enable-theming 
set theming app to alwaysEnabled
 2022-10-18 10:13:56 +02:00
Christoph Wurst
c5922e67d3
Run session token renewals in a database transaction 
The session token renewal does
1) Read the old token
2) Write a new token
3) Delete the old token

If two processes succeed to read the old token there can be two new tokens because
the queries were not run in a transaction. This is particularly problematic on
clustered DBs where 1) would go to a read node and 2) and 3) go to a write node.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-10-18 08:28:22 +02:00
szaimen
1d17a0843a set theming app to alwaysEnabled 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-10-17 17:51:39 +02:00
Carl Schwan
9919116716
Merge pull request #31499 from nextcloud/bugfix/empty-secret 
Add fallback routines for empty secret cases
 2022-10-17 16:02:58 +02:00
John Molakvoæ
d77e832223
Fix tests 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-10-14 16:18:40 +02:00
Simon L
b28757fddc
Merge pull request #34437 from nextcloud/feat/theming-default-system-value 
Use default system primary
 2022-10-13 19:57:28 +02:00
John Molakvoæ (skjnldsv)
db831359d3
Allow to pick custom colour 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2022-10-13 12:13:39 +02:00
Joas Schilling
799f660df0
Make CI green again 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-10-13 11:13:13 +02:00
Joas Schilling
e674087ebf
Adjust unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-10-12 16:03:57 +02:00
Roeland Jago Douma
60ee874485
Remove long depreated AppFramework/Db/Mapper 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2022-10-10 08:18:32 +02:00
blizzz
7d024bc337
Merge pull request #32635 from andyxheli/patch-3 
Fix User profile picture when performing the search
 2022-10-05 10:36:43 +02:00
Christopher Ng
7044191eb6 Use brand color for background only and keep accessible color as color primary 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2022-10-05 06:19:08 +00:00
Andy Xheli
ae6a7c88a0 Update ContactsStoreTest.php 
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
 2022-10-03 09:17:27 -05:00
blizzz
ca958de7e9
Merge pull request #33566 from nextcloud/fopen-not-found-rescan 
trigger a rescan when trying to fopen a file that exists in cache but not on disk
 2022-10-01 21:47:26 +02:00
Côme Chilliet
a4c2aeef45
Merge pull request #34329 from nextcloud/fix/cleanup-long-time-deprecated-stuff 
Remove some constants and functions which have been long deprecated
 2022-10-01 17:55:31 +02:00
Christoph Wurst
910c774b35
Merge pull request #34038 from nextcloud/fix/migrate-TagMapper-to-QBMapper 
Migrate TagMapper to QBMapper instead of deprecated Mapper
 2022-09-30 16:46:42 +02:00
Côme Chilliet
4123eeeaa3 Fix ContactsManagerTest test 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-09-30 13:20:04 +00:00
Côme Chilliet
5347fb02dc Remove some constants and functions which have been long deprecated 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-09-30 13:20:03 +00:00
Carl Schwan
92a5a8f075 Cleanup tags and Share component 
- Port to LoggerInterface
- Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB
- Use IEventListener instead of hooks
- Remove the now unused OC_DB and OC_DB_StatementWrapper legacy utils

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-29 15:15:28 +00:00
Robin Appelman
1de0b10751 add test for trying to fopen a file which no longer exists on disk 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-09-29 10:27:32 +02:00
Christopher Ng
295d03869e Fix various theming bugs 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2022-09-28 17:12:56 +00:00
Carl Schwan
de23ff38ff Move avatar clearing in the background 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-26 15:26:31 +00:00
Stanimir Bozhilov
46c10c77e1 Fix the JSON content type regex to match all MIME types 
Signed-off-by: Stanimir Bozhilov <stanimir@audriga.com>
 2022-09-26 11:51:44 +02:00
Arthur Schiwon
a133a8a9d7
remove getDefaultInstallationBundle 
- because all apps are shipped now it was returning an empty result

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-09-22 15:11:39 +02:00
Arthur Schiwon
a7af25e1d9
remove InstallCoreBundle repair step 
- core bundle was empty and thus removed
- all former apps installed this way are shipped

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-09-22 13:24:06 +02:00
Arthur Schiwon
759eaee5ed
remove Core Bundle 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-09-22 13:20:37 +02:00
Stanimir Bozhilov
f7d51a39cf Add unit tests for application/scim+json content type 
Signed-off-by: Stanimir Bozhilov <stanimir@audriga.com>
 2022-09-20 16:19:05 +02:00
Côme Chilliet
31117fa7c7
Fix tests for nested v4 in v6 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-09-20 12:46:22 +02:00
Côme Chilliet
c083f77e4e
Harden tests for local IP detection in URLs 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-09-20 12:14:33 +02:00
Côme Chilliet
4efd0be525 Inform ServerTest that TagMapper now uses QBMapper 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-09-19 10:01:49 +00:00
Vincent Petry
d39f047af2
Merge pull request #34072 from nextcloud/enh/noid/default-enabled-2 
set defaultEnabled in shipped.json
 2022-09-15 22:03:12 +02:00
Robin Appelman
d8961ed10f
fix using FSEEK_END with SeekableHttpStream to get file size 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-09-15 17:23:16 +02:00
Vincent Petry
1998ac7b06
Increase timeout for apps management 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-09-15 17:11:14 +02:00
Vincent Petry
da01494a37
Add accessibility entry in user menu 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-09-14 15:05:35 +02:00
Carl Schwan
bc9a488046
Update avatars on update 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-09 14:23:41 +02:00
Carl Schwan
eac54c4660
Merge pull request #33788 from nextcloud/improve-recent 
Improve getting recent files performance
 2022-09-08 16:19:41 +02:00
blizzz
c77cc80fcc
Merge pull request #33906 from nextcloud/fix/fix-calendar-tests-getTimestamp 
Fix Calendar tests mocking a non-existant method.
 2022-09-08 12:42:03 +02:00
Anna Larch
e3a52ce13e Fix iMIP tests 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2022-09-08 02:26:46 +02:00
blizzz
417f46e467
Merge pull request #33600 from nextcloud/lazy-quota 
get quota for user only when needed
 2022-09-07 18:10:33 +02:00
Carl Schwan
43d1aa38df
More cleaning up of the login component 
- Move css in scopped vue components
- Port to NcNoteCard all the warning messages

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-06 15:20:29 +02:00
Côme Chilliet
98c525a91a
Fix trying to use MockBuilder instead of Mock 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-09-06 09:05:36 +02:00
Côme Chilliet
0b37d89893
Fix Calendar tests mocking a non-existant method. 
There is no ITimeFactory::getTimestamp method, only getTime

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-09-05 18:09:49 +02:00
Carl Schwan
67551f379f
Filter out old files when trying to get recent files 
Only do so when asking for less than 100 files and having an offset
equal to 0.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-05 12:53:32 +02:00
Simon L
6132b6a4ae
Merge pull request #33790 from nextcloud/Valdnet-patch-2 
l10n: Spelling unification
 2022-09-02 17:01:52 +02:00
szaimen
b31c92e6f5 fix tests 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-09-02 16:07:13 +02:00
Robin Appelman
bd91c56539
get quota for user only when needed 
always apply the wrapper but have the wrapper get the quota lazily only when an operation where quota is applied is performed

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-09-01 19:32:24 +02:00
Daniel Calviño Sánchez
92925233ec
Maximize browser window before running the tests 
By the default the browser window is not maximized, but opened with a
size of 1050x978px. In the Files app, when the navigation bar and the
side bar are both open, with the previous design that width caused the
file name to be very very narrow, but still clickable. However, with the
updated design the file name is too narrow and no longer clickable,
which breaks several acceptance tests that descend into subfolders. To
solve that now the browser window is maximized before running the tests,
which makes the window wide enough (1360px) to show the file name and
make it clickable.

This commit also removes a step to close the sidebar that was recently
added to address the problem mentioned above in a previous pull request.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2022-09-01 14:15:43 +02:00
Daniel Calviño Sánchez
76b0947022
Wait for the new user form to be visible 
Before it was checked if the new user form was visible, but it was not
waited for it. It seems that it can happen that the new user form is in
the DOM, and therefore found, but not visible yet when the tests run,
which caused them to (randomly) fail. Due to that now it is explicitly
waited until it is visible, rather than assuming that it is visible as
soon as it appears in the DOM.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2022-09-01 14:15:43 +02:00
Julius Härtl
6dac33ee56
Adjust theming acceptance tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-09-01 14:15:43 +02:00
Vincent Petry
3ae439710e
Merge pull request #33764 from nextcloud/cloudid-cache 
cache cloud id data in CloudIdManager
 2022-09-01 13:27:12 +02:00
Joas Schilling
67ecd72972
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-08-31 20:54:39 +02:00
Simon L
b0f6ca0e0d
Merge pull request #33756 from nextcloud/enh/noid/admin-settings-directly 
add a way to open the admin settings overview directly
 2022-08-31 17:56:11 +02:00
Robin Appelman
1626a56dda
adjusts tests for CloudIdManager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-31 15:47:00 +02:00
szaimen
0c90474296 add a better icon for personal settings 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-08-31 15:37:48 +02:00
szaimen
17ee17cdbf fix tests 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2022-08-31 14:35:13 +02:00
Daniel Calviño Sánchez
ac2d885899 Adjust acceptance tests to changes in app menu 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2022-08-31 12:57:16 +02:00
Côme Chilliet
f56ecf9242
Merge pull request #33640 from nextcloud/fix/fix-symfony-event-typing 
Port Repair and Migrator events to IEventDispatcher
 2022-08-30 14:47:05 +02:00
Côme Chilliet
6f80fe6ada
Remove deprecated at matcher from tests/lib 
Only 15 warnings left in there

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-29 16:36:40 +02:00
Côme Chilliet
791e021455
Remove deprecated at matcher in Updater/VersionCheckTest.php 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-29 15:11:18 +02:00
Côme Chilliet
e5731b3c30
Fix BackgroundRepairTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-25 16:15:48 +02:00
Côme Chilliet
5d313da709
Fix RepairTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-25 16:15:48 +02:00
Côme Chilliet
a83a8f0dde
Migrate Migrator::executeSql to OCP\EventDispatcher\Event 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-08-25 16:13:47 +02:00
Vincent Petry
2911dffd5e
Merge pull request #33516 from nextcloud/update-nextcloud-vue-6.0.0-beta.2 
Bump @nextcloud/vue to 6.0.0-beta.4 and related
 2022-08-25 13:29:36 +02:00
Carl Schwan
9b5569ff74
Merge pull request #33668 from nextcloud/tests/fix-session-middleware 
Fix SessionMiddlewareTest and cover new case with reopening
 2022-08-25 11:00:35 +02:00
Vincent Petry
ede9ac2a75
Adjust acceptance test selectors 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-08-25 09:54:44 +02:00
Julius Härtl
83b1415906
Only pass parent if paths match 
As the user folder might be initialized by the root from two levels
down the hierarchy, passing this as a parent only works if the path matches

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-08-24 22:20:32 +02:00
Julius Härtl
b2d6435737
Avoid extra query for the parent node if we can pass it along 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-08-24 22:20:32 +02:00
Carl Schwan
bd7ab89d2a
Merge pull request #33593 from nextcloud/improve-binary-caching 
Move findBinaryFinder and isFunctionEnabled away from OC_Helper
 2022-08-24 13:09:55 +02:00
Julius Härtl
64a7489958
Fix SessionMiddlewareTest and cover new case with reopening 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-08-24 10:36:57 +02:00
Carl Schwan
9b8ca9ad1f
Move findBinaryFinder and isFunctionEnabled away from OC_Helper 
findBinaryFinder is now a service that is still private but with some
minor optimization (remove the hasKey check).

isFunctionEnabled is now in OCP\Util

Both function are still keep but all internal usage in nextcloud/server
were migrated to the new usage, so that we can remove it in 26

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-08-23 19:44:04 +02:00
Carl Schwan
b888c61463
Merge pull request #33047 from nextcloud/fix/ijob-logger-deprecated 
Deprecated ILogger from IJob
 2022-08-23 16:55:42 +02:00
Anna Larch
4ca4b02793 Support iMIP invitations from Mail 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2022-08-22 22:10:12 +02:00
Louis
a2d145734a
Merge pull request #33565 from nextcloud/debt/remove_todo_push_service_fairuse 
Remove time check in isFairUseOfFreePushService
 2022-08-17 14:14:03 +02:00
Vincent Petry
312b719acf
Merge pull request #32943 from nextcloud/unencrypted-size-revert-interface-changes 
Revert interface changes from "store unencrypted size in the unencrypted_size column"
 2022-08-17 11:36:16 +02:00
Joas Schilling
227c766f16
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-08-17 11:25:18 +02:00