upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-15 22:11:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

Merge pull request #35780 from nextcloud/fix/http-dispatcher-double-parameter-cast

Browse source 
Fix missing cast of double controller parameters
This commit is contained in:
Vincent Petry 2022-12-16 16:18:35 +01:00 committed by GitHub
commit ae6fe874ed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/private/AppFramework/Http/Dispatcher.php
View file

@ -194,7 +194,7 @@ class Dispatcher {
$arguments = [];
// valid types that will be casted
$types = ['int', 'integer', 'bool', 'boolean', 'float'];
$types = ['int', 'integer', 'bool', 'boolean', 'float', 'double'];
foreach ($this->reflector->getParameters() as $param => $default) {

21
tests/lib/AppFramework/Http/DispatcherTest.php
View file

@ -51,11 +51,12 @@ class TestController extends Controller {
/**
* @param int $int
* @param bool $bool
* @param double $foo
* @param int $test
* @param int $test2
* @param integer $test2
* @return array
*/
public function exec($int, $bool, $test = 4, $test2 = 1) {
public function exec($int, $bool, $foo, $test = 4, $test2 = 1) {
$this->registerResponder('text', function ($in) {
return new JSONResponse(['text' => $in]);
});
@ -315,7 +316,8 @@ class DispatcherTest extends \Test\TestCase {
[
'post' => [
'int' => '3',
'bool' => 'false'
'bool' => 'false',
'double' => 1.2,
],
'method' => 'POST'
],
@ -346,6 +348,7 @@ class DispatcherTest extends \Test\TestCase {
'post' => [
'int' => '3',
'bool' => 'false',
'double' => 1.2,
'test2' => 7
],
'method' => 'POST',
@ -377,7 +380,8 @@ class DispatcherTest extends \Test\TestCase {
[
'post' => [
'int' => '3',
'bool' => 'false'
'bool' => 'false',
'double' => 1.2,
],
'urlParams' => [
'format' => 'text'
@ -410,7 +414,8 @@ class DispatcherTest extends \Test\TestCase {
[
'post' => [
'int' => '3',
'bool' => 'false'
'bool' => 'false',
'double' => 1.2,
],
'urlParams' => [
'format' => 'json'
@ -443,7 +448,8 @@ class DispatcherTest extends \Test\TestCase {
[
'post' => [
'int' => '3',
'bool' => 'false'
'bool' => 'false',
'double' => 1.2,
],
'server' => [
'HTTP_ACCEPT' => 'application/text, test',
@ -477,7 +483,8 @@ class DispatcherTest extends \Test\TestCase {
[
'post' => [
'int' => '3',
'bool' => 'false'
'bool' => 'false',
'double' => 1.2,
],
'get' => [
'format' => 'text'