provokateurin
f206c606fe
fix(settings): Rework download/install/update/remove app handling and respect read-only app roots
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-24 15:00:07 +01:00
provokateurin
75b59b91d1
fix(Installer): Download app into the previous app root and reject if it is read-only
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-24 15:00:07 +01:00
provokateurin
4e8786c98b
fix(Installer): Actually remove apps from separate apps roots and respect read-only apps roots
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-24 15:00:07 +01:00
Côme Chilliet
1ce593311b
fix: Go back to soft typing for template function p
...
Strong typing breaks legacy code in this case.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-24 12:53:27 +01:00
Ferdinand Thiessen
214ac4c4a3
Merge pull request #51611 from nextcloud/fix/file-name-validator-case-sensitivity
...
fix(IFilenameValidator): correctly handle case insensitivity
2025-03-24 12:46:33 +01:00
Ferdinand Thiessen
b9f9190894
fix(ocm): publicKey can be disabled so capabilities do not match
...
When the public key feature is disabled null is returned for
`publicKey`. So in this case we need to adjust the capabilities
and return type of `jsonSerialize()`.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-21 09:15:55 +01:00
Ferdinand Thiessen
254dd85664
fix(IFilenameValidator): correctly handle case insensitivity
...
- forbidden names and forbidden base names are case **insensitive**
so we need to check all lowercase here.
- add test that config value is also read case insensitive.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-21 01:00:58 +01:00
Côme Chilliet
101b1f0eaf
chore: cleanup human_file_size usage
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Côme Chilliet
e9046a0f24
fix: Remove obsolete component template function
...
HTML imports are not a thing anymore, they are not supported by any
browser.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Côme Chilliet
13fe0f5612
fix: Clean up typing and remove deprecated calls in template functions
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Côme Chilliet
aac391d466
chore: Move template functions out of legacy folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Côme Chilliet
a83cae1a0e
fix: Remove multiple require_once calls for template functions
...
Only require them when include the template file instead
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-20 10:54:50 +01:00
Ferdinand Thiessen
a243e9cfbb
fix(webauthn): do not require bcmath or gmp - not needed anymore
...
The extensions are not required anymore but only recommended for
performance. See also:
https://github.com/web-auth/webauthn-framework/issues/213
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 11:19:49 +01:00
Ferdinand Thiessen
d5efd17942
fix(IMimeTypeDetector): use correct return type
...
In PHP array keys that are integers are always kept as integer,
meaning the type of the key of `$a = ["1" => "one"]` will be integer not
string.
While are hacks to circumvent this (case std object with string keys to
an assoc. array) those hacks are performance wise awefull and also not
needed as in PHP you can always access that element with `$a[1]` or
`$a["1"]`.
So TL;DR;: do not lie about return types.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-18 15:34:28 +01:00
Joas Schilling
c9aea8ffdf
fix(auth): Allow 2FA challenges for Ephemeral sessions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-18 09:52:51 +01:00
Ferdinand Thiessen
4d453d38de
Merge pull request #51480 from nextcloud/fix/deprecation-comment
...
chore: drop outdated deprecation comment from Mailer
2025-03-17 18:43:44 +01:00
Hamza
bf06b2552b
Merge pull request #51380 from nextcloud/fix/noid/contactsmenu-ab-enabled
...
fix(cardav): only show users from enabled addressBooks in contacts menu
2025-03-17 17:51:41 +01:00
Git'Fellow
dda2148f6f
Merge pull request #51333 from nextcloud/filePointerCheck
...
fix(files): Make sure file pointer exists
2025-03-17 17:04:24 +01:00
Hamza Mahjoubi
c9d9abd46e
fix(cardav): only show useres from enabled addressBooks in contacts menu
...
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-03-17 11:56:34 +01:00
Daniel Kesselberg
db86cf8db1
fix: skip caching lastSeenQuotaUsage for remote shares
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-03-14 10:24:34 +01:00
Ferdinand Thiessen
4717f5cbc9
chore: drop outdated deprecation comment from Mailer
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-14 09:09:53 +01:00
skjnldsv
0179cb4d8d
feat(core): add setup cypress tests
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-13 20:51:00 +01:00
provokateurin
3c698c6553
fix(RichObjectStrings): Make exception messages for invalid parameters more useful for debugging
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-12 14:52:32 +01:00
Ferdinand Thiessen
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +01:00
Ferdinand Thiessen
34251c4375
fix(lookup-server): do not query data by default
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +01:00
Robin Appelman
8edca98e8e
fix: fix getNodeFromCacheEntryAndMount using relative path
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-03-10 18:19:20 +01:00
Côme Chilliet
eb597917f6
Merge pull request #51029 from nextcloud/fix/deprecate-oc-template-and-cleanup
...
fix: Deprecate OC_Template, add proper template manager instead
2025-03-10 16:20:45 +01:00
Côme Chilliet
30382a5d8d
chore: Remove now unused methods from User manager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-10 11:30:18 +01:00
Côme Chilliet
0b449f302b
fix: Correctly count disabled users for SAML groups subadmins
...
If too many users return -1 as for LDAP so that link is shown
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-10 11:30:18 +01:00
Git'Fellow
4d52b185af
fix(files): Make sure file pointer exists
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-03-07 19:16:30 +01:00
Julius Knorr
bb6b462690
Merge pull request #51130 from nextcloud/fix/credential-passwordless-auth
...
fix: Do not build encrypted password if there is none
2025-03-07 16:49:18 +01:00
Côme Chilliet
b086f10028
fix: Use a dedicated Exception class for when a template is not found
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
f033ef7c18
fix: Migrate all uses of OCP\Template to OCP\Template\ITemplateManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
558f4c854d
fix: Cleanup of internal class TemplateLayout
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
1725d63820
fix: Fix signatures and types in template related classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
2cd90f8281
fix: Replace all usage of OC_Template by the new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
253628ad5a
fix: Fix psalm issues and add missing methods to ITemplate interface
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
f19ddd5525
fix: Add missing ITemplate interface and clean code in Template class
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
Côme Chilliet
71dc34c03c
fix: Deprecate OC_Template, add proper template manager instead
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-06 15:49:25 +01:00
skjnldsv
4c0c88a0d5
fix(systemtags): prevent tag edition if restricted
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-06 11:57:22 +01:00
Julius Knorr
777cd941dc
fix: Do not build encrypted password if there is none
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-06 09:31:29 +01:00
Louis
3459ff9638
Merge pull request #51280 from nextcloud/artonge/fix/publicpage_attribute
...
fix(login): Properly target public page with attribute
2025-03-05 17:54:16 +01:00
Andy Scherzinger
fdb246c1cf
Merge pull request #50702 from Institutional-Investment-Group/feat/support-aws-session-token9
...
feat(object_store): Add support for session token (STS) in AWS credentials
2025-03-05 17:40:05 +01:00
Louis Chemineau
a163fa08d0
fix(login): Properly target public page with attribute
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 16:36:26 +01:00
Marcel Müller
3391279068
fix: No IFactory in constructor
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-03-05 11:04:55 +01:00
Joas Schilling
0522b0373e
fix(files): Don't do session related work in the constructor of the View
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-05 09:06:16 +01:00
Cleopatra Enjeck M.
32e46a8b3a
fix: use mb_strtolower to convert login name
...
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
2025-03-05 05:00:24 +00:00
Cleopatra Enjeck M.
a6d6a1fa9e
fix: Improve string comparison
...
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
2025-03-05 05:00:24 +00:00
Cleopatra Enjeck M.
6690a28cc0
fix: Use case insensitive check when validating login name
...
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
2025-03-05 05:00:24 +00:00
Hector Manuel
12a92a2e8b
Merge branch 'master' into feat/support-aws-session-token
2025-03-04 18:27:54 +01:00