upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-11 17:52:02 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 40

fix(Installer): Download app into the previous app root and reject if it is read-only

Browse source 
Signed-off-by: provokateurin <kate@provokateurin.de>
This commit is contained in:
provokateurin 2025-03-24 11:27:49 +01:00
parent 4e8786c98b
commit 75b59b91d1
No known key found for this signature in database
1 changed files with 23 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
lib/private/Installer.php
View file

@ -18,6 +18,7 @@ use OC\DB\Connection;
use OC\DB\MigrationService;
use OC_App;
use OC_Helper;
use OCP\App\AppPathNotFoundException;
use OCP\App\IAppManager;
use OCP\HintException;
use OCP\Http\Client\IClientService;
@ -176,10 +177,28 @@ class Installer {
*/
public function downloadApp(string $appId, bool $allowUnstable = false): void {
$appId = strtolower($appId);
$appManager = \OCP\Server::get(IAppManager::class);
$apps = $this->appFetcher->get($allowUnstable);
foreach ($apps as $app) {
if ($app['id'] === $appId) {
try {
$appPath = $appManager->getAppPath($appId);
} catch (AppPathNotFoundException) {
$appPath = OC_App::getInstallPath() . '/' . $appId;
}
$appsRootWritable = false;
$appRootPath = dirname($appPath);
foreach (\OC::$APPSROOTS as $appsRoot) {
if ($appsRoot['path'] === $appRootPath) {
$appsRootWritable = $appsRoot['writable'] ?? false;
}
}
if (!$appsRootWritable) {
throw new \Exception(sprintf('App %s can not be updated because the app root is not writable.', $appId));
}
// Load the certificate
$certificate = new X509();
$rootCrt = file_get_contents(__DIR__ . '/../../resources/codesigning/root.crt');
@ -322,15 +341,14 @@ class Installer {
);
}
$baseDir = OC_App::getInstallPath() . '/' . $appId;
// Remove old app with the ID if existent
OC_Helper::rmdirr($baseDir);
OC_Helper::rmdirr($appPath);
// Move to app folder
if (@mkdir($baseDir)) {
if (@mkdir($appPath)) {
$extractDir .= '/' . $folders[0];
OC_Helper::copyr($extractDir, $baseDir);
OC_Helper::copyr($extractDir, $appPath);
}
OC_Helper::copyr($extractDir, $baseDir);
OC_Helper::copyr($extractDir, $appPath);
OC_Helper::rmdirr($extractDir);
return;
}