Commit graph

3476 commits

Author SHA1 Message Date
Lorenz
ebf5cd2afe
Merge pull request #1732 from RincewindsHat/check_log_missing_oldlog_abort
Missing oldlog now aborts check_log
2021-12-20 15:57:11 +01:00
RincewindsHat
c1bf69c3a6 Apparently Dash is not Bash, so -v does not work 2021-12-20 00:08:24 +01:00
Lorenz
78801192cf
Merge pull request #1725 from monitoring-plugins/check_game_update_url
Update Url to qstat
2021-12-19 17:17:46 +01:00
RincewindsHat
5a81bd813e Missing oldlog now aborts check_log 2021-12-02 17:10:57 +01:00
RincewindsHat
f5d22b4a56
Merge pull request #1459 from waja/fix/shellcheck
Several fixes shellcheck complaining about
2021-12-02 16:55:55 +01:00
RincewindsHat
911e44045d
Merge branch 'master' into fix/shellcheck 2021-12-02 16:42:05 +01:00
RincewindsHat
ed7cdf82a4
Merge pull request #1490 from leeclemens/mailq-add-config-dir
check_mailq: Add mailq -C option for config dir or config file
2021-12-02 16:16:57 +01:00
RincewindsHat
8df8460c6c
Fix syntax error resulting from merging 2021-12-02 15:26:31 +01:00
RincewindsHat
df1e9e975f
Merge branch 'master' into mailq-add-config-dir 2021-12-02 15:11:21 +01:00
RincewindsHat
1a3a715702
Merge pull request #1730 from RincewindsHat/check_file_age_more_explicit_help
Make size parameter a little bit more intelligible
2021-11-29 17:41:44 +01:00
RincewindsHat
5e2c399220 Make size parameter a little bit more intelligible 2021-11-29 17:27:57 +01:00
RincewindsHat
f589b7041f
Merge pull request #1493 from darksoul42/master
Fix regexp for nullmailer "mailq" output.
Looks good. Thank you very much.
2021-11-29 15:39:28 +01:00
RincewindsHat
d752c891f4
Merge pull request #1692 from RincewindsHat/modernize_check_log
Modernize check log
2021-11-28 14:30:22 +01:00
RincewindsHat
36415f0c3e
Merge pull request #1729 from RincewindsHat/fix_QL_problems
Fix some QL problems
2021-11-25 09:03:21 +01:00
RincewindsHat
c39de8869e
Merge pull request #1727 from phibos/fix_check_ups_1030
Fix possible overflow in check_ups.
Looks good to me too, thank you very much
2021-11-25 00:56:27 +01:00
RincewindsHat
d28bab4dbd More wrong printf formatting 2021-11-24 19:02:17 +01:00
RincewindsHat
40d4e8a057 check_hpjd: Fixing port option 2021-11-24 15:38:18 +01:00
RincewindsHat
e2f24a5af3 Fix CodeQL checks 2021-11-24 14:25:42 +01:00
RincewindsHat
0e311b77d9
Merge pull request #1682 from phibos/codeql
Add CodeQL checks
2021-11-24 12:03:10 +01:00
PhiBo
09bfb1b482 Fix possible overflow in check_ups (Fixes: #1030) 2021-11-24 11:23:47 +01:00
RincewindsHat
f291934f2c Update Url to qstat 2021-11-21 02:43:01 +01:00
RincewindsHat
df835cfde0
Merge pull request #1723 from RincewindsHat/check_swap_smallfix_and_style
Small fix to threshold validation and style (indentation) fixes
2021-11-19 10:29:10 +01:00
RincewindsHat
6e18790b69
Merge pull request #1724 from mullumaus/master
Allows check_ldap to read password from environment variable
2021-11-19 10:11:46 +01:00
Linda Guo
f961b7f7bd Allows check_ldap to get password from env variable
It's not secure to provide LDAP password through command line option
because other users on the same host can see the password in
'ps' command output.

This change allows check_ldap to get password from environment variable.
2021-11-19 19:47:22 +11:00
Lorenz Kästle
c46447af65 Fix option description authpassword -> authpasswd 2021-11-19 09:30:20 +01:00
Lorenz Kästle
cf9dccbec2 Revert "Fixed option description authpassword -> authpasswd + whitespaces"
This reverts commit b27e639725.
2021-11-19 09:30:20 +01:00
Lorenz Kästle
a1fe4df6a3 Fixed option description authpassword -> authpasswd + whitespaces 2021-11-19 09:30:20 +01:00
RincewindsHat
ee3449dee7 Small fix to threshold validation and style (indentation) fixes 2021-11-19 00:34:44 +01:00
RincewindsHat
d6d2254312
Merge pull request #1697 from RincewindsHat/dont_show_rta_if_useless
check_ping: Do not show RTA if no connection was possible
2021-11-18 10:00:12 +01:00
RincewindsHat
4549a95243
Merge pull request #1654 from wolfgangkarall/master
check_procs -- exchange needle and haystack in strstr() for proper st…
2021-11-17 18:09:25 +01:00
RincewindsHat
ad45727dbe
Merge pull request #1688 from bazzisoft/master
check_curl.c: bugfix: verify certificates option should not force SSL to be used
2021-11-17 17:57:00 +01:00
RincewindsHat
e030c2d17c Add thresholds even if value is missing 2021-11-17 15:45:49 +01:00
RincewindsHat
1c53c4f541 homogenize perfdata function and fix small bug with missing semicolon 2021-11-17 15:45:17 +01:00
RincewindsHat
0214ec1918 Show RTA as unknown if it can not be determined 2021-11-17 14:23:24 +01:00
rincewind
27d96dcf23 Do not show RTA if no connection was possible 2021-11-17 14:23:24 +01:00
Sven Nierlein
024d268386 check_snmp: fix performance thresholds when using multiple oids
when using check_snmp with multiple oids it simply printed the unparsed content
from -w/-c into the thresholds for each oid. So each oid contained the hole -w
from all oids.

./check_snmp ... -o iso.3.6.1.2.1.25.1.3.0,iso.3.6.1.2.1.25.1.5.0 -w '1,2' -c '3,4'

before:
  SNMP ... | HOST-RESOURCES-MIB::hrSystemInitialLoadDevice.0=393216;1,2;3,4 HOST-RESOURCES-MIB::hrSystemNumUsers.0=24;1,2;3,4

after:
  SNMP ... | HOST-RESOURCES-MIB::hrSystemInitialLoadDevice.0=393216;1;3 HOST-RESOURCES-MIB::hrSystemNumUsers.0=24;2;4

This also applies to fixed thresholds since check_snmp translates negative infinities from: '~:-1' to '@-1:~'
2021-11-17 14:04:09 +01:00
Aksel Sjögren
3f9b22ab16 check_icmp: Fix pkt perfdata in check_host mode
Add missing "warn" threshold field in "pkt" perfdata output.
Perfdata should be interpreted as;

  'label'=value[UOM];[warn];[crit];[min];[max]

With one field missing, the hardcoded min value '0' ended up in the
"crit" field, making applications interpreting the perfdata thining that
critical threshold is always exceeded.

Signed-off-by: Aksel Sjögren <asjogren@itrsgroup.com>
2021-11-15 17:55:49 +01:00
RincewindsHat
bc6effd2b5
Merge pull request #1715 from ghen2/lmtp
check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO).
2021-11-11 18:04:06 +01:00
Sven Nierlein
c3abdb9267 check_procs: add test for elapsed time 2021-11-01 13:35:11 +01:00
Sven Nierlein
1fda28f124 remove unused test file
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-11-01 13:35:11 +01:00
Sven Nierlein
282ccd4a8b check_procs: improve ps args autodetection
one of the first ps commands in the configure.ac is `axwo 'stat comm vsz rss user uid pid ppid args'` which
works on most modern linux systems (checked debian 10/11 and centos 7/8). But this test misses the etime
argument. Therefore `check_procs --metric=ELAPSED` does not work.

To fix this, we simply do the same test including etime before that one.

Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-11-01 13:35:11 +01:00
Sven Nierlein
1738d14c0c check_procs: remove trailing whitespace 2021-11-01 13:35:11 +01:00
Geert Hendrickx
0bd45c200b
check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO). 2021-10-28 23:08:02 +02:00
RincewindsHat
7415eb2f06
Merge pull request #1714 from RincewindsHat/fix_perfdata_for_big_values_for_check_disk
Fix perfdata for big values for check disk.

First merge \o/
2021-10-28 16:13:28 +02:00
RincewindsHat
884327ee21 Replace tabs with spaces and do some formatting 2021-10-27 12:53:13 +02:00
RincewindsHat
5974b0481c Remove whitespace at the end of lines 2021-10-27 12:53:13 +02:00
RincewindsHat
4c8ab67dd3 Fix my own errors for real this time and add some comments, so I wont do them again 2021-10-26 21:09:55 +02:00
RincewindsHat
73ed8109e5 Re-add separation semicolons for perfdata, which I deleted 2021-10-26 20:47:28 +02:00
RincewindsHat
6e0586c8e3 Reform some arithmetical operations for more clarity 2021-10-26 17:07:09 +02:00
RincewindsHat
1c0882def0 hopefully fix warning high tide with percentage 2021-10-26 17:07:09 +02:00