Commit graph

2502 commits

Author SHA1 Message Date
Sven Nierlein
c7ea2aed74 check_disk_smb: fixed number of tests to skip 2013-09-17 10:23:08 +02:00
Sven Nierlein
982cbeea00 check_disk: get_fs_usage hasn't been run if using groups
the reason why it still worked sometimes was fsu_blocks beeing uninitialized
which resulted in a true test sometimes.
2013-09-16 15:30:56 +02:00
Sven Nierlein
63312395ee check_disk_smb: verify path to smbclient 2013-09-16 13:59:27 +02:00
Sven Nierlein
adc9d71b4b check_procs: fix test with sleeping processes
at least on freebsd, there are a processes with state 'S', they always
use two character status.
2013-09-16 13:49:44 +02:00
Sven Nierlein
c001fb98ff check_http: tests use supplied value if possible 2013-09-16 13:49:44 +02:00
Sven Nierlein
2b23caf3d1 check_dhcp: fix tests for machines with default interace != eth0 2013-09-16 13:49:44 +02:00
Sven Nierlein
0b656ecd2f tests: don't skip utils test 2013-09-16 08:59:37 +02:00
Sven Nierlein
095e2e5db5 check_dhcp test: skip subtests if no variable is set 2013-09-16 08:51:04 +02:00
Sven Nierlein
5d58592cfe check_dhcp: add test file 2013-09-15 22:15:21 +02:00
Sven Nierlein
3c958ac738 check_icmp: tests do not require sudo if run by root 2013-09-15 21:57:27 +02:00
Sven Nierlein
a7f5e8a765 plugins-root: include t folder in release tarball 2013-09-15 21:33:29 +02:00
Sven Nierlein
cb8390aec9 check_tcp: use receive timeout for checks that expect response
if check_imap expects a string that never occurs, it currently waits forever
because thats how the imap protocoll works. Use a receive timeout in that case
so we can exit early with a proper error message.
2013-09-15 20:49:36 +02:00
Sven Nierlein
c900ee2772 check_ping: increase test timeout
freebsds ping takes a few seconds till it returns, so a 1 second timeout does
not work for the test.
2013-09-14 21:06:26 +02:00
Sven Nierlein
c7d6730255 check_load: add alternative uptime syntax
check_load parses load from the uptime command if no proc filesystem is available. Seems
like there are at least 2 different uptime outputs.

linux:
 20:44:34 up 25 days,  2:07, 13 users,  load average: 0.13, 0.17, 0.22

freebsd 8:
 8:44PM  up  4:29, 1 user, load averages: 0.00, 0.00, 0.00
2013-09-14 20:44:54 +02:00
Sven Nierlein
6361247b4c check_udp: try nc.traditional too
nc.traditional is available on (at least) ubuntu systems and uses traditional nc syntax
2013-09-14 19:59:17 +02:00
Sven Nierlein
7b122f13db tests: move ipv6 detection into NPTest module 2013-09-14 19:36:20 +02:00
Sven Nierlein
32ec6265a4 unified nc syntax
older netcats do not understand -p, they expect host and port as additional argument.
This is backwards compatibel to newer clients. Also support netcat instead of nc.
2013-09-13 23:08:07 +02:00
Sven Nierlein
8b1c574298 fping: some fping versions set loss to 0% by mistake
fping v2.4b2 returns
10.99.0.1 : xmt/rcv/%loss = 0/0/0%
for a failed host, so we assume the host is down if xmt is zero
2013-09-13 17:14:33 +02:00
Sven Nierlein
8f5e92e1ed NPTest: ensure all systems use same amount of whitespace 2013-09-13 13:37:41 +02:00
Sven Nierlein
4933146e00 check_snmp: add timeout handler befor running snmpget 2013-09-12 23:39:32 +02:00
Sven Nierlein
c0926c2b1e check_tcp: only test ipv6 if ping6 works 2013-09-12 23:39:31 +02:00
Sven Nierlein
38ef9b60a0 tests: sort cached settings before save 2013-09-12 23:39:31 +02:00
Sven Nierlein
07f9a0f627 tests: make sure tests don't hang 2013-09-12 23:39:31 +02:00
Holger Weiss
ffad261eab check_tcp: Fix checks without --expect string
Commit e8044713d4 broke check_tcp checks
without --expect string, this commit fixes that regression.
2013-09-12 22:36:35 +02:00
Holger Weiss
7573aa1616 Minor cosmetic changes 2013-09-12 21:50:18 +02:00
Holger Weiss
e8044713d4 check_tcp: Properly deal will partial recv(3)s
The np_expect_match() function now returns one of three possible states
instead of just TRUE or FALSE:

- NP_MATCH_SUCCESS
- NP_MATCH_FAILURE
- NP_MATCH_RETRY

The NP_MATCH_RETRY state indicates that matching might succeed if
np_expect_match() is called with a longer input string.  This allows
check_tcp to decide whether it makes sense to wait for additional data
from the server.
2013-09-12 21:37:20 +02:00
Holger Weiss
662997251d Improve interface of np_expect_match() function
Replace the three boolean parameters of lib/utils_tcp.c's
np_expect_match() function with a single "flags" parameter.
2013-09-12 17:42:10 +02:00
Holger Weiss
ca9ce71576 Don't mark SSL_METHOD variable as "const"
The SSL_CTX_new(3) function expects a non-"const" SSL_METHOD value.
2013-09-10 22:49:03 +02:00
Holger Weiss
5b0e00782d Move global variables from .h to .c files
Simplify things by moving the definition of global variables into .c
files, where they belong.
2013-09-10 22:45:45 +02:00
Holger Weiss
b48cb1f130 Fix GCC's -Wimplicit-function-declaration warnings
Fix the issues found by GCC when the -Wimplicit-function-declaration
flag is specified.
2013-09-10 22:29:46 +02:00
Holger Weiss
d4a781817c Fix GCC's -Wuninitialized warnings
Fix the issues found by GCC when the -Wuninitialized flag is specified.
2013-09-10 20:52:13 +02:00
juliopedreira
cfb50add53 check_tcp: Don't close connection too early
Closing the connection because the bytes received are less than the
buffer size assumes that all the bytes will be received in one go.  This
is not always true!
2013-09-10 12:16:46 +02:00
Holger Weiss
5bfca4b34d s/--proxy_authorization/--proxy-authorization/
The check_http option "--proxy_authorization" is now called
"--proxy-authorization" instead.  It was always documented this way, and
we don't usually use underscores in option names.
2013-09-10 00:46:06 +02:00
Holger Weiss
e8594f461d check_snmp: Initialize size_t value to 0, not NULL 2013-09-05 00:19:36 +02:00
Holger Weiss
8230bbd4a4 Update bundled libtool files
Import the current libtool version 2.4.2.
2013-09-05 00:03:00 +02:00
Holger Weiss
317d2896dc check_icmp: Minor whitespace/indentation fixes 2013-09-04 22:28:50 +02:00
Holger Weiss
a480681cb7 check_icmp: Support "--help" and "--version"
Let check_icmp provide "--help" and "--version" flags (in addition to
"-h" and "-V"), just as the other plugins do.
2013-09-04 22:20:26 +02:00
Holger Weiss
b15adb7762 Remove "contrib" plugins
These days, sites such as "Nagios Exchange" are a much better place for
publishing plugins not maintained by the Plugins Development Team.
2013-09-02 13:16:24 +02:00
Holger Weiss
c4d5882b9e Remove the outdated "command.cfg" file 2013-09-02 13:09:24 +02:00
Holger Weiss
ba7615631a Merge branch 'hw/update-pm'
* hw/update-pm:
  Use own variable instead of ENV
  Updated with last working copy of build_perl_modules used by Opsview

Conflicts:
	tools/build_perl_modules
2013-08-30 18:15:00 +02:00
Holger Weiss
5789548373 developer-guidelines.sgml: Update copyright year
We touched the Development Guidelines this year.
2013-08-27 18:42:51 +02:00
Holger Weiss
8e9abad8e6 NEWS: Mention that check_snmp now supports >8 OIDs
Closes #37.
2013-08-27 18:38:18 +02:00
Holger Weiss
92fdab87b2 Partially revert "check_snmp: Close potential for using uninitialized memory"
This reverts the changes to plugins/common.h applied by commit
a20611d435.

- Clang defines __GNUC__.
- The new name of the __attribute__ parameter was misleading.
2013-08-27 18:32:38 +02:00
Holger Weiss
1cbc73bc8b check_snmp: Fix --help segfault 2013-08-27 16:08:49 +02:00
Holger Weiss
e9ede0f8e3 Merge branch 'master' of https://github.com/ozamosi/nagios-plugins
* 'master' of https://github.com/ozamosi/nagios-plugins:
  check_snmp: Close potential for using uninitialized memory
  check_snmp: Dynamically grow all data structures

Conflicts:
	plugins/check_snmp.c
2013-08-27 14:37:13 +02:00
Holger Weiss
69b1355286 NEWS: Mention new "check_disk -f" option
Closes #22.
2013-08-26 23:24:03 +02:00
Holger Weiss
efa9b0fc08 Merge branch 'master' of https://github.com/bugness-chl/nagios-plugins
* 'master' of https://github.com/bugness-chl/nagios-plugins:
  check_disk: option to ignore reserved space

Conflicts:
	plugins/check_disk.c
2013-08-26 23:23:55 +02:00
Ton Voon
af85216c79 Use own variable instead of ENV 2013-08-23 17:13:09 +01:00
Ton Voon
ed9a0f3a7b Updated with last working copy of build_perl_modules used by Opsview 2013-08-23 15:17:17 +01:00
Sven Nierlein
fae168a68b perlmods: fixed install_order
on older systems Module::Build is not available by default, therefore we have
to change the order of installation.
2013-08-23 12:40:55 +02:00