Commit graph

3422 commits

Author SHA1 Message Date
RincewindsHat
bc6effd2b5
Merge pull request #1715 from ghen2/lmtp
check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO).
2021-11-11 18:04:06 +01:00
Sven Nierlein
c3abdb9267 check_procs: add test for elapsed time 2021-11-01 13:35:11 +01:00
Sven Nierlein
1fda28f124 remove unused test file
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-11-01 13:35:11 +01:00
Sven Nierlein
282ccd4a8b check_procs: improve ps args autodetection
one of the first ps commands in the configure.ac is `axwo 'stat comm vsz rss user uid pid ppid args'` which
works on most modern linux systems (checked debian 10/11 and centos 7/8). But this test misses the etime
argument. Therefore `check_procs --metric=ELAPSED` does not work.

To fix this, we simply do the same test including etime before that one.

Signed-off-by: Sven Nierlein <sven@nierlein.de>
2021-11-01 13:35:11 +01:00
Sven Nierlein
1738d14c0c check_procs: remove trailing whitespace 2021-11-01 13:35:11 +01:00
Geert Hendrickx
0bd45c200b
check_smtp: add -L flag to support LMTP (LHLO instead of HELO/EHLO). 2021-10-28 23:08:02 +02:00
RincewindsHat
7415eb2f06
Merge pull request #1714 from RincewindsHat/fix_perfdata_for_big_values_for_check_disk
Fix perfdata for big values for check disk.

First merge \o/
2021-10-28 16:13:28 +02:00
RincewindsHat
884327ee21 Replace tabs with spaces and do some formatting 2021-10-27 12:53:13 +02:00
RincewindsHat
5974b0481c Remove whitespace at the end of lines 2021-10-27 12:53:13 +02:00
RincewindsHat
4c8ab67dd3 Fix my own errors for real this time and add some comments, so I wont do them again 2021-10-26 21:09:55 +02:00
RincewindsHat
73ed8109e5 Re-add separation semicolons for perfdata, which I deleted 2021-10-26 20:47:28 +02:00
RincewindsHat
6e0586c8e3 Reform some arithmetical operations for more clarity 2021-10-26 17:07:09 +02:00
RincewindsHat
1c0882def0 hopefully fix warning high tide with percentage 2021-10-26 17:07:09 +02:00
RincewindsHat
726a29a3ac Fix some tests 2021-10-26 17:07:09 +02:00
RincewindsHat
d3af7a353e Remove useless lines and fix some formatting 2021-10-26 17:07:09 +02:00
RincewindsHat
50fc9b73a2 Switch to uint64_t 2021-10-26 17:07:09 +02:00
RincewindsHat
8f2cfd1c80 Reformat a little bit for easier reading 2021-10-26 17:07:09 +02:00
RincewindsHat
078c69d2dd Recognice IEC binary units and format accordingly to base2 (always) 2021-10-26 17:07:09 +02:00
Harald Jenny
e79ada81a6 Update check_load.t
adjust tests for new plugin output
2021-10-25 16:28:15 +02:00
Harald Jenny
a08215368e Create check_load.c
just a cosmetic fix so the load plugin display a LOAD prefix before check results
2021-10-25 16:28:15 +02:00
Sven Nierlein
a96161c824 actions: map utmp from host to container
this fixes the check_users not having any logged in user to check.
2021-10-25 16:21:59 +02:00
Lorenz Kästle
03028d23b6 Add comment to make the purpose of the nickname fix more obvious 2021-10-20 11:14:44 +02:00
Lorenz Kästle
ead405515f Restrict the nickname length of the test user for check_ircd
check_ircd was using the string `ircd` plus the PID as a nickname
for connecting to a IRC network by default.
This caused errors, when the PID was too high and the network
restricted the length of the nickname to 9 characters.
This patch "fixes" this by just cutting it of, if it gets too big.
2021-10-20 11:14:44 +02:00
Holger Weiss
2f80d55b8e Merge remote-tracking branch 'monitoring-plugins/pr/1707'
* monitoring-plugins/pr/1707:
  Revert to poor man's logic
  Change all to comments to old comment style
  Fix comparing logic
  Remove spaces from tests
  check_swap: Fix perfdata und thresholds for big values and simplify code
  Introduce new perfdata functions and stuff for using (u)int64_t
2021-10-03 13:37:12 +02:00
RincewindsHat
46c5327e34 Revert to poor man's logic 2021-10-02 23:37:12 +02:00
RincewindsHat
d2f2da175e Change all to comments to old comment style 2021-10-02 12:47:50 +02:00
RincewindsHat
f55ea7632f Fix comparing logic 2021-09-26 01:34:45 +02:00
RincewindsHat
280ae58ed8 Remove spaces from tests 2021-09-26 00:34:44 +02:00
rincewind
4621427ba8 check_swap: Fix perfdata und thresholds for big values and simplify code
The original problem was https://github.com/monitoring-plugins/monitoring-plugins/pull/1705
where the performance data output of check_swap did not conform to
the parser logic of a monitoring system (which decided to go for
"correct" SI or IEC units.
The PR was accompanied by a change to byte values in the performance
data which broke the _perfdata_ helper function which could not handle
values of this size.
The fix for this, was to use _fperfdata_ which could, but would
use float values.

I didn't like that (since all values here are discreet) and this
is my proposal for a fix for the problem.

It introduces some helper functions which do now explicitely work
with (u)int64_t, including a special version of the _perfdata_ helper.

In the process of introducing this to check_swap, I stumbled over
several sections of the check_swap code which I found problematic.
Therefore I tried to simplify the code and make it more readable
and less redundant.

I am kinda sorry about this, but sincerely hope my changes can
be helpful.
2021-09-25 23:24:45 +02:00
rincewind
66e2453759 Introduce new perfdata functions and stuff for using (u)int64_t 2021-09-25 23:24:34 +02:00
Jonny007-MKD
cfc43a3275 Improvements suggested by tobiaswiese 2021-09-02 09:56:39 +02:00
Jonny007-MKD
2056c58531 check_dns: Fix memory leak 2021-09-02 09:56:39 +02:00
Jonny007-MKD
70f55ca9db check_dns: add --expect-nxdomain 2021-09-02 09:56:39 +02:00
Sven Nierlein
9fa291d991
Merge pull request #1704 from RincewindsHat/use_openbsd_netcat_for_debian_tests
Use netcat-openbsd for debian explicitely
2021-09-01 11:04:15 +02:00
rincewind
f29ba217d7 Use netcat-openbsd for debian explicitely 2021-09-01 10:48:32 +02:00
Sven Nierlein
e17c1e9ed9
Merge pull request #1388 from waja/check_proc_consumption_1357
check_disk: Fixing the stuff that is broken on btrfs
2021-08-24 09:05:01 +02:00
Sven Nierlein
f1be271c3c
Merge pull request #1700 from monitoring-plugins/feature_check_curl
Feature check curl
2021-08-10 12:22:49 +02:00
Andreas Baumann
67088216ab Merge branch 'master' into feature_check_curl 2021-07-28 19:17:46 +02:00
Andreas Baumann
de5503063e check_curl: fixed a potential buffer overflow in retir/uri_string 2021-07-25 18:49:06 +02:00
Andreas Baumann
3f5c54c783 check_curl: fixed DNS caching for SSL hostnames (avoid CURLOPT_RESOLVE entry errors) 2021-07-25 18:39:07 +02:00
Sven Nierlein
5a2400cc2a
Merge pull request #1699 from peternewman/patch-1
Re-attach a comment to where it actually belongs
2021-07-22 18:08:09 +02:00
Peter Newman
1fb635d869
Re-attach a comment to where it actually belongs 2021-07-22 13:33:14 +01:00
Sven Nierlein
e72ff30017
Merge pull request #1690 from xFuture603/change_state_from_infinite_redirect_loop
check_http: changed 'STATE_CRITICAL' to 'STATE_WARNING' for infinite loop
2021-07-08 11:31:56 +02:00
Sven Nierlein
ed33dd37e7
Merge pull request #1691 from RincewindsHat/no-host-check-for-check_by_ssh
Let ssh decide if a host is valid, enables usage of ssh .config file
2021-07-05 09:36:17 +02:00
Andreas Baumann
6e696643a5 check_curl: changed to STATE_CRITICAL for infinite loops (-ffollow) 2021-07-04 18:43:42 +02:00
Lorenz Kästle
6e5ee70d07 Let ssh decide if a host is valid, enables usage of ssh .config file 2021-06-25 12:12:48 +02:00
Andreas Baumann
0b6838ffca fix for missing X509_up_ref on old systems with only OpenSSL 1.0 2021-06-24 17:08:20 +00:00
Daniel Uhlmann
a1af8be978 changed 'STATE_CRITICAL' to 'STATE_WARNING' for infinite loop 2021-06-24 11:37:14 +02:00
Andreas Baumann
20e9451fad added option --enable-automatic-decompression 2021-06-24 11:02:28 +02:00
Sven Nierlein
b02bcd4870
Merge pull request #1689 from monitoring-plugins/feature_check_curl
fixes check_curl: "CRITICAL - Cannot retrieve certificate subject."
2021-05-27 17:59:35 +02:00