Commit graph

2658 commits

Author SHA1 Message Date
Anton Lofgren
4e0da0216d check_snmp: Handle SNMPv3 noAuthNoPriv properly
The SNMPv3 noAuthNoPriv security level, somewhat unintuitively, requires
a security name to be passed along together with the request. Check_snmp
previously did not do this, causing snmpget to throw an error:

"External command error: No log handling enabled - turning on stderr
logging
snmpget: No securityName specified"

This patch fixes the issue by always providing the security name when
noAuthNoPriv is specified.

See also:
https:://bugs.op5.com/view.php?id=8385.

Signed-off-by: Anton Lofgren <alofgren@op5.com>
2014-04-24 08:49:54 +02:00
Sam Kottler
c887890e9f Remove the suggestion to run check_apt with --verbose since it doesn't do anything 2014-04-04 16:55:59 +06:00
Holger Weiss
0457c4b2f1 Add Sam Kottler to the list of AUTHORS 2014-04-04 10:28:50 +02:00
Jan Wagner
a271ad24f4 check_nt: add UPTIME to perfdata [sf#3434647] 2014-04-04 12:42:59 +06:00
awiddersheim
70314c62fc Fix check_mysql.c client options from file
If you don't specify a group or a file to read data from the plugin tries to read from several files that don't exist and no groups.
2014-04-03 23:41:37 +06:00
Sam Kottler
97b0780376 Update the last remaining instance of the old FSF address 2014-03-20 10:01:31 +01:00
Holger Weiss
3f4419c07e check_pgsql: Add missing newline to --help output 2014-03-13 12:52:48 +01:00
Davide Madrisan
546e15a8e8 build - avoid deprecated INCLUDES
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-03-09 11:02:18 +01:00
Holger Weiss
0c5b362c30 Disable Perl's "taint" checks
Perl's "taint" checks don't like `use lib "$FindBin::Bin"'.

Cf. http://www.perlmonks.org/?node_id=585299
2014-02-28 22:05:18 +01:00
Jan Wagner
694307cdde travis-ci: remove mawk build-deps 2014-02-28 15:35:41 +01:00
Holger Weiss
0d87a626d5 configure.ac: Remove unused AC_PATH_PROG() calls 2014-02-28 13:31:15 +01:00
Holger Weiss
c08d6a429b Replace "plugins-scripts/subst.in" foo
Remove the buggy and complex awk(1) magic in "plugins-scripts/subst.in"
in favor of simple sed(1) substitutions.

The plugins in the "plugins-scripts" directory now always use the PATH
specified via "./configure --trusted-path", or the default PATH
hard-coded in "configure.ac".

Fixes #1242.
2014-02-28 13:28:33 +01:00
Holger Weiss
e260efb256 Merge remote-tracking branch 'awiddersheim/fix_trusted_path'
* awiddersheim/fix_trusted_path:
  Fix trusted path

Conflicts:
	plugins-scripts/check_ntp.pl
	plugins-scripts/subst.in

Closes #1212.
2014-02-28 13:22:34 +01:00
Jan Wagner
5f77fa7510 travis-ci: Remove gawk to build against mawk 2014-02-27 22:23:44 +01:00
Evgeni Golov
2d49468a25 subst.in: remove the led() function
It was only used to replace the 'use lib utils.pm' with the proper
libexec dir, which is now solved by using Perl's FinBin.

Closes #1241
2014-02-27 20:58:49 +01:00
Evgeni Golov
9408c975fe utils.pm: use FindBin instead of awk to find the path to
'use lib utils.pm' is not valid Perl syntax:
 Bareword "utils" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52.
 Bareword "pm" not allowed while "strict subs" in use at plugins-scripts/check_ircd.pl line 52.

This makes it impossible to use the plugins directly from the git tree,
e.g. while hacking on them.

Using FindBin::Bin as the library path allows that, while preserving
the original behaviour of adding the libexec path when the plugin is
properly installed.
2014-02-27 20:56:50 +01:00
Jan Wagner
dd1848ef30 NEWS: Adding check_mailq auto detection 2014-02-27 20:51:17 +01:00
Evgeni Golov
1988e49fce check_mailq: add $mailq to check output, so it is easily visible what was autodetected
Closes: #1242
2014-02-27 20:44:58 +01:00
Evgeni Golov
f14ae4b99a check_mailq: document autodetection in the usage output 2014-02-27 20:33:35 +01:00
Evgeni Golov
be9aa5aba2 check_mailq: try to autodetect which mailq implementation we are using
This is done by looking at some common directories and files each
MTA installs on the system. If no known file is found, the old default
sendmail is used. Of course this still can be overridden by -M.
2014-02-27 20:33:14 +01:00
Holger Weiss
19c493e54c configure.ac: Support --disable-maintainer-mode
This

| allows you to choose whether the so called "rebuild rules" should be
| enabled or disabled.  With AM_MAINTAINER_MODE([enable]), they are
| enabled by default, otherwise they are disabled by default.  In the
| latter case, if you have AM_MAINTAINER_MODE in configure.ac, and run
| `./configure && make', then make will *never* attempt to rebuild
| configure, Makefile.ins, Lex or Yacc outputs, etc.  I.e., this
| disables build rules for files that are usually distributed and that
| users should normally not have to update.
|
| The user can override the default setting by passing either
| `--enable-maintainer-mode' or `--disable-maintainer-mode' to
| configure.
|
| People use AM_MAINTAINER_MODE either because they do not want their
| users (or themselves) annoyed by timestamps lossage (see CVS), or
| because they simply can't stand the rebuild rules and prefer running
| maintainer tools explicitly.

[ https://www.gnu.org/software/automake/manual/automake.html ]
2014-02-21 16:19:22 +01:00
Holger Weiss
acca8c0a71 Rename configure.in to configure.ac
The old name has been deprecated years ago.  The Autoconf documentation
says:

| Previous versions of Autoconf promoted the name configure.in, which is
| somewhat ambiguous (the tool needed to process this file is not
| described by its extension), and introduces a slight confusion with
| config.h.in and so on (for which `.in' means "to be processed by
| configure").  Using configure.ac is now preferred.

[ https://www.gnu.org/software/autoconf/manual/autoconf.html ]
2014-02-21 16:12:12 +01:00
Davide Madrisan
ac438ccfe5 check_swap: Fix the plugin name that appears in the comment
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-02-20 15:52:56 +01:00
Holger Weiss
f8be073e9a travis-ci: Don't use Clang
Currently, there doesn't seem to be a way to configure Travis CI to omit
the Clang build on the coverity/* branches.

See: https://github.com/travis-ci/travis-ci/issues/1975
2014-02-20 12:49:29 +01:00
Holger Weiss
ca3f8c3f43 travis-ci: Adjust "branch_pattern"
Modify the "branch_pattern" for the Coverity add-on so that it also
matches "coverity/master" and "coverity/maint".
2014-02-20 12:30:36 +01:00
Sven Nierlein
385340a4ef check_procs test fails if there is no user with uid 501
thats because check_procs verifys there is a user for a
given uid filter. So even we use sample data for this
test, we still need a real user.

Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-02-18 16:20:11 +01:00
Jan Wagner
4f5e20187f check_ssh: Reverting a387120
This seems to result into more problems in the wild then before 'fixing' it

Closes Debian #739254
Reopen Debian #734811
2014-02-17 12:18:17 +01:00
Jan Wagner
ef46dabffa travis-ci: remove heading dash accordingly docs 2014-02-16 21:25:55 +01:00
Holger Weiss
2698b4768d travis-ci: Cosmetic changes
Use two spaces for indentation.
2014-02-16 20:13:15 +01:00
Holger Weiss
79efa279f6 travis-ci: Enable email notifications
Have Travis CI send build failure and recovery notifications to the
team@ list.
2014-02-16 20:12:35 +01:00
Jan Wagner
182430de46 travis-ci: Add configuration for Coverity Scan
Run Coverity Scan builds on Travis CI, but only when pushing into the
"coverity" branch.
2014-02-16 20:00:55 +01:00
Jan Wagner
b120c75713 travis-ci: Make use of before_script target 2014-02-16 15:47:53 +01:00
Jan Wagner
34b0982087 travis-ci: Update package list in before_install
[skip ci]
2014-02-16 12:30:21 +01:00
Jan Wagner
2947e0084f travis-ci: Move all into install target
just keeped 'make' in script target
2014-02-16 11:24:36 +01:00
Jan Wagner
97867c6137 travis-ci: Add clang and gcc as compiler 2014-02-16 11:22:33 +01:00
Jan Wagner
dedc7289da travis-ci: Enable IRC notification 2014-02-15 20:59:09 +01:00
Jan Wagner
0966dcc6f7 Add travis config 2014-02-14 16:52:25 +01:00
Thomas Guyot-Sionnest
d2744118dc Merge pull request #1234 from skottler/plugin_makefile_whitespace
Remove unnecessary whitespace in Makefile.am
2014-02-07 09:18:06 -05:00
Sam Kottler
54bce08d52 Remove unnecessary whitespace in Makefile.am 2014-02-07 13:53:33 +01:00
Thomas Guyot-Sionnest
f3078c33f6 Add perfdata in check_proc output tests 2014-01-31 13:00:53 -05:00
Thomas Guyot-Sionnest
f45adede7d Fix snmpd tests 2014-01-31 12:30:11 -05:00
Thomas Guyot-Sionnest
1dd0e4c963 Enable tests in tests/ subdirs 2014-01-31 08:54:44 -05:00
Stephane Lapie
35811848da Handle negative values properly with check_snmp
check_snmp becomes capable of evaluating negative values properly,
but it might be returning CRITICALs where it used to return OK and was ignored,
if a negative value turns out to actually be a valid value.
If negative values are valid, this can be worked around,
by adding "~:" to the warning/critical threshold : 100 -> ~:100
2014-01-31 00:49:18 -05:00
Thomas Guyot-Sionnest
c4e3cd6efd Add tests for negative thresholds in check_snmp
Next commit will work on fixing these!
2014-01-31 00:48:49 -05:00
Thomas Guyot-Sionnest
bc92b93920 Add tests for negative thresholds in test_utils 2014-01-31 00:04:23 -05:00
Holger Weiss
4a2a725465 check_dig: Declare variable at the top
C89 doesn't allow variable declarations to be intermingled with code.
2014-01-30 19:51:46 +01:00
Jan Wagner
e33ecc84c7 check_dig: stick with integer devision
This change saves us from having to link check_dig against "libm"
2014-01-30 11:28:19 +01:00
Jan Wagner
2aa6ce2844 check_dig: timeout_interval is a global variable
which is already set to 10 seconds
2014-01-30 11:28:09 +01:00
Jan Wagner
df53473d03 check_dig: patch to make dig honor -t option
When a timeout value is specified with the -t option, dig will sometimes
timeout before the timer is actually reached.

The problem occurs because the check_dig plugin does not pass the specified
timeout value to dig, leaving dig to timeout with it's default value which
seems to be around 10-15seconds.

To reproduce:
time ./check_dig -H 127.0.0.2 -l www.google.com -t 30

It will not run for 30secs, which is the expected behaviour.

The following will work, because the timeout is less than the default dig
timeout, so the plugin cancels the dig command:
time ./check_dig -H 127.0.0.2 -l www.google.com -t 2

This fix passes the timeout value to dig, and sets the number of retries which tends to vary from system to system by default.

Closes #1168
2014-01-30 11:07:22 +01:00
Thomas Guyot-Sionnest
7310030ae7 Add tests for mp_translate_state() 2014-01-29 22:03:04 -05:00