22250 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Pavel Zeman	d552098d62	Merge master into debug/binary-timeout	2026-04-10 10:01:55 +00:00
Pavel Zeman	78b2980ed5	fix: remove duplicate allow-failure input in server test template (#36004) ... The allow-failure input was defined twice in the workflow_call inputs, causing GitHub Actions to reject the workflow with 0 jobs on master push. Duplicate was introduced in #35743 merge. Release Note NONE Co-authored-by: Claude <claude@anthropic.com>	2026-04-09 15:47:20 -04:00
Pavel Zeman	860df69621	ci: re-enable server test coverage with 4-shard parallelism (#35743) ... * ci: re-enable server test coverage with 4-shard parallelism The test-coverage job was disabled due to OOM failures when running all tests with coverage instrumentation in a single process. Re-enable it by distributing the workload across 4 parallel runners using the shard infrastructure from the sharding PRs. Changes: - Replace disabled single-runner test-coverage with 4-shard matrix - Add merge-coverage job to combine per-shard cover.out files - Upload merged coverage to Codecov with server flag - Skip per-shard Codecov upload when sharding is active - Add coverage profile merging to run-shard-tests.sh for multi-run shards - Restore original condition: skip coverage on release branch PRs - Keep fullyparallel=true (fast within each shard) - Keep continue-on-error=true (coverage never blocks PRs) Co-authored-by: Claude <claude@anthropic.com> * fix: disable fullyparallel for coverage shards t.Parallel() + t.Setenv() panics kill entire test binaries under fullyparallel mode. With 4-shard splitting, serial execution within each shard should still be fast enough (~15 min). We can re-enable fullyparallel once the incompatible tests are fixed. Co-authored-by: Claude <claude@anthropic.com> * fix: add checkout to coverage merge job for Codecov file mapping Codecov needs the source tree to map coverage data to files. Without checkout, the upload succeeds but reports 0% coverage because it can't associate cover.out lines with source files. Co-authored-by: Claude <claude@anthropic.com> * ci: add codecov.yml and retain merged coverage artifact Add codecov.yml with: - Project coverage: track against parent commit, 1% threshold, advisory - Patch coverage: 50% target for new code, advisory (warns, doesn't block) - Ignore generated code (retrylayer, timerlayer, serial_gen, mocks, storetest, plugintest, searchtest) — these inflate the denominator from 146K to 100K statements, rebasing coverage from 36% to 53% - PR comments on coverage changes with condensed layout Save merged cover.out as artifact with 30-day retention (~3.5MB/run). 90-day retention was considered (~6.3GB total vs ~2.1GB at 30 days) but deferred to keep storage costs low. #### Release Note ```release-note NONE ``` Co-authored-by: Claude <claude@anthropic.com> * ci: add codecov.yml to exclude generated code and enable PR comments (#35748) * ci: add codecov.yml to exclude generated code and enable PR comments Add Codecov configuration to improve coverage signal quality: - Exclude generated code from coverage denominator: - store/retrylayer (~10k stmts, auto-generated retry wrappers) - store/timerlayer (~14k lines, auto-generated timing wrappers) - *_serial_gen.go (serialization codegen) - **/mocks (mockery-generated mocks) - Exclude test infrastructure: - store/storetest (~63k lines, test helpers not production code) - plugin/plugintest (plugin test helpers) - Exclude thin wrappers: - model/client4.go (~4k stmts, HTTP client methods tested via integration) - Enable PR comments with condensed layout - Set project threshold at 0.5% drop tolerance - Set patch target at 60% for new/changed lines This rebases the effective coverage metric from ~33.8% to ~43% by removing ~50k non-production statements from the denominator, giving a more accurate picture of actual test coverage. Co-authored-by: Claude <claude@anthropic.com> * Update codecov.yml --------- Co-authored-by: Claude <claude@anthropic.com> Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> * fix: bump upload-artifact to v7 and add client4.go to codecov ignore - Align upload-artifact pin with the rest of the workflow (v4 → v7) - Add model/client4.go to codecov.yml ignore list as documented in PR description Co-authored-by: Claude <claude@anthropic.com> * fix(ci): address Jesse review feedback on coverage sharding - Remove client4.go from codecov ignore list (coverage is meaningful) - Remove historical comment block above test-coverage job - Set fullyparallel back to true (safe per-shard since each runs different packages; parallel test fixes tracked in #35751) - Replace merge-coverage job with per-shard Codecov uploads using flags parameter; configure after_n_builds: 4 so Codecov waits for all shards before reporting status - Add clarifying comment in run-shard-tests.sh explaining intra-shard coverage merge (multiple gotestsum runs) vs cross-shard merge (handled natively by Codecov) - Simplify codecov.yml: remove verbose comments, use informational status checks, streamlined ignore list Co-authored-by: Claude <claude@anthropic.com> * fix(ci): set fullyparallel back to false for coverage shards Coverage shards 1-3 failed with hundreds of test failures because fullyparallel: true causes panics and races in tests that use t.Setenv, os.Setenv, and os.Chdir without parallel-safe alternatives. The parallel-safety fixes are tracked in a separate PR chain: - #35746: t.Setenv → test hooks - #35749: os.Setenv → parallel-safe alternatives - #35750: os.Chdir → t.Chdir - #35751: flip fullyparallel: true (final step) Once that chain merges, fullyparallel can be enabled for coverage too. Co-authored-by: Claude <claude@anthropic.com> * fix(ci): split fullyparallel and allow-failure into separate inputs Previously fullyparallel controlled both parallel test execution AND continue-on-error, meaning disabling parallelism also made coverage failures blocking. Split into two independent inputs: - fullyparallel: controls ENABLE_FULLY_PARALLEL_TESTS (test execution) - allow-failure: controls continue-on-error (advisory vs blocking) Coverage shards now run with fullyparallel: true (Claudio's original approach) and allow-failure: true (failures don't block PRs until parallel-safety fixes land in #35746 → #35751). Co-authored-by: Claude <claude@anthropic.com> * ci: use per-flag after_n_builds for server and webapp coverage Replace the global after_n_builds: 2 with per-flag values: - server: after_n_builds: 4 (one per shard) - webapp: after_n_builds: 1 (single merged upload) Tag the webapp Codecov upload with flags: webapp so each flag independently waits for its expected upload count. This prevents Codecov from firing notifications with incomplete data when the webapp upload arrives before all server shards complete. Addresses review feedback from @esarafianou. Co-authored-by: Claude <claude@anthropic.com> * fix: consolidate codecov config into .github/codecov.yml Move all codecov configuration into the existing .github/codecov.yml instead of introducing a duplicate file at the repo root. Merges improvements from the root file (broader ignore list, informational statuses, require_ci_to_pass: false) while preserving the webapp flag from the original config. Updates after_n_builds to 5 (4 server + 1 webapp). Co-authored-by: Claude <claude@anthropic.com> --------- Co-authored-by: Claude <claude@anthropic.com> Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>	2026-04-09 15:27:50 -04:00
Carlos Garcia	2be57a7ec0	adds team member data sanitizing (#35562) ... * adds team member data sanitizing * assert using require * adds data sanitizing to team members for user endpoint * team admin data visibility now tests with different user	2026-04-09 16:12:15 +02:00
Scott Bishel	f441b34dee	Fix interactive dialog bugs: dynamic select lookups, radio values, field refresh (#35640) ... * Fix interactive dialog bugs: dynamic select lookups, radio values, and field refresh - Cache sanitized fields in AppsForm to preserve object identity across renders, preventing AsyncSelect from remounting and re-triggering dynamic select lookups on every keystroke in any field - Normalize radio field default values to plain strings in getDefaultValue() so the value shape is consistent with what RadioSetting.onChange returns (e.target.value). Accept both string and {label, value} object shapes downstream for backwards compatibility. - Fix radio field [object Object] in submission by extracting .value from AppSelectOption objects in convertAppFormValuesToDialogSubmission - Include selected_field in refresh submission so plugins know which field triggered the refresh. Use a shallow copy of accumulatedValues to avoid permanently contaminating the accumulated state. - Send empty string for cleared select fields in refresh submissions. Previously, extractPrimitiveValues skipped null values and the spread merge never overwrote stale accumulated keys.	2026-04-09 07:50:36 -06:00
Vicktor	6878d09547	refactor(brand_image_setting): migrate BrandImageSetting to a function component (#34536) ... * refactor(brand_image_setting): migrate to function component * test(brand_image_setting): update tests Migrated tests to React Testing Library. * refactor(brand_image_setting): wrap functions with useCallback * test(brand_image_setting): use nock to mock fetch api * test(brand_image_setting): use findby query instead of getby * test(brand_image_setting): remove unnecessary scope assertion * chore(brand_image_setting): split useEffect into two Also extracted the handleSave function and wrapped it in useCallback. * test(brand_image_setting): add e2e test for deleting brand image * test(brand_image_setting): use destructured functions * chore: delete unnecessary comment * Revert "test(brand_image_setting): use destructured functions" This reverts commit 71dc6628ed. * Fix bad merge * Fully revert changes to test from merge --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>	2026-04-09 09:16:23 -04:00
Pavel Zeman	cf102afc17	ci: disable fullyparallel for binary parameters job (#35995) ... Binary parameters tests run unsharded on a single runner. With fullyparallel enabled, all ~755 api4 tests run concurrently, causing resource exhaustion (too many server instances, WebSocket hubs, and DB connections). The test binary gets killed after 11 minutes with no individual test failures — just overwhelmed resources. Disabling fullyparallel for this specific job lets binary parameters tests pass while we evaluate moving them to a nightly/weekly schedule. Co-authored-by: Claude <claude@anthropic.com>	2026-04-09 05:44:50 -04:00
Pavel Zeman	d1ca297721	Revert "Strip remote_id field from user patch API requests (#35910)" (#35996) ... This reverts commit fc9d3be368 which introduced a CI regression.	2026-04-09 05:06:42 -04:00
Rajat Dabade	1c093d3760	Upgraded board prepackaged version to v9.2.4 (#35969)	2026-04-09 13:20:50 +05:30
Harshil Sharma	010aad6308	Fixed a bug where signup link showed up when signup was disabled (#35769) ... * Fixed a bug where signup link showed up when signup was disabled * Removed unused component * fixed test name * CI * fixed a test * fixed a commit --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-09 10:21:08 +05:30
JG Heithcock	fc9d3be368	Strip remote_id field from user patch API requests (#35910) ... * Strip remote_id from user patch API requests * Ignore remote_id in user update API endpoints Add SetUserRemoteID test helper in testlib to set remote_id via direct SQL, bypassing the now-protected store Update method. Update existing tests in app and api4 packages to use the new helper. --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-08 21:47:57 -07:00
Pavel Zeman	b109e39127	debug: isolate binary hang to channels/api4 with sequential execution ... - Remove --rerun-fails (avoids retrying hung tests) - Target only channels/api4 package - Add -count=1 to disable test caching - Add -parallel=1 to run tests sequentially - Keep -timeout=10m for goroutine dump if hang persists - Keep -v and standard-verbose for real-time output If the hang disappears with -parallel=1, it confirms parallel contention specific to binary mode. Co-authored-by: Claude <claude@anthropic.com>	2026-04-09 02:50:28 +00:00
Pavel Zeman	13fc03eca4	debug: use standard-verbose format for gotestsum to prevent output buffering ... gotestsum's default 'testname' format buffers output, hiding which tests are currently running. standard-verbose streams go test -v output in real time, so we can see === RUN lines for hanging tests. Co-authored-by: Claude <claude@anthropic.com>	2026-04-09 02:03:38 +00:00
Pavel Zeman	73aa78a925	debug: lower test timeout to 5m and enable verbose for binary mode hang diagnosis ... Temporary branch to capture goroutine dump when binary parameters test hangs under fullyparallel mode. Co-authored-by: Claude <claude@anthropic.com>	2026-04-09 01:48:14 +00:00
Pavel Zeman	6fdef8c9cc	ci: enable fullyparallel mode for server tests (#35816) ... * ci: enable fullyparallel mode for server tests Replace os.Setenv, os.Chdir, and global state mutations with parallel-safe alternatives (t.Setenv, t.Chdir, test hooks) across 37 files. Refactor GetLogRootPath and MM_INSTALL_TYPE to use package-level test hooks instead of environment variables. This enables gotestsum --fullparallel, allowing all test packages to run with maximum parallelism within each shard. Co-authored-by: Claude <claude@anthropic.com> * ci: split fullyparallel from continue-on-error in workflow template - Add new boolean input 'allow-failure' separate from 'fullyparallel' - Change continue-on-error to use allow-failure instead of fullyparallel - Update server-ci.yml to pass allow-failure: true for test coverage job - Allows independent control of parallel execution and failure tolerance Co-authored-by: Claude <claude@anthropic.com> * fix: protect TestOverrideLogRootPath with sync.Mutex for parallel tests - Replace global var TestOverrideLogRootPath with mutex-protected functions - Add SetTestOverrideLogRootPath() and getTestOverrideLogRootPath() functions - Update GetLogRootPath() to use thread-safe getter - Update all test files to use SetTestOverrideLogRootPath() with t.Cleanup() - Fixes race condition when running tests with t.Parallel() Co-authored-by: Claude <claude@anthropic.com> * fix: configure audit settings before server setup in tests - Move ExperimentalAuditSettings from UpdateConfig() to config defaults - Pass audit config via app.Config() option in SetupWithServerOptions() - Fixes audit test setup ordering to configure BEFORE server initialization - Resolves CodeRabbit's audit config timing issue in api4 tests Co-authored-by: Claude <claude@anthropic.com> * fix: implement SetTestOverrideLogRootPath mutex in logger.go The previous commit updated test callers to use SetTestOverrideLogRootPath() but didn't actually create the function in config/logger.go, causing build failures across all CI shards. This commit: - Replaces the exported var TestOverrideLogRootPath with mutex-protected unexported state (testOverrideLogRootPath + testOverrideLogRootMu) - Adds exported SetTestOverrideLogRootPath() setter - Adds unexported getTestOverrideLogRootPath() getter - Updates GetLogRootPath() to use the thread-safe getter - Fixes log_test.go callers that were missed in the previous commit Co-authored-by: Claude <claude@anthropic.com> * fix(test): use SetupConfig for access_control feature flag registration InitAccessControlPolicy() checks FeatureFlags.AttributeBasedAccessControl at route registration time during server startup. Setting the flag via UpdateConfig after Setup() is too late — routes are never registered and API calls return 404. Use SetupConfig() to pass the feature flag in the initial config before server startup, ensuring routes are properly registered. Co-authored-by: Claude <claude@anthropic.com> * fix(test): restore BurnOnRead flag state in TestRevealPost subtest The 'feature not enabled' subtest disables BurnOnRead without restoring it via t.Cleanup. Subsequent subtests inherit the disabled state, which can cause 501 errors when they expect the feature to be available. Add t.Cleanup to restore FeatureFlags.BurnOnRead = true after the subtest completes. Co-authored-by: Claude <claude@anthropic.com> * fix(test): restore EnableSharedChannelsMemberSync flag via t.Cleanup The test disables EnableSharedChannelsMemberSync without restoring it. If the subtest exits early (e.g., require failure), later sibling subtests inherit a disabled flag and become flaky. Add t.Cleanup to restore the flag after the subtest completes. Co-authored-by: Claude <claude@anthropic.com> * Fix test parallelism: use instance-scoped overrides and init-time audit config Replace package-level test globals (TestOverrideInstallType, SetTestOverrideLogRootPath) with fields on PlatformService so each test gets its own instance without process-wide mutation. Fix three audit tests (TestUserLoginAudit, TestLogoutAuditAuthStatus, TestUpdatePasswordAudit) that configured the audit logger after server init — the audit logger only reads config at startup, so pass audit settings via app.Config() at init time instead. Also revert the Go 1.24.13 downgrade and bump mattermost-govet to v2.0.2 for Go 1.25.8 compatibility. * Fix audit unit tests * Fix MMCLOUDURL unit tests * Fixed unit tests using MM_NOTIFY_ADMIN_COOL_OFF_DAYS * Make app migrations idempotent for parallel test safety Change System().Save() to System().SaveOrUpdate() in all migration completion markers. When two parallel tests share a database pool entry, both may race through the check-then-insert migration pattern. Save() causes a duplicate key fatal crash; SaveOrUpdate() makes the second write a harmless no-op. * test: address review feedback on fullyparallel PR - Use SetLogRootPathOverride() setter instead of direct field access in platform/support_packet_test.go and platform/log_test.go (pvev) - Restore TestGetLogRootPath in config/logger_test.go to keep MM_LOG_PATH env var coverage; test uses t.Setenv so it runs serially which is fine (pvev) - Fix misleading comment in config_test.go: code uses t.Setenv, not os.Setenv (jgheithcock) Co-authored-by: Claude <claude@anthropic.com> * fix: add missing os import in post_test.go The os import was dropped during a merge conflict resolution while burn-on-read shared channel tests from master still use os.Setenv. Co-authored-by: Claude <claude@anthropic.com> --------- Co-authored-by: Claude <claude@anthropic.com> Co-authored-by: wiggin77 <wiggin77@warpmail.net> Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-08 20:48:36 -04:00
Jesse Hallam	71ca373de7	Generate instead of hard-coding test passwords, enforce new minimum for FIPS, shard CI, fix FIPS builds (#35905) ... * Replace hardcoded test passwords with model.NewTestPassword() Add model.NewTestPassword() utility that generates 14+ character passwords meeting complexity requirements for FIPS compliance. Replace all short hardcoded test passwords across the test suite with calls to this function. * Enforce FIPS compliance for passwords and HMAC keys FIPS OpenSSL requires HMAC keys to be at least 14 bytes. PBKDF2 uses the password as the HMAC key internally, so short passwords cause PKCS5_PBKDF2_HMAC to fail. - Add FIPSEnabled and PasswordFIPSMinimumLength build-tag constants - Raise the password minimum length floor to 14 when compiled with requirefips, applied in SetDefaults only when unset and validated independently in IsValid - Return ErrMismatchedHashAndPassword for too-short passwords in PBKDF2 CompareHashAndPassword rather than a cryptic OpenSSL error - Validate atmos/camo HMAC key length under FIPS and lengthen test keys accordingly - Adjust password validation tests to use PasswordFIPSMinimumLength so they work under both FIPS and non-FIPS builds * CI: shard FIPS test suite and extract merge template Run FIPS tests on PRs that touch go.mod or have 'fips' in the branch name. Shard FIPS tests across 4 runners matching the normal Postgres suite. Extract the test result merge logic into a reusable workflow template to deduplicate the normal and FIPS merge jobs. * more * Fix email test helper to respect FIPS minimum password length * Fix test helpers to respect FIPS minimum password length * Remove unnecessary "disable strict password requirements" blocks from test helpers * Fix CodeRabbit review comments on PR #35905 - Add server-test-merge-template.yml to server-ci.yml pull_request.paths so changes to the reusable merge workflow trigger Server CI validation - Skip merge-postgres-fips-test-results job when test-postgres-normal-fips was skipped, preventing failures due to missing artifacts - Set guest.Password on returned guest in CreateGuestAndClient helper to keep contract consistent with CreateUserWithClient - Use shared LowercaseLetters/UppercaseLetters/NUMBERS/PasswordFIPSMinimumLength constants in NewTestPassword() to avoid drift if FIPS floor changes https://claude.ai/code/session_01HmE9QkZM3cAoXn2J7XrK2f * Rename FIPS test artifact to match server-ci-report pattern The server-ci-report job searches for artifacts matching "*-test-logs", so rename from postgres-server-test-logs-fips to postgres-server-fips-test-logs to be included in the report. --------- Co-authored-by: Claude <noreply@anthropic.com>	2026-04-08 16:49:43 -03:00
sabril	993c3cb5d2	fix: test analysis override (#35987)	2026-04-09 01:24:08 +08:00
sabril	c303dd8e08	fix: test analysis (#35986)	2026-04-09 00:50:06 +08:00
sabril	fba382d5bd	feat(test analysis): using reusable workflow (#35852) ... * feat(test analysis): using reusable workflow * address comment * pin to main during initial rollout --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-09 00:20:28 +08:00
Harrison Healey	f9b6989824	Remove babel-plugin-typescript-to-proptypes and use of prop-types from web app (#35954) ... * Remove unneeded references to PropTypes in TS code * Add type definition file for SuggestionBox * Fixed type definitions for SuggestionBoxProps and fixed usage of those props in other places * Remove babel-plugin-typescript-to-proptypes * Fix circular type reference and incorrect non-null assertion	2026-04-08 11:48:32 -04:00
Harrison Healey	220cd725cc	MM-66887 Fix results in Invite to Team modal (#35936) ... * Fix a bug in decomposeKorean that caused it to only decompose the first character * MM-66887 Fix Invite To Team modal suggesting users one key press behind * Cherry-pick updates to ime.ts from another branch * And cherry-pick another bit * Remove broken and unnecessary onBlur method from UsersEmailsInput See https://github.com/mattermost/mattermost/pull/35936/changes#r3047500882 for more information	2026-04-08 10:11:24 -04:00
Doug Lauder	5b76fb11a5	MM-67647: Rename shared_channel_manager roles to follow system_ prefix convention (#35944) ... * Rename shared_channel_manager and secure_connection_manager roles to use system_ prefix The new roles added in PR #35354 broke the naming convention that all system-level roles stored in Users.Roles are prefixed with "system_". Client-side code (role.includes('system')) and server-side code (explicit switch cases in applyMultiRoleFilters) relied on this convention, causing users assigned to these roles to not appear in the System Console. Also adds both roles to the applyMultiRoleFilters switch statement in user_store.go, which was missing them entirely.	2026-04-08 08:01:33 -04:00
Jesse Hallam	12aedfdcae	Simplify Apple Silicon docker-compose support (#35975)	2026-04-08 07:59:04 -04:00
Andre Vasconcelos	9a412c535f	MM-67946 Added entity decoding to message attachments (#35667) ... * MM-67945 Added entity decoding to message attachments - Separated markdown utility to decode special characters with testing suite - Applied it to remove_markdown utility and used it in * Ensuring escaping uses RegExp.escape * Removing footer decoding tests * Added E2E tests for message attachment decoding * Fixing linter errors	2026-04-08 13:36:15 +03:00
Dylan Haussermann	9075204f5f	Add demo plugin E2E tests for hook toggle and crash recovery (#35337) ... * Add demo plugin E2E tests for hook toggle and crash recovery - Add selectSlashCommandFromAutocomplete() to post_create lib component - Extract shared setupDemoPlugin() helper to reduce duplication - Rename crash.spec.ts to plugin_crash.spec.ts for clearer CI output - Add demo_plugin_hook_toggle.spec.ts: verifies /demo_plugin true/false slash command enables/disables hooks, confirmed via sidebar indicator and ChannelHasBeenCreated event presence/absence * Fix lint errors in demo plugin helpers and crash spec * Fix prettier formatting in post_create.ts --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-08 14:40:22 +08:00
Doug Lauder	7dccd6eba6	MM-68199: Fix shared channel membership sync error for local users (#35938) ... When a channel is shared between two instances, the sender was including membership changes for users that originated from the target remote. On the receiver those users are local (RemoteID=""), causing the RemoteID check to fail with "remoteID mismatch", creating log noise. Fix both sides: sender now skips users belonging to the target remote, and receiver silently skips local users instead of logging an error.	2026-04-07 15:59:18 -04:00
Arya Khochare	cf40f44023	Markdown message preview fixed (#34942) ... * markdown message preview fixed * message preview overflow fix * fix show_more test * restore package-lock.json * pull package-lock from master * package-lock line break * Fix missing newline at end of package-lock.json * Update test snapshots --------- Co-authored-by: David Krauser <david@krauser.org> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: David Krauser <david@kruser.org>	2026-04-07 18:41:03 +00:00
JG Heithcock	8eb9863215	Redact password reset token from audit log (#35911) ... Log only a 5-character prefix of the password reset token in audit entries instead of the full 64-character bearer credential (CWE-532). Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-07 10:55:16 -07:00
Doug Lauder	540ccc599b	MM-68179: Run sendLoop workers on all HA nodes (#35909) ... * MM-68179: Run sendLoop workers on all HA nodes In HA clusters, sendLoop worker goroutines only ran on the leader node. When an API request to send a channel invite landed on a non-leader node, SendMsg enqueued the task to a local in-memory channel but no goroutine consumed it, silently losing the message. Fix by starting sendLoop workers in Start() on all nodes, independent of the leader-only ping lifecycle. - Separate sendLoop lifecycle (Start/Shutdown) from ping lifecycle (pingStart/pingStop on leader change) - Rename resume/pause to pingStart/pingStop for clarity - Change Active() to mean "service started" via atomic.Bool - Remove SetActive (no longer needed; tests use Start()) * address review comment * Added idempotency guard to Start() * Start() and Shutdown(): CompareAndSwap instead of Load/Store — eliminates races where concurrent calls could both proceed. Only the winner of the CAS executes; the loser returns nil immediately. Ping test: replaced time.Sleep with assert.Never/assert.Eventually — no more brittle fixed sleeps. Uses assert.Never to verify no pings fire on non-leader, and assert.Eventually to verify pings stop after losing leadership (snapshot-then-compare pattern). * make unit tests parallel capable --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-07 18:49:54 +02:00
Harrison Healey	83819e3db4	Specify target Safari version as a string (#35955) ... This stops a warning from Babel which points out that passing a minor version as a number will have issues because 16.2 is identical to 16.20.	2026-04-07 10:36:12 -04:00
Just Nev	e2e7aed678	Add prepackaged version of github plugin v2.7. (#35968) ... Co-authored-by: Nevyana Angelova <nevyangelova@192.168.100.47>	2026-04-07 17:26:53 +03:00
Andre Vasconcelos	faa7d75b4e	Improved processing of attachments (#35854)	2026-04-07 13:25:38 +03:00
Eva Sarafianou	252eb9661d	Update docs-impact workflow to keep stale comment instead of deleting (#35940) ... * Update docs-impact workflow to keep stale comment instead of deleting When a re-run of the docs impact analysis determines that documentation updates are no longer needed, the previous bot comment was deleted while the Docs/Needed label was kept. This left the label without context. Instead of deleting the comment, update it to explain that a previous analysis had flagged the PR but the latest run found no docs impact. This preserves the audit trail and gives maintainers context to decide whether to remove the label. Made-with: Cursor * Update .github/workflows/docs-impact-review.yml Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>	2026-04-07 13:20:03 +03:00
yasser khan	087b20d81c	E2E | Fix mock server response for translations (#35929) ... * fix mock server response for translations --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-07 13:35:41 +05:30
unified-ci-app[bot]	6662021dd5	Update latest minor version to 11.7.0 (#35964) ... Co-authored-by: unified-ci-app[bot] <121569378+unified-ci-app[bot]@users.noreply.github.com>	2026-04-07 09:34:34 +03:00
sabril	1c26ab9464	test(enzyme migration): final bulk migration, removed enzyme dependencies and helpers (#35950)	2026-04-07 05:26:20 +00:00
Doug Lauder	e694e86d63	MM-68204: Use multi-level logging for shared channel and remote cluster service errors (#35949) ... * Use multi-level logging for shared channel and remote cluster service errors Service-specific log levels (LvlRemoteClusterServiceError, LvlSharedChannelServiceError) were hidden from the main log by default, requiring explicit configuration to see them. Switch all call sites to use LogM with multi-level combos so each log line is attributed to both the standard level (error/warn) and the service-specific level. This surfaces errors in the main log while preserving the ability to isolate them into dedicated files. Each instance was reviewed and either kept as error (DB failures, security issues, config errors, exhausted retries on critical data) or downgraded to warn (transient network failures, remote-side reported errors with retry logic, non-critical data like profile images, reactions, acknowledgements, and status).	2026-04-06 12:17:47 -04:00
Maria A Nunez	f68557c179	Fix Enterprise Advanced upsell messaging for Enterprise licenses (#35933) ... * Fix Enterprise Advanced upsell messaging for Enterprise licenses Update the license settings upsell panel to highlight only Enterprise Advanced-exclusive capabilities so Enterprise customers are not shown features they already have. Made-with: Cursor * Update license settings snapshot for Enterprise upsell Refresh the Enterprise license snapshot so the license settings test matches the new Enterprise Advanced upsell content. Made-with: Cursor --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-06 10:25:13 -04:00
Andre Vasconcelos	ca72686766	MM-67743 Fixing styling issues in Browse Channels modal (#35772) ... * Fixing issues with browser channels modal - Fixing "jumping around" issue on hover due to buttons being rendered dynamically - Added max width for purpose so it doesn't take up the whole screen when long purpose is written * Fixing modal overflow in mobile screen sizes * Simplifying join button layout fix * Fixing styles to be consistent with existing modals	2026-04-06 16:39:16 +03:00
Harshil Sharma	0ca124fa8f	Fixed a bug where attachment-only post would send on enter when when set to only send on ctrl/cmd + enter (#35828)	2026-04-06 08:50:40 +05:30
Harshil Sharma	ad35eba60b	Added nil checks (#35755) ... * Added nil checks * Added test for DM and GM * Updated operation order	2026-04-06 08:47:24 +05:30
sabril	2b45e43e05	MM-66627 (test): VH1-8 + EC Enzyme to RTL bulk migration (#35768) ... * (test): vh1-8+EC enzyme to rtl bulk migration * address comments	2026-04-06 11:04:56 +08:00
JG Heithcock	00b2594648	MM-68156: Fix space key clearing input in invite modal (#35913) ... The invite modal's UsersEmailsInput component treated whitespace as a token delimiter alongside comma and semicolon. This caused typing a space (e.g., between a first and last name) to split and clear the input field. Split the delimiter regex into two: typedInputDelimiter (/[,;]+/) for interactive typing and pasteDelimiter (/[\s,;]+/) for paste operations where whitespace-separated values are expected. Added .trim() to split entries to handle the comma-then-space typing pattern correctly. Updated onboarding invite description text to reflect the new delimiter behavior (comma or semicolon instead of space or comma).	2026-04-05 15:30:58 -07:00
Jesse Hallam	f6d5d9e1bc	[MM-67859] Update license renewal and expiry email branding (#35701)	2026-04-04 20:30:36 -03:00
Bill Gardner	24e38f2bd7	Update server/public to v0.3.0 to avoid import cycle in v0.2.1 (#35946)	2026-04-03 17:20:45 -04:00
Doug Lauder	050e41f7b7	Doc line for new websocket event (#35939)	2026-04-03 14:50:44 -04:00
yy	38e26fbd2d	chore: fix typos in comments (#34960) ... Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-03 13:43:25 +00:00
Doug Lauder	3888a69479	MM-68158: Fix shared channel remote display and notify UI on invite completion (#35908) ... * MM-68158: Fix shared channel remote display and add WebSocket notification Fix getSharedChannelRemotes API handler passing ChannelId instead of RemoteId to GetRemoteCluster, which always failed the lookup. Add RemoteId to SharedChannelRemoteStatus model and store query. Add shared_channel_remote_updated WebSocket event published from the onInvite callback so the UI refreshes its cached remote names when the async invite completes, instead of showing the generic "Shared with trusted organizations" fallback. * Improved unit tests per review comments	2026-04-03 02:06:01 -04:00
Weblate (bot)	5a73fb022d	Translations update from Mattermost Weblate (#35890) ... * Translated using Weblate (Russian) Currently translated at 86.2% (2583 of 2996 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/ru/ * Translated using Weblate (Russian) Currently translated at 86.8% (2603 of 2996 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/ru/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 77.4% (5489 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 77.6% (5503 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Polish) Currently translated at 98.2% (2943 of 2996 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pl/ * Translated using Weblate (Russian) Currently translated at 89.0% (2667 of 2996 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/ru/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 78.0% (5530 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Polish) Currently translated at 97.0% (6877 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/ * Translated using Weblate (Polish) Currently translated at 98.3% (2948 of 2996 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pl/ * Translated using Weblate (Portuguese) Currently translated at 6.9% (207 of 2996 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pt/ * Translated using Weblate (Portuguese) Currently translated at 28.2% (1999 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pt/ * Translated using Weblate (Portuguese) Currently translated at 28.3% (2012 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pt/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 78.2% (5546 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 78.2% (5548 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 78.6% (5577 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 78.8% (5591 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Dutch) Currently translated at 100.0% (2996 of 2996 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/nl/ * Translated using Weblate (Polish) Currently translated at 99.0% (2968 of 2996 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pl/ * Translated using Weblate (Dutch) Currently translated at 100.0% (7087 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nl/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 78.9% (5597 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Polish) Currently translated at 97.2% (6894 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 79.1% (5608 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Swedish) Currently translated at 91.9% (6513 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/sv/ * Translated using Weblate (German) Currently translated at 100.0% (2997 of 2997 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/de/ * Translated using Weblate (Polish) Currently translated at 100.0% (2997 of 2997 strings) Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/pl/ * Translated using Weblate (Polish) Currently translated at 97.4% (6903 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/ * Translated using Weblate (Swedish) Currently translated at 92.0% (6523 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/sv/ * Translated using Weblate (Polish) Currently translated at 97.8% (6932 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/ * Translated using Weblate (Russian) Currently translated at 78.3% (5553 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ru/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 79.2% (5615 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 79.3% (5622 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Russian) Currently translated at 78.6% (5575 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ru/ * Translated using Weblate (Russian) Currently translated at 78.9% (5597 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ru/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 79.3% (5623 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Japanese) Currently translated at 88.8% (6294 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ja/ * Translated using Weblate (Polish) Currently translated at 97.8% (6933 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/ * Translated using Weblate (Japanese) Currently translated at 89.0% (6308 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ja/ * Translated using Weblate (Polish) Currently translated at 98.0% (6947 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/pl/ * Translated using Weblate (Japanese) Currently translated at 89.3% (6329 of 7087 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ja/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: Mattermost/server Translate-URL: https://translate.mattermost.com/projects/mattermost/server/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ * Translated using Weblate (Japanese) Currently translated at 90.0% (6385 of 7089 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ja/ * Translated using Weblate (German) Currently translated at 99.9% (7085 of 7089 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/de/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 79.4% (5629 of 7089 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Norwegian Bokmål) Currently translated at 79.4% (5631 of 7089 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/nb_NO/ * Translated using Weblate (Russian) Currently translated at 79.7% (5656 of 7089 strings) Translation: Mattermost/webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/webapp/ru/ --------- Co-authored-by: Dmitriy Q <krotesk@mail.ru> Co-authored-by: Frank Paul Silye <frankps@gmail.com> Co-authored-by: master7 <marcin.karkosz@rajska.info> Co-authored-by: Manuela Silva <mmsrs@sky.com> Co-authored-by: Tom De Moor <tom@controlaltdieliet.be> Co-authored-by: Kristoffer Grundström <swedishsailfishosuser@tutanota.com> Co-authored-by: jprusch <rs@schaeferbarthold.de> Co-authored-by: Takayuki Maruyama <bis5.wsys@gmail.com>	2026-04-02 22:44:54 +00:00
JG Heithcock	edd637c539	MM-68173 Add write-permission guard to AllowDownloadLogs toggle (#35915) ... The SupportSettings.AllowDownloadLogs toggle in Site Configuration > Customization was missing the RESOURCE_KEYS.SITE.CUSTOMIZATION write-permission guard that all neighboring controls have, allowing read-only admins to toggle it when they shouldn't be able to. Co-authored-by: Mattermost Build <build@mattermost.com>	2026-04-02 13:38:35 -07:00