Commit graph

14243 commits

Author SHA1 Message Date
Bastian Lederer
be1b54a205 Cleanup phpstan-baseline
- Remove all errors that were caused by the monitoring module
  as it is no longer a part if this repo
- Remove baselines of php versions that are no longer supported
- Merge baselines standard, 8.1 and 8.x since seperating them
  is no longer necessary.
- Remove errors that are no longer generated
2026-01-22 12:08:32 +01:00
Bastian Lederer
c11a88cff4 Check if backend is null before passing it to strtolower
Passing null to non nullable parameters of built-in functions is deprecated since PHP-8.1
2026-01-22 10:15:11 +01:00
Bastian Lederer
c0ad8ebfa7 Assign mySQLInitCommand constant directly 2026-01-22 10:15:11 +01:00
Eric Lippmann
90022102d8 tests: Use latest PHPUnit version 2026-01-22 10:15:11 +01:00
Bastian Lederer
f528b5fa36 Replace null as name of an InputElement with an empty string to avoid a TypeError 2026-01-22 10:15:11 +01:00
Bastian Lederer
6c913bd342 Adjust PHP version in version compare for driver specific PDO constants 2025-12-12 11:39:17 +01:00
Bastian Lederer
2555a92b30 Remove unecessary guards for null as array key 2025-12-12 11:39:16 +01:00
Bastian Lederer
1d574681c2 Remove unecessary floor() calls 2025-12-12 11:39:05 +01:00
Bastian Lederer
4edd191808 Set sid_bits_per_character to 5 for PHP < 8.4 2025-12-12 11:38:47 +01:00
Bastian Lederer
2ddc88bb8b Avoid passing null as to array_key_exists() to avoid 8.5+ deprecation warnings 2025-12-12 11:38:22 +01:00
Bastian Lederer
ae4c1fe6ec Replace backtick operator with shell_exec(), because it is deprecated in PHP8.5 2025-12-12 11:38:14 +01:00
Bastian Lederer
bf0758ebea fix codestyle 2025-12-12 11:38:12 +01:00
Bastian Lederer
65595e38d9 Use floor() before casting float to int to avoid PHP 8.5+ warnings for value-altering float to int casts. 2025-12-12 11:37:52 +01:00
Bastian Lederer
e45fa30aa6 Remove explicit assignment of sid_bits_per_character since changing it's value is deprecated in PHP 8.4 2025-12-12 11:37:43 +01:00
Bastian Lederer
b93db92345 Remove calls of ReflectionProperty::setAccessible, it is deprecated in PHP 8.5, calling it had no effect since PHP 8.1 2025-12-12 11:37:43 +01:00
Bastian Lederer
851f4fa3a6 adjust the names of PDO::MYSQL constants in PHP 8.5 since they are replaced by Pdo\Mysql 2025-12-12 11:37:41 +01:00
Bastian Lederer
a623d1f177 Mark parameters defaulting to null as nullable, to avoid PHP8.4+ deprecation warnings 2025-12-12 11:37:14 +01:00
Eric Lippmann
2597297442
Remove monitoring module (#5458)
Some checks failed
L10n Update / update (push) Has been cancelled
CI / PHP (push) Has been cancelled
Will be moved to https://github.com/Icinga/icingaweb2-module-monitoring.
2025-12-12 11:36:08 +01:00
Eric Lippmann
ca76cc5f86
GitHub Actions: Use new PHP workflows (#5431)
This PR switches to the new PHP workflow, which combines linting, static
analysis, and unit testing.
2025-12-12 11:04:49 +01:00
Eric Lippmann
8d3258735b GitHub Actions: Use new PHP workflows 2025-12-11 11:43:30 +01:00
Sukhwinder Dhillon
9603ca507b Remove monitoring module
- It has been moved to https://github.com/Icinga/icingaweb2-module-monitoring
2025-12-08 14:40:49 +01:00
Eric Lippmann
3b732c3ff9
Replace outdated test setup code with composer.json (#5445)
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.4 on ubuntu-latest (push) Has been cancelled
This is preparation for a GitHub action to streamline tests, which
* expects the `phpunit.xml` configuration at the root level, and
* installs dependencies via `composer`.

Proof that the same number of tests are run after moving the
configuration file:
*
[main](https://github.com/Icinga/icingaweb2/actions/runs/18972121136/job/54182208796#step:6:243)
* [this
PR](https://github.com/Icinga/icingaweb2/actions/runs/19137281980/job/54692472598#step:6:243)

Rationale for introducing `composer`:

GitHub Actions for this repository and any other module that requires
Mockery must specify this dependency themselves. Module tests require
Icinga Web anyway, so all (development) dependencies and any changes to
them should be automatically applied instead of having to adjust each
individual module affected. If we eventually upload our library bundles
to Packagist as well, we could also specify them in `composer.json` once
instead of having to require them in every action.
2025-12-05 15:17:37 +01:00
Johannes Meyer
70f29827f9
Release v2.12.6 (#5452)
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.4 on ubuntu-latest (push) Has been cancelled
2025-11-18 18:00:01 +01:00
Johannes Meyer
c6cdb5bb0b Update CHANGELOG.md 2025-11-18 17:52:52 +01:00
Johannes Meyer
94561159a4 Raise version to 2.12.6 2025-11-18 17:35:08 +01:00
Johannes Meyer
8b1db402f1 Update AUTHORS and .mailmap 2025-11-18 17:32:57 +01:00
Gianluca Piccolo
eae7222ac7 Fix: add login hook to ext backends
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.4 on ubuntu-latest (push) Has been cancelled
2025-11-13 09:20:43 +01:00
Johannes Meyer
a5452793f4
Fix mobile/minimal layout layout (#5381)
fix #5386, fix #5023
2025-11-13 09:13:25 +01:00
Sukhwinder Dhillon
f7558d9606 responsive.less: Show expanded sidebar in full height in .minimal-layout 2025-11-12 12:50:53 +01:00
Sukhwinder Dhillon
c03df0a0f8 responsive.less: Don't show scrollbar in .minimal-layout when sidebar is collapsed 2025-11-12 12:50:53 +01:00
Eric Lippmann
17e191a298 Add Dependabot for composer 2025-11-06 14:56:26 +01:00
Eric Lippmann
eabb806f54 Remove obsolete method BaseTestCase::assertMatchesRegularExpression()
Else, tests with current PHPUnit versions fail with `Cannot override final
method PHPUnit\Framework\Assert::assertMatchesRegularExpression()`.
2025-11-06 14:35:55 +01:00
Eric Lippmann
40afb26b61 Replace outdated test setup code with composer.json
Also, we could require our PHP libraries as soon as we have uploaded them to
Packagist.
2025-11-06 14:35:55 +01:00
Eric Lippmann
4fb99c2f77 Move phpunit.xml
This is preparation for a GitHub action to streamline tests, which expects the
`phpunit.xml` configuration at the root level.
2025-11-06 13:55:19 +01:00
Johannes Meyer
9b63928573 js: Do not fail while trying to detect autosubmit element
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.4 on ubuntu-latest (push) Has been cancelled
fixes #5439
2025-10-31 13:10:48 +01:00
Eric Lippmann
326616c965
Rename rule: ignore NotPascalCase in views/helpers (#5432)
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.4 on ubuntu-latest (push) Has been cancelled
PHP_CodeSniffer 4.0 renamed the class name NotCamelCaps to
NotPascalCase.
Reference:
https://github.com/PHPCSStandards/PHP_CodeSniffer/wiki/Version-4.0-User-Upgrade-Guide#upgrading-5

Because of this change, our current configuration was no longer
compatible.
I tested the update inside a Docker container: after switching to the
new class name `NotPascalCase`, the error message disappeared and the
rules are applied as expected.
2025-10-09 10:39:31 +02:00
Jolien Trog
d45d61dacd Rename rule: ignore NotPascalCase in views/helpers
PHP_CodeSniffer 4.0 renamed the class name NotCamelCaps to
NotPascalCase.
2025-10-08 16:09:22 +02:00
Markus Opolka
d658c73c73 doc: Add vSphere CSP support release 2025-09-09 10:09:59 +02:00
Alexander Aleksandrovič Klimov
8603044881 Fix typo in code comment 2025-08-22 15:46:59 +02:00
Sukhwinder Dhillon
7649c71dda forms.less: Apply fixed height to input elements
- Apply unitless line-height
2025-08-22 14:35:45 +02:00
Alexander Aleksandrovič Klimov
2e164a75d4
Fix typo in code comment (#5327)
Co-authored-by: Johannes Meyer <johannes.meyer@icinga.com>
2025-08-22 12:01:01 +02:00
Alexander Aleksandrovič Klimov
16f9c82860 Doc: fix over-escaping 2025-08-22 10:46:30 +02:00
Jan Schuppik
ee3f3135b8 Fix: PHP built-in server detection for PHP 8.3 SERVER_SOFTWARE format 2025-08-20 09:30:54 +02:00
Jan Schuppik
73c813eded
Fix/icingacli setup fpm flag (#5411)
resolves #5409

Only use default value for --fpm-url if neither --fpm-url or
--fpm-socket-path is set.
2025-08-20 09:27:31 +02:00
Alexander Aleksandrovič Klimov
471bdca6c2 Remove whitespace around config which couldn't be stored
If I change settings in the web UI, but latter can't write to /etc/icingaweb2, it shows me the desired file contents, so I can deploy them myself – with strange whitespace around it.
2025-08-08 14:32:39 +02:00
Johannes Meyer
c894333064 js: Fix that links without href are opened in a modal 2025-08-05 10:47:44 +02:00
Johannes Meyer
50a5cffc8b
Fix magnifying glass in themes (#5396)
fixes #5395
2025-08-04 15:27:25 +02:00
Johannes Meyer
23e00754c6 css: Do better to ensure menu text is readable
In case background is adjusted, a suitable text
color should also be chosen. Rocket science!
2025-07-31 09:30:49 +02:00
Johannes Meyer
1b36d47e75 css: Hide background images for input.search
Some themes set only the image. Since we dropped
all other background options, default browser
behavior is applied which repeats by default.
2025-07-31 09:30:49 +02:00
Alex
43aae15c1b Removed background search icon 2025-07-31 09:30:33 +02:00