Commit graph

5560 commits

Author SHA1 Message Date
Eric Lippmann
5fc103ffc3
Adapt to react/promise v3 and react/event-loop v1.6 (#3043)
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
Adapt the `react/promise` integration for v3 by replacing the removed
`ExtendedPromiseInterface`, passing the required settlement arguments, and using
`catch()` and `finally()` instead of the removed aliases.

Drop the unreachable `FinishedProcessState` catch handler: v3 only catches
`Throwable`, and `IcingaCli` already rejects with an exception that wraps the
process state reason.

Adapt the `react/event-loop` integration for v1.6 by replacing the deprecated
`Factory::create()` call with `Loop::get()`.
2026-04-30 15:31:28 +02:00
Johannes Rauh
61f2586e7a
Remove dead FinishedProcessState catch handler
`FinishedProcessState` does not implement `\Throwable`, so `catch(function
(FinishedProcessState $state))` can never trigger in react/promise v3 where
rejection reasons must be `\Throwable`.

This is safe to remove because `IcingaCli` already rejects with an `Exception`
wrapping the process state reason:

```php
$deferred->reject(new Exception($state->getReason()));
```

The existing `catch(\Exception $e)` handler already covers this.

Ref: https://github.com/reactphp/promise/releases/tag/v3.0.0
2026-04-30 15:11:16 +02:00
Johannes Rauh
38cf31621a
Replace Factory::create() with Loop::get()
`React\EventLoop\Factory` has been removed in v1.2. The replacement is
`React\EventLoop\Loop::get()` which returns a shared loop instance.

Ref: https://github.com/reactphp/event-loop/releases/tag/v1.2.0
2026-04-30 15:11:16 +02:00
Johannes Rauh
f3bddf215d
Fix type annotation and remove unused type imports
Update `@var` annotation to use `PromiseInterface[]`. Remove now unused
`Promise` import from JobRunner.
2026-04-30 15:11:16 +02:00
Johannes Rauh
d4a3cca7da
Replace otherwise() with catch() and always() with finally()
These methods have been renamed in v3.

Ref: https://github.com/reactphp/promise/releases/tag/v3.0.0
2026-04-30 15:11:16 +02:00
Johannes Rauh
d1117d31ce
Pass Throwable to reject()
`reject()` now requires a `Throwable` instance as argument.

Ref: https://github.com/reactphp/promise/releases/tag/v3.0.0
2026-04-30 15:11:16 +02:00
Johannes Rauh
f87c1e1e7c
Pass null to resolve() and Deferred::resolve()
Both now require an explicit value argument.

Ref: https://github.com/reactphp/promise/releases/tag/v3.0.0
2026-04-30 15:11:15 +02:00
Johannes Rauh
2c5c565606
Replace ExtendedPromiseInterface with PromiseInterface
`PromiseInterface` now includes the functionality `ExtendedPromiseInterface`.
Additionally use imports instead of FQN.

Ref: https://github.com/reactphp/promise/releases/tag/v3.0.0
2026-04-30 15:11:15 +02:00
Eric Lippmann
5d38237dd7
Support PHP 8.5 (#3028)
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
Use explicit nullable types (`?T $x = null`); implicit nullable parameters
are deprecated.

Avoid `null` as array index; use empty string to prevent deprecation
warnings.

Remove usage of deprecated `E_STRICT`.
2026-04-17 09:14:30 +02:00
Alexander A. Klimov
558a69e78b Don't use deprecated E_STRICT 2026-04-16 09:38:24 +02:00
Alexander A. Klimov
ae7ef2810f Use the empty string as array index, not null
Otherwise, PHP complains:
Using null as an array offset is deprecated, use an empty string instead.
2026-04-16 09:38:24 +02:00
Alexander A. Klimov
ff92b0a485 For method parameters, use ?T $x = null, not T $x = null
Implicitly marking parameters as nullable is deprecated, the explicit nullable type must be used instead.
2026-04-16 09:38:24 +02:00
Johannes Meyer
7d0a483d7a
Remove dependency checker (#3065)
Remove redundant missing dependency check and the PHP legacy
compatibility checks once the module requires icinga-php-legacy instead
of incubator module.

Depends on: requirements to be updated to use icinga-php-legacy library
2026-04-16 09:37:36 +02:00
Ravi Srinivasa
71d39d767e
Remove compatibility check for PHP legacy
PHP 5.* is not supported any more by Icinga Director and hence it is redundant to
check the compatibility with the corresponding version
2026-04-09 08:58:09 +02:00
Ravi Srinivasa
8b64bf83c8
Remove dependency checker
Requirements are already validated during module activation, making a post-activation dependency check redundant.
Additionally, starting with version 1.12, Icinga Director depends on the icinga-php-legacy library rather than the
incubator module, eliminating the risk of accidentally deactivating the incubator module while Icinga Director is active.
2026-04-09 08:58:07 +02:00
Ravi Kumar Kempapura Srinivasa
7c12b85216
Release version 1.11.8 (#3062)
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
2026-04-01 11:25:26 +02:00
Ravi Srinivasa
680413af30
Release version 1.11.8 2026-04-01 11:17:18 +02:00
Ravi Srinivasa
e9be701956 ObjectsTableService: Fix grouping of columns for postgres in prepareQuery() 2026-04-01 09:03:57 +02:00
Ravi Srinivasa
add4301750 Revert the changes made for shardj/zf1-future compatibility in (#3035)
Some checks are pending
L10n Update / update (push) Waiting to run
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Waiting to run
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Waiting to run
The patch that was dropped in icinga-php-thidparty version 0.15.0, will be applied in the Icinga/zf1 fork.
And with the icinga-php-thirdparty version 0.15.1, this changes are obsolete and also will not break compatibility
with earlier versions of icinga-php-thirdparty.
2026-03-31 17:30:28 +02:00
Ravi Kumar Kempapura Srinivasa
add5288b1c
Remove locales (#2989)
Some checks are pending
L10n Update / update (push) Waiting to run
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Waiting to run
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Waiting to run
I imported all of them on translate.icinga.com now. The file
`translateMe` is obsolete since Icinga L10n.
2026-03-30 14:31:10 +02:00
Johannes Meyer
95a662d2c1 Drop usages of gipfl\Translation\TranslationHelper 2026-03-30 11:33:11 +02:00
Johannes Meyer
7232640107 Remove locales
I imported all of them on translate.icinga.com now.
The file `translateMe` is obsolete since Icinga L10n.
2026-03-30 11:33:11 +02:00
Ravi Kumar Kempapura Srinivasa
a5837727ec
Add import source property modifier to cast int to string (#3047)
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
2026-03-26 15:06:18 +01:00
Ravi Kumar Kempapura Srinivasa
0ed65d8f26
Release 1.11.7 (#3054) 2026-03-26 11:08:18 +01:00
Ravi Srinivasa
7ce28b562b Release 1.11.7 2026-03-26 10:49:50 +01:00
Ravi Kumar Kempapura Srinivasa
4f3b1816fb
Fix incorrect display of the deployment warning widget (#3052)
fixes #3044
2026-03-26 10:47:42 +01:00
Ravi Srinivasa
9589d61028 Check if there are deployments, before checking pending deployments 2026-03-26 10:44:28 +01:00
Ravi Srinivasa
0570d5b0d7 StartupLogRenderer: Html::escape requires its argument to be string
Since startup_log can be null depending on the log level, it may trigger a PHP deprecation warning in htmlspecialchars() within Html::escape.
This fix prevents the warning by handling the null value appropriately.
2026-03-26 10:44:28 +01:00
Ravi Srinivasa
cdcc2b53fd DirectorDeploymentLog: Use 'stage_collected' column to calculate pending state 2026-03-26 10:44:28 +01:00
raviks789
e39975d344 DirectorObjectForm: Fix checking for descendants for new templates 2026-03-26 10:14:31 +01:00
Ravi Kumar Kempapura Srinivasa
5a173cccc4
ObjectsTableService: Check for service inheritance in all ancestors (#3042)
fixes #3041
2026-03-26 10:03:23 +01:00
raviks789
8d626957a4 IcingaServiceForm: Disable 'Reactivate' button if the service was deactivated in one of the host templates 2026-03-26 09:51:40 +01:00
raviks789
db8fcc6556 ObjectsTableService: Check for service inheritance in all ancestors 2026-03-26 09:51:40 +01:00
Ravi Kumar Kempapura Srinivasa
fed11fc0e4
Fix/avoid cyclic inheritance only for host and command (#3037)
fixes #3036
2026-03-26 09:51:03 +01:00
raviks789
bed69a7a18 DirectorObjectForm: Avoid cyclic inheritance only for hosts and commands 2026-03-26 09:46:33 +01:00
raviks789
558877eb2b IcingaObjectHandler: Avoid cyclic inheritance only for hosts and commands 2026-03-26 09:46:33 +01:00
Eric Lippmann
e13d840ace
Fix Icinga/zf1 compat (#3035)
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
The method signature of `Zend_Form_Element::_filterValue()` was changed
years ago in `shardj/zf1-future`, but we provided a patch so that
Director did not need to be modified to maintain compatibility between
multiple library versions. With the upcoming support for PHP 8.5, we no
longer need to support older library versions and can adapt Director to
be compatible with the changed signature.
2026-03-12 16:49:25 +01:00
raviks789
b21b849ed2 IcingaObjectHandler: Fix undefined array key 'imports' error
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
This was introduced by the commit 0a87527d07 (0a87527d07)
2026-02-19 13:07:06 +01:00
Ravi Kumar Kempapura Srinivasa
def527a225
Releases 1.11.6 (#3030) 2026-02-19 09:33:29 +01:00
raviks789
952123ef29
Release 1.11.6 2026-02-18 11:39:04 +01:00
Ravi Kumar Kempapura Srinivasa
231e42b514
Add cli delete syncrule and importsource (#2707)
Some checks failed
L10n Update / update (push) Has been cancelled
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Has been cancelled
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Has been cancelled
resolves #2706
2026-02-18 09:48:55 +01:00
Gianluca Piccolo
c8f6790169 Add cli delete syncrule
Also, display success message upon deleting sync rule

Co-authored-by: Ravi Kumar Kempapura Srinivasa <ravi.srinivasa@icinga.com>
2026-02-18 08:59:34 +01:00
Gianluca Piccolo
ff4153cd44 Add cli delete importsource
Also, display success message upon deleting Import source

Co-authored-by: Ravi Kumar Kempapura Srinivasa <ravi.srinivasa@icinga.com>
2026-02-18 08:59:34 +01:00
raviks789
f39b97abde BasketSnapshot: Fix restoring Host templates having relation with host template choices
Some checks are pending
L10n Update / update (push) Waiting to run
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Waiting to run
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Waiting to run
2026-02-17 15:55:23 +01:00
Ravi Kumar Kempapura Srinivasa
11eae746ba
Show an indicator near deployment link if there is an active deployment (#2999)
resolves #2917
2026-02-17 15:52:50 +01:00
moreamazingnick
b3a132dbc1
fixes wrong url in activitylog for scheduledowntime #2456 (#2507)
in the activity log list the url to the scheduled dontime is wrong
scheduledowntime != schedule-downtime
2026-02-17 15:46:32 +01:00
Ravi Kumar Kempapura Srinivasa
a987706363
DirectorObjectForm: Validate for imports cyclic inheritance (#3000)
Some checks are pending
L10n Update / update (push) Waiting to run
PHP Tests / Static analysis for php 7.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 7.3 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 7.4 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.0 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.1 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Static analysis for php 8.3 on ubuntu-latest (push) Waiting to run
PHP Tests / Unit tests with php 8.2 on ubuntu-latest (push) Waiting to run
PHP Tests / Unit tests with php 8.3 on ubuntu-latest (push) Waiting to run
fixes #2853
2026-02-17 14:30:45 +01:00
raviks789
0a87527d07 IcingaObjectHandler: Check for import loop detection during rest api updates 2026-02-17 14:14:20 +01:00
raviks789
3de92e347d DirectorObjectForm: Validate for imports cyclic inheritance 2026-02-17 14:14:20 +01:00
Ravi Kumar Kempapura Srinivasa
8381c9c13c
Fix director services permissions (#3019)
The user should not be able to modify any Service objects when Service modification permissions are removed in Director. The Modify button in Monitoring View and Icinga DB Web should not appear, and any attempt to change a Service should be blocked.

fixes #3017
2026-02-17 14:13:33 +01:00