Commit graph

610 commits

Author SHA1 Message Date
Johannes Meyer
cda66ca82e menu: Only count the worst states in badges
fixes #365
2025-07-01 16:53:18 +02:00
Johannes Meyer
a6033491f4 Do not break sidebar if processes cannot be loaded
fixes #466
2025-07-01 14:24:58 +02:00
Johannes Meyer
ccf2ba4c66 IcingaDbState: Correctly determine ack and downtime flags
fixes #469
2025-06-30 17:08:47 +02:00
Johannes Meyer
d88a7dd752 Node: Rename in_acknowledged to is_acknowledged
refs #461
2025-06-30 12:11:15 +02:00
Johannes Meyer
fd7fd71bb7 Correctly determine node states in sidebar
fixes #467
2025-06-30 10:58:06 +02:00
Jáchym Holeček
f12b2d744a
Add is_acknowledged property to Node class (#461)
This pull request introduces an `is_acknowledged` property to the `Node`
class in the Business Process library to enhance JSON output.
2025-06-30 10:47:56 +02:00
Navid Sassan
35218f72fc Add showFullscreen and showCompact for dashboard 2025-05-07 10:28:54 +02:00
Johannes Meyer
71e957dc5e Ensure compatiblity with https://github.com/Icinga/ipl-web/pull/258 2025-04-01 11:34:25 +02:00
moreamazingnick
e9a551e581
Fix indistinguishable suggestions for nodes (#433)
refs #427
2024-04-23 15:38:48 +02:00
Johannes Meyer
3a0b40a91f Fix that handled nodes are not handled 2024-04-22 14:06:57 +02:00
Sukhwinder Dhillon
c43128be3e
Correct notification messages and add missing translations (#444)
fixes #405
2024-04-22 10:51:06 +02:00
Sukhwinder Dhillon
980ea85e61 Sort: Remove var type hint change
This should be fixed in ipl/stdlib
2024-04-19 12:54:16 +02:00
Sukhwinder Dhillon
ca620814c3 Storage: Define type of generic class ConfigObject 2024-04-19 12:54:16 +02:00
Sukhwinder Dhillon
f4d704fbd5 Fix: Switching to the icingadb backend and searching host/service node in add/edit form throws an error
`HostServiceTermValidator`: `$testConfig` requires backend for `MonitoringState::apply()` call.

If the `$testConfig` has no backend set and icingadb is in use, `MonitoringState::__construct($config) => $config->getBackend()` returns an icingadb backend that is not suitable for the `MonitoringState` class.
2024-03-27 08:47:02 +01:00
Sukhwinder Dhillon
1f8d74a612 Sort: Fix var type error 2024-03-26 12:50:08 +01:00
Yonas Habteab
1c6ad874ac Add variable type hint & fix argument type hints 2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
b2c25d35f7 Node: Property $icon can be null 2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
f74a054d8b ProcessChanges: Fix incorrect phpDoc 2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
c497c7360e Url::getRequest(): Add missing return type 2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
74c3440ef9 ProcessProblemsBadge: Fix variable $count is probably undefined 2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
52732dc3c7 QuickForm: Make property $successUrl nullable and add phpDoc to setAction() 2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
2efe54de1f QuickBaseForm: Property $icingaModule can be null 2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
95504131d1 FormLoader: Define var $file in method scope
- Fixes IDE's message: `varibale $file is probabaly undefined`
2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
95776d309b Controller::storage(): Only return an instance of LegacyStorage 2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
d0df785bbd BaseTestCase: Param $subDir can be null 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
43b391880d LegacyConfigRenderer: Don't use dynamic property 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
7605d5e007 LegacyConfigParser: Property $prevKey can be null 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
6f81fed8e7 NodeTile: Fix incorrect phpDoc 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
26b0d921ea Renderer::renderStateBadges(): Return type can be null 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
ab8fe2aca6 (ServiceDetail/DetailView)Extension: Property $storage can be null 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
3544c21056 Node: Property $state can be null 2023-08-24 13:29:10 +02:00
Sukhwinder Dhillon
6934016ef0 Node: var_export() param#2 expects bool 2023-08-24 13:29:04 +02:00
Sukhwinder Dhillon
ad3cb81dc9 NodeAction: json_decode() $param#2 expects bool 2023-08-24 13:28:55 +02:00
Sukhwinder Dhillon
f960d09cc2 BpNode: Remove unreachable break statements 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
541ec5da6c BpNode: Property $children can be null 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
598e9a1af0 BpConfig::getNode(): Define exact return types in PhpDoc
- This fixes the IDE's issue `Call to an undefined method`, which is caused by the fact that the parent class `Node` does not contain all the methods defined in the child classes.
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
ae8e71106f BpConfig::hasChanges(): Fix incorrect return type 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
6306b5306c Define variable type when method returns a class object
- This helps the IDE to find class methods and resolves the `call to an undefined method` issue
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
21933d1868 NodeAction::create(): Avoid unnecessary variable initialization 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
7346cd1cab HostServiceTermValidator:isValid(): Add missing return statement 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
35d151b70d Sort Trait: Make $sort nullable and adjust code accordingly
- Update phpDoc
2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
92e982bf3d Remove unused class Form and FormStateOverrides 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
e638fade56 Renderer: Fix that !empty($elements) is always true 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
9e67b56bca RenderedProcessActionBar: Remove unused constructor param $auth 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
8923476277 BpNode::getMissingChildren(): Use child name if alias not given
Host/Service alias is optional and null as default
2023-08-10 12:45:17 +02:00
Johannes Meyer
b8d5f0de2b Drop unused trait EnumList 2023-08-09 16:13:01 +02:00
Johannes Meyer
30d952ae0a Drop obsolete form element class StateOverrides 2023-08-09 16:13:01 +02:00
Johannes Meyer
0ea04f898f Drop obsolete class NoDuplicateChildrenValidator 2023-08-09 16:13:01 +02:00
Johannes Meyer
d9c6debfa9 ServiceNode: Change alias to <service> on <host> 2023-08-09 16:13:01 +02:00
Johannes Meyer
9c84764157 BpNode: Re-index childnames upon node removal 2023-08-09 16:13:01 +02:00