Commit graph

1048 commits

Author SHA1 Message Date
Johannes Meyer
be1f56ba08
Support custom ordering of nodes (#384)
resolves #252
closes #297 

requires https://github.com/Icinga/ipl-web/pull/173
2023-08-03 15:22:40 +02:00
Johannes Meyer
2acf611812 process/show: Allow to adjust the order of nodes
Nodes can be ordered as usually by display name, but now also
in descending order. They can now also be ordered by state.

This also applies to manually ordered processes. Though, changes
to the manual order can only happen if the default order is
active. If that's not the case, a note is shown and a way to reset
the sort order.
2023-08-03 15:19:28 +02:00
Johannes Meyer
52c150c56b Use the new Sort trait where applicable
Moves the entire order processing to the renderers as that's
where it's mostly relevant. The only cases where nodes are
still ordered outside the rendering is where changes are
applied based on user input, which happened based on what's
been previously rendered.
2023-08-03 15:19:28 +02:00
Johannes Meyer
c3d09fd601 Introduce Icinga\Module\Businessprocess\Common\Sort 2023-08-03 15:06:08 +02:00
Johannes Meyer
96f94f9959 Controller: Extend ipl\Web\Compat\CompatController 2023-08-03 15:06:08 +02:00
Johannes Meyer
8b2bac4e85 MoveNodeForm: Instruct JS to refresh the target container
instead of letting JS refresh it on its own
2023-08-03 15:06:08 +02:00
Johannes Meyer
926ac14bd9 css: Apply form specific rules only to form.bp-form 2023-08-03 15:06:08 +02:00
Johannes Meyer
1ac87cb4ea Let all config forms extend BpConfigBaseForm
They're all too similar.
2023-08-03 15:06:08 +02:00
raviks789
654ba0474d
Show Ack icon in tree view for nodes with both downtime and acknowledgement (#352)
Acknowledgement takes priority in handled nodes and hence it is
sufficient to show acknowledged icons in case the handled node has an
acknowledgement and also a downtime is scheduled for it.
2023-08-03 15:01:48 +02:00
raviks789
4a3b3e3657 Show Ack/Downtime icons in the node tiles for the handled nodes
In case the hosts/services are acknowleded or have scheduled downtime show Acknowledeged or
Downtime icons respectively.
2023-08-03 14:53:08 +02:00
Sukhwinder Dhillon
174abea6bd Add custom message for form's regex validation 2023-08-03 11:02:34 +02:00
Johannes Meyer
94f5bd75ac
Do not break overview page if existing business pocesses throw exceptions (#375)
fixes #370
2023-08-03 11:00:57 +02:00
Johannes Meyer
13330d3a44 Don't cast url to string if it's internally transformed again
Also, the cast encodes the url as well, for use within HTML.
This is not required if used in conjunction with ipl-html.
2023-08-03 10:59:23 +02:00
Sukhwinder Dhillon
071f006b7d AddNodeForm: Don't throw error while adding existing invalid config file 2023-08-03 10:57:14 +02:00
Sukhwinder Dhillon
da0c72d578 DashboardAction: Use ipl-web's icon 2023-08-03 10:57:14 +02:00
Sukhwinder Dhillon
834005f7b4 Don't break impact-action page if bp has invalid config
- Add message for invalid config
2023-08-03 10:57:14 +02:00
Sukhwinder Dhillon
6b4a3cbc0c Do not break overview page if existing business-process has invalid config
- Add icon and config file name to broken `business-process`
- Use font-awesome icon
2023-08-03 10:57:14 +02:00
Johannes Meyer
7298134f2f
Clean orphaned (missing) nodes (#355)
resolves #222 

## Blocked by:
- https://github.com/Icinga/icingaweb2-module-businessprocess/pull/358
2023-08-03 10:51:09 +02:00
Sukhwinder Dhillon
5fcd8246b8 Add cli command Cleanup 2023-08-01 15:30:46 +02:00
Sukhwinder Dhillon
b053a78a13 ProcessController: Add Show link for missing linked nodes 2023-08-01 15:30:43 +02:00
Sukhwinder Dhillon
21c1949b07 Introduce CleanupNodeForm action
This helps to clean orphaned (missing) nodes
2023-08-01 15:11:53 +02:00
Sukhwinder Dhillon
1aba349be5 NodeRemoveAction: Remove stateoverrides of node while removing node 2023-08-01 11:14:18 +02:00
Johannes Meyer
c2e06aca0a TreeRenderer: Use Icinga Web's collapsible implementation now
resolves #254
2023-07-24 15:57:06 +02:00
Johannes Meyer
6abcf8a757
Display node name if alias for monitoring node is missing (#360)
When a monitoring node is missing, its alias is also missing. So in this
case we should display the node name.
2023-07-24 14:40:14 +02:00
Sukhwinder Dhillon
2f730cc526 Display node name if alias is missing
This fixes the issue that the name of a missing monitoring node is
not displayed in forms and in Tree/Tile view.
2023-07-24 14:31:17 +02:00
Sukhwinder Dhillon
5b4056e1b2 ServiceNode: getAlias() returns null if host or service alias is null 2023-07-24 14:31:17 +02:00
Sukhwinder Dhillon
cbb6b018da
Show node id in edit mode (#382)
ref #308
2023-07-20 13:31:46 +02:00
Sukhwinder Dhillon
83194e4942 Drop support for external_info and extra_info flag 2023-07-19 13:34:39 +02:00
Johannes Meyer
9455704b0b
Merge pull request #379 from Icinga/add-new-operator-XOR
Introduce `XOR (^)` operator
2023-07-17 13:57:59 +02:00
Sukhwinder Dhillon
137b494ea4 Update operator screenshots 2023-07-13 10:22:55 +02:00
Sukhwinder Dhillon
be2473864b Introduce new XOR (^) operator 2023-07-13 10:19:08 +02:00
Sukhwinder Dhillon
77075d5c64 Don't show process id if display name exists 2023-07-12 11:54:36 +02:00
Sukhwinder Dhillon
ecdd51b6a0 LegacyConfigParser: Ignore empty lines in parseHeaderLine()
- Otherwise the index 0 of the empty line in elseif cannot be checked, which leads to an error
2023-07-12 11:26:14 +02:00
Johannes Meyer
d8fed188d7
Merge pull request #374 from Icinga/fix/add-icingadb-webs-timestamp-behavior-change
IcingaDbState: `last_state_change` is now a DateTime Obj
2023-06-07 08:29:32 +02:00
Sukhwinder Dhillon
8449d56c07 module.info: Require icingadb module version >=1.1.0 2023-06-06 16:02:59 +02:00
Sukhwinder Dhillon
4143019412 IcingaDbState: last_state_change is now a DateTime Obj
ref https://github.com/Icinga/icingadb-web/pull/753
2023-06-06 15:07:04 +02:00
Eric Lippmann
82ddeba163
Merge pull request #366 from Icinga/UpdateCheckoutAction
Update Checkout Action to v3
2023-01-10 15:56:24 +01:00
Timm Ortloff
0b6e6dc12c CI: Update Checkout Action to v3 2023-01-09 12:43:27 +01:00
raviks789
da2ed1aef4 Prevent deletion of referenced BP config 2022-09-14 09:58:04 +02:00
raviks789
3a7dc64a50
Fix storing of business process with Description having new lines (#339)
* Fix storing of business process with `Description` having new lines

The `LegacyConfigRenderer::renderHeader()` should render new lines in the `Description` field as comments.

This fix avoids occurrence of future issues due to new lines in `Description` field while adding or modifying the
business processes.

* Parse new lines in header

The new lines in header which may belong to the field like `Description` must be parsed correctly.
2022-09-14 09:53:54 +02:00
raviks789
bd2cb52292 Show critical count badge in left menu
The critical count badge of `Business Process` menu section represent number configs that are in critical state.
The critical count badge of configs sub section under represent number of critical root nodes of that specific config.
2022-09-14 09:53:11 +02:00
raviks789
4ca8c72a05 Show service and host nodes for filtered roles
The service and host nodes must be shown, but clicking on these nodes should show
"Access Denied" page.
2022-09-14 09:52:23 +02:00
raviks789
b24600893a Apply the filter for host names when 'Hosts from filter' option is selected 2022-09-14 09:51:31 +02:00
raviks789
ce812c01bf Fix deletion of all occurences of a node
In case the node is not a BP node, we simply have to remove all occurences of the node.
2022-07-28 12:35:45 +02:00
raviks789
731541e667 Fix BP node in case it has pending-handled child node
Increment `PENDING` state summary counter of the BP node in case there are `PENDING-HANDLED` child/children node/s.
2022-07-27 09:23:45 +02:00
Johannes Meyer
d34da32f28 Make sure to expect ITL compatible custom var names 2022-07-21 16:01:37 +02:00
Johannes Meyer
104e2ab488
Merge pull request #334 from Icinga/enhance-detail-view-integration
Enhance detail view integration
2022-07-20 11:33:26 +02:00
Johannes Meyer
4f1d447faa doc: Add monitoring chapter 2022-07-20 11:22:41 +02:00
Johannes Meyer
b8de4580da Add detail integration for Icinga DB Web 2022-07-20 11:22:41 +02:00
Johannes Meyer
b2bc6b852e Enhance DetailViewExtension
* The checkcommand name can now be configured
* The variable names are shortened
* The config and process variables are now separate
2022-07-19 16:19:07 +02:00