Commit graph

443 commits

Author SHA1 Message Date
Johannes Meyer
d2d64365b6 php-diff: Don't use curly braces for string offset access 2020-02-27 10:41:54 +01:00
Eric Lippmann
a06fba34b3 Remove abstract function Node::__construct() 2020-02-27 10:08:16 +01:00
Ravi Kumar Kempapura Srinivasa
f5166f4348 Fix 'vsprintf(): Too few arguments' unexisting imported node exception
If the imported node does not exist, no arguments is  passed to BpConfig::addError() by ImportedNode::createFailedNode(). Added 'if' condition in BpConfig::addError() in case no arguments are passed to vsprintf.

refs #234
2020-02-26 15:09:17 +01:00
mdkamijo
3ffbce0709
Make it possible to delete imported nodes (#248)
It is possible to import process nodes from other processes. But there
are no way, via the GUI, to remove the imported process nodes from the
current process/process node.
This commit makes it possible to remove imported process nodes, no matter
where which process they comes from.
2020-02-26 14:53:34 +01:00
Eric Lippmann
5395b42bab Fix URL param overrides upon rendering
Before, we used setParams() instead of with() to populate the parameters
which is especially problematic with imported nodes where the config
paramter got overriden for every subsequent node.

fixes #228
2020-02-26 14:18:40 +01:00
Eric Lippmann
125bf37ba8 Fix superfluous base target overrides
* Fix drill down of the tile/tree action icon links
* Set base target only on parent containers

This also fixes the dashboard integration where we only override the
base target of the div.tiles containers.

fixes #243
2020-02-26 14:17:39 +01:00
Johannes Meyer
4e6e1f0819 Node: Add __unbound__ parent node in getPaths() if there are no parents
fixes #245
2020-02-26 13:47:24 +01:00
Johannes Meyer
144bcdf852 Remove space after reference operators 2020-02-26 09:19:31 +01:00
Eric Lippmann
a2854e8cf4 Use display_name as alias for host and service nodes 2020-02-05 15:01:22 +01:00
Dominik Seidel
8ef1dfcbdc CLI: Add options --downtime-is-ok and --ack-is-ok 2020-02-05 15:01:22 +01:00
Dominik Seidel
1414e76d94 CLI: Add options --blame and --root-cause 2020-02-05 15:01:22 +01:00
Johannes Meyer
7d199a94ea RenderedProcessActionBar: Re-introduce Config link for subprocess nodes
Having to navigate a level up to edit the currently showing process is tedious,
to say the least.

refs #78
2019-02-28 15:15:11 +01:00
Johannes Meyer
b932fa8415 TreeRenderer: Open info urls in a new tab
refs #187
2019-02-28 11:19:13 +01:00
Johannes Meyer
c5d3127303 Storage: Properly escape and unescape names with operators
fixes #205
2019-02-28 10:58:06 +01:00
Johannes Meyer
cad29d4d32 NodeTile: Add current path to the add action url
fixes #212
2019-02-28 09:12:38 +01:00
Johannes Meyer
fe991d7f58 BpNode: Make sure to sort children alphabetically by default 2019-02-28 08:53:54 +01:00
Johannes Meyer
2a82b326fe TreeRenderer: Use the correct action urls for imported nodes
refs #209
2019-02-28 08:19:37 +01:00
Johannes Meyer
a941052efa NodeTile: Don't show action links for imported nodes
refs #209
2019-02-28 07:48:42 +01:00
Johannes Meyer
885064b577 Provide links to jump to an imported node's source configuration
refs #209
2019-02-28 07:48:35 +01:00
Johannes Meyer
670a29e5f7 Breadcrumb: Show a node's state 2019-02-26 13:15:14 +01:00
Johannes Meyer
3431540700 NodeTile: Don't use a node's identifier if it's the same config anyway 2019-02-25 14:23:41 +01:00
Johannes Meyer
eaf5b85538 Change how imported nodes are recognized
Since configurations are cached this cannot be done by using
a flag. Instead the rendering and path aggregation are now able
to distinguish nodes themselves.
2019-02-25 13:58:18 +01:00
Johannes Meyer
40538c51ce LegacyStorage: Add cache to avoid parsing configurations multiple times 2019-02-25 12:42:52 +01:00
Johannes Meyer
6f3ffe48e2 BpConfig: Only list each involved configuration once 2019-02-25 08:19:39 +01:00
Johannes Meyer
6ae4cf745c RenderedProcessActionBar: Don't allow to unlock imported nodes 2019-02-22 14:41:53 +01:00
Johannes Meyer
cacc24f501 NodeAddChildrenAction: Really import nodes if instructed to do so 2019-02-22 14:30:06 +01:00
Johannes Meyer
0d262bf0d0 Renderer: Don't fail while generating ids for unbound nodes 2019-02-22 14:11:03 +01:00
Johannes Meyer
75a3d1fd5e LegacyConfigParser: Restore ability to defer referenced process initialization 2019-02-22 12:26:24 +01:00
Johannes Meyer
40c406ac9e TreeRenderer: Render the info_url action where all other action urls are 2019-02-22 12:26:24 +01:00
Johannes Meyer
1529ec4602 NodeTile: Hash ids the same way as in the tree view 2019-02-22 12:26:24 +01:00
Johannes Meyer
e36e918d32 RenderedProcessActionBar: Use term "Node" instead of "Process"
A process is also a node but a node not necessarily a process.
2019-02-22 12:26:24 +01:00
Johannes Meyer
a1bb91a999 js: Remove redundant handling for non-node tiles 2019-02-22 12:26:24 +01:00
Johannes Meyer
728d4cb2ae TreeRenderer: Show the correct icon for monitored nodes at the root level 2019-02-22 12:26:24 +01:00
Johannes Meyer
c73cd65f6f js: Correctly identify a node's parent in case of first level sub-trees 2019-02-22 12:26:24 +01:00
Johannes Meyer
673135c0f3 Don't redirect after a successful move action but refresh 2019-02-22 12:26:24 +01:00
Johannes Meyer
718a4305b4 NodeController: Show all processes affected by an impact
refs #143
2019-02-22 12:26:24 +01:00
Johannes Meyer
6cdaa48f68 TileRenderer: Use the correct action urls for imported nodes 2019-02-22 12:26:24 +01:00
Johannes Meyer
c19854d05c TileRenderer: Make the navigation through imported nodes fluent 2019-02-22 12:26:24 +01:00
Johannes Meyer
f0162278d6 BpConfig: Process node imports in hasNode() and getNode() 2019-02-22 12:26:24 +01:00
Johannes Meyer
42642c88d6 BpConfig: Flag imported configurations 2019-02-22 12:26:24 +01:00
Johannes Meyer
431a5e0085 Streamline usage of a node's name 2019-02-22 12:26:24 +01:00
Johannes Meyer
8465bc0bc3 LegacyConfigParser: Establish parent-child relationships
This replaces commit d1f32c5 as this is the more efficient
and proper solution.

refs #134
2019-02-22 12:26:24 +01:00
Johannes Meyer
e0529ee844 Revert "Node: Aggregate parents if none are registered yet"
This reverts commit d1f32c59f1.
2019-02-22 12:26:24 +01:00
Johannes Meyer
2799eff860 lib: Temporarily integrate the StateBall from ipl\Web\Widget 2019-02-22 12:26:24 +01:00
Johannes Meyer
a9ed7f66a4 Breadcrumb: Show a configuration's name again, "Root" is too vague 2019-02-22 12:26:24 +01:00
Johannes Meyer
7a8c48c7e8 Fix a few style issues 2019-02-22 12:26:24 +01:00
Johannes Meyer
df7e72398d RenderedProcessActionBar: Make the mode toggle a single anchor
It's a toggle, there's no need for two distinct urls. Even more
important, there's no need for two different click areas.
2019-02-22 12:26:24 +01:00
Johannes Meyer
a681d7e393 Fix that imported nodes have no state, once and for all 2019-02-22 12:26:24 +01:00
Johannes Meyer
aa8f070a00 BpConfig: Don't die due to circular references 2019-02-22 12:26:24 +01:00
Johannes Meyer
1a36e4d94a LegacyConfigRenderer: Don't render import sub-nodes 2019-02-22 12:26:24 +01:00