upstream/icingaweb2-module-businessprocess
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2-module-businessprocess.git synced 2026-05-28 04:34:08 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions
1195 commits 11 branches 11 tags 6.6 MiB
Commit graph

339 commits

Author SHA1 Message Date
Sukhwinder Dhillon
33b7348b23
Fix handling of manually changed service node name (#495)
Some checks are pending
L10n Update / update (push) Waiting to run
Details
CI / PHP (push) Waiting to run
Details 
Previously, a manually changed service node name was always treated as a
host node, causing validation to fail with "Host not found" when the
input contained a service name, e.g. <serviceName on hostName>.

Replace unnecessary `getNode()` calls with explicit `createHost()` or
`createService()` call.
 2026-03-25 12:55:44 +01:00
jrauh01
c552b1db7b
Allow to configure number of shown menu items (#484) 
This PR adds a **General** config tab with an option to set the number of items
shown in the sidebar menu. Previously, this was a fixed number of **five**. That
value is now kept as the default if none is provided.
 2026-03-25 12:38:18 +01:00
Sukhwinder Dhillon
e99bb0d26c BpConfig: Add method applyDbStates() to clean-up redundant code 2026-03-25 12:24:02 +01:00
Eric Lippmann
0ce3381488 License source files as GPL-3.0-or-later 
Add SPDX license headers and mark source files as GPL-3.0-or-later to
preserve the option to relicense under later GPL versions.
 2026-03-11 20:44:42 +01:00
Sukhwinder Dhillon
86b5557c1e Controllers: Add an else case to improve readability 2026-01-13 10:08:38 +01:00
Sukhwinder Dhillon
d17c4501b2 Use same view script in monitoring and icingadb for Access Denied message 
- Host|ServiceController: The extended class `CompatController` has its own tabs. Therefore, set the view script tabs to null
  to avoid creating tabs twice.
- View-scripts: Add a condition to create tabs only when the `monitoring` backend (ido[Host|Service]Controller) is used.
 2026-01-13 08:52:01 +01:00
Sukhwinder Dhillon
9a91854d4c Remove monitoring module dependency 
By separating `monitoring` module controllers.

- Adjust view-script paths accordingly
 2026-01-13 08:52:01 +01:00
Bastian Lederer
71f0ea3878 Mark uploaded_file element as required 
Explictly set the required attribute of the uploaded_file element of BpUploadForm to true.
previously the resulting-html element was not required and submitting the form caused null being passed.
This is necessary because this class does not extend the Web\Form,
and the Zend_Form does not mark the elment as required.
 2026-01-08 08:24:01 +01:00
Bastian Lederer
400ad69497 Replace null as array key with an empty string 
Using null as an array key is deprecated in PHP-8.5,
an empty string can be used for identical behavior.
This includes values that are passed to ZendForm::addDisplayGroup as elements,
as they will be used as array keys.
 2026-01-08 08:21:08 +01:00
Bastian Lederer
0e11994349 Explicitly set the escape parameter of fputcsv() 
Relying on the default value is deprecated since PHP-8.4
 2026-01-08 08:13:54 +01:00
Bastian Lederer
615d0afd10 Declare parameters that are null by default as nullable 
Implicitly nullable parameters are deprecated since PHP-8.4
 2026-01-08 08:07:59 +01:00
Eric Lippmann
c85b9d98fe Align coding style to comply with latest PSR 2025-12-12 12:44:49 +01:00
Eric Lippmann
e7f0b449bb Migrate deprecated @codingStandards syntax 2025-12-12 12:13:14 +01:00
Johannes Meyer
4d0dc0c91f process/show: Hide sort control in fullscreen or compact view 
fixes #462
 2025-06-30 10:58:49 +02:00
Johannes Meyer
726cab5851 process/show: Only show cleanup links in edit mode 
fixes #464
 2025-06-30 10:58:29 +02:00
Navid Sassan
35218f72fc Add showFullscreen and showCompact for dashboard 2025-05-07 10:28:54 +02:00
Sukhwinder Dhillon
4c2246a7e0 AddNodeForm: Add missing getLabel() call 2024-04-23 15:45:21 +02:00
moreamazingnick
e9a551e581
Fix indistinguishable suggestions for nodes (#433) 
refs #427
 2024-04-23 15:38:48 +02:00
Sukhwinder Dhillon
c43128be3e
Correct notification messages and add missing translations (#444) 
fixes #405
 2024-04-22 10:51:06 +02:00
Sukhwinder Dhillon
b672c28888
ProcessCommand: Fix false positive condition for ServiceNode (#445) 
fixes #440
 2024-04-19 11:53:05 +02:00
Yonas Habteab
1c6ad874ac Add variable type hint & fix argument type hints 2023-08-24 13:29:11 +02:00
Yonas Habteab
9aabeb1e1c Fix call an undefined method Filterable::fetchRow() error 2023-08-24 13:29:11 +02:00
Sukhwinder Dhillon
3643c799d0 SimulationForm: Property $simulatedNode can be nullable 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
3fffecca3f DeleteNodeForm: Make property $parentNode nullable 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
5899aa96ef ProcessCommand: Define $name in method scope 
- Fixes variable is probably undefined
 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
6306b5306c Define variable type when method returns a class object 
- This helps the IDE to find class methods and resolves the `call to an undefined method` issue
 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
92e982bf3d Remove unused class Form and FormStateOverrides 2023-08-24 13:04:29 +02:00
Sukhwinder Dhillon
9e67b56bca RenderedProcessActionBar: Remove unused constructor param $auth 2023-08-24 13:04:29 +02:00
Johannes Meyer
890df4be7c Re-introduce class EditNodeForm 
Rewritten from scratch. Now with ipl-form compatibility.
 2023-08-09 16:13:01 +02:00
Johannes Meyer
1b837c72a3 Drop class EditNodeForm 2023-08-09 16:13:01 +02:00
Johannes Meyer
4aac658089 process/show: Utilize the new AddNodeForm 2023-08-09 16:13:01 +02:00
Johannes Meyer
da4edda2b3 Re-introduce class AddNodeForm 
Rewritten from scratch. Now with ipl-form compatibility.
 2023-08-09 16:13:01 +02:00
Johannes Meyer
b84405180c Add new endpoint for node suggestions 2023-08-09 16:13:01 +02:00
Johannes Meyer
cb83f800b9 Drop class AddNodeForm 2023-08-09 16:13:01 +02:00
Sukhwinder Dhillon
25f37d6575 Use unescaped node name for missing children 2023-08-09 15:56:34 +02:00
Sukhwinder Dhillon
f93873623f Call it faulty config intead of invalid config 2023-08-09 15:56:34 +02:00
Sukhwinder Dhillon
4d7ea853c1 (Cleanup/Move)NodeForm extend BpConfigBaseForm 2023-08-09 10:40:12 +02:00
Sukhwinder Dhillon
af4b98faeb Use fontawesome icons with ipl\Web\Widget\Icon class everywhere 2023-08-08 12:24:29 +02:00
Sukhwinder Dhillon
1360e1e4a0 Avoid inline css 2023-08-08 11:39:24 +02:00
Johannes Meyer
3fe17336dc Escape semicolons in node names 
fixes #312
 2023-08-08 08:46:48 +02:00
Johannes Meyer
2acf611812 process/show: Allow to adjust the order of nodes 
Nodes can be ordered as usually by display name, but now also
in descending order. They can now also be ordered by state.

This also applies to manually ordered processes. Though, changes
to the manual order can only happen if the default order is
active. If that's not the case, a note is shown and a way to reset
the sort order.
 2023-08-03 15:19:28 +02:00
Johannes Meyer
52c150c56b Use the new Sort trait where applicable 
Moves the entire order processing to the renderers as that's
where it's mostly relevant. The only cases where nodes are
still ordered outside the rendering is where changes are
applied based on user input, which happened based on what's
been previously rendered.
 2023-08-03 15:19:28 +02:00
Johannes Meyer
8b2bac4e85 MoveNodeForm: Instruct JS to refresh the target container 
instead of letting JS refresh it on its own
 2023-08-03 15:06:08 +02:00
Johannes Meyer
1ac87cb4ea Let all config forms extend BpConfigBaseForm 
They're all too similar.
 2023-08-03 15:06:08 +02:00
Sukhwinder Dhillon
174abea6bd Add custom message for form's regex validation 2023-08-03 11:02:34 +02:00
Johannes Meyer
13330d3a44 Don't cast url to string if it's internally transformed again 
Also, the cast encodes the url as well, for use within HTML.
This is not required if used in conjunction with ipl-html.
 2023-08-03 10:59:23 +02:00
Sukhwinder Dhillon
071f006b7d AddNodeForm: Don't throw error while adding existing invalid config file 2023-08-03 10:57:14 +02:00
Sukhwinder Dhillon
834005f7b4 Don't break impact-action page if bp has invalid config 
- Add message for invalid config
 2023-08-03 10:57:14 +02:00
Sukhwinder Dhillon
5fcd8246b8 Add cli command Cleanup 2023-08-01 15:30:46 +02:00
Sukhwinder Dhillon
b053a78a13 ProcessController: Add Show link for missing linked nodes 2023-08-01 15:30:43 +02:00