Merge pull request #148 from Icinga/bugfix/mysql-connections-146

Fix temporary SQL rows leak in SqlFetchChecksums()
This commit is contained in:
Noah Hilverling 2020-04-22 17:11:55 +02:00 committed by GitHub
commit bc068ebbd4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions

View file

@ -680,6 +680,8 @@ func (dbw *DBWrapper) SqlFetchChecksums(table string, ids []string) (map[string]
if err != nil {
return nil, err
}
rows.Close()
}
return checksums, nil

View file

@ -40,7 +40,7 @@ func mkMysql(dbType string, dbDsn string, maxOpenConns int) (*sql.DB, error) {
mysql.SetLogger(oldlog.New(ioutil.Discard, "", 0))
db.SetMaxOpenConns(maxOpenConns)
db.SetMaxIdleConns(0)
db.SetMaxIdleConns(maxOpenConns)
return db, nil
}