From 8c361a6dfd1b30bb51837fb5cc67062a6b7e87bb Mon Sep 17 00:00:00 2001 From: "Alexander A. Klimov" Date: Thu, 2 Apr 2020 16:26:31 +0200 Subject: [PATCH 1/2] SqlFetchChecksums(): close SQL rows ASAP ... not to leak them during the loop. refs #146 --- connection/mysql.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/connection/mysql.go b/connection/mysql.go index 00c53c37..ef5f7d38 100644 --- a/connection/mysql.go +++ b/connection/mysql.go @@ -680,6 +680,8 @@ func (dbw *DBWrapper) SqlFetchChecksums(table string, ids []string) (map[string] if err != nil { return nil, err } + + rows.Close() } return checksums, nil From 73f5b12013b2d29ed48040f967bcb106ec09e2a8 Mon Sep 17 00:00:00 2001 From: "Alexander A. Klimov" Date: Mon, 20 Apr 2020 14:00:50 +0200 Subject: [PATCH 2/2] mkMysql(): allow connections to idle refs #146 --- connection/mysql_utils.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connection/mysql_utils.go b/connection/mysql_utils.go index e231ddcf..442a359f 100644 --- a/connection/mysql_utils.go +++ b/connection/mysql_utils.go @@ -40,7 +40,7 @@ func mkMysql(dbType string, dbDsn string, maxOpenConns int) (*sql.DB, error) { mysql.SetLogger(oldlog.New(ioutil.Discard, "", 0)) db.SetMaxOpenConns(maxOpenConns) - db.SetMaxIdleConns(0) + db.SetMaxIdleConns(maxOpenConns) return db, nil }