history: Clone params instead of the whole url object

This commit is contained in:
Johannes Meyer 2020-01-17 15:21:14 +01:00
parent d839784ded
commit 05c38484e7
3 changed files with 6 additions and 6 deletions

View file

@ -30,7 +30,7 @@ class HistoryController extends Controller
'state'
]);
$url = Url::fromPath('icingadb/history')->setParams($this->params);
$url = Url::fromPath('icingadb/history')->setParams(clone $this->params);
if (! $this->params->has('page') || ($page = (int) $this->params->shift('page')) < 1) {
$page = 1;
}
@ -59,7 +59,7 @@ class HistoryController extends Controller
$showMore = (new ShowMore(
$history->peekAhead()->execute(),
(clone $url)->setParam('page', $page + 1)
$url->setParam('page', $page + 1)
->setAnchor('page-' . ($page + 1))
))
->setLabel('Load More')

View file

@ -130,7 +130,7 @@ class HostController extends Controller
'history.object_type = ?' => 'host'
]);
$url = Url::fromPath('icingadb/history')->setParams($this->params);
$url = Url::fromPath('icingadb/history')->setParams(clone $this->params);
if (! $this->params->has('page') || ($page = (int) $this->params->shift('page')) < 1) {
$page = 1;
}
@ -150,7 +150,7 @@ class HostController extends Controller
$showMore = (new ShowMore(
$history->peekAhead()->execute(),
(clone $url)->setParam('page', $page + 1)
$url->setParam('page', $page + 1)
->setAnchor('page-' . ($page + 1))
))
->setLabel('Load More')

View file

@ -137,7 +137,7 @@ class ServiceController extends Controller
'history_service.id = ?' => $this->service->id
], Sql::ANY);
$url = Url::fromPath('icingadb/history')->setParams($this->params);
$url = Url::fromPath('icingadb/history')->setParams(clone $this->params);
if (! $this->params->has('page') || ($page = (int) $this->params->shift('page')) < 1) {
$page = 1;
}
@ -157,7 +157,7 @@ class ServiceController extends Controller
$showMore = (new ShowMore(
$history->peekAhead()->execute(),
(clone $url)->setParam('page', $page + 1)
$url->setParam('page', $page + 1)
->setAnchor('page-' . ($page + 1))
))
->setLabel('Load More')