From 05c38484e7548be28bada79ca6bc13e4a75c404e Mon Sep 17 00:00:00 2001
From: Johannes Meyer <johannes.meyer@icinga.com>
Date: Fri, 17 Jan 2020 15:21:14 +0100
Subject: [PATCH] history: Clone params instead of the whole url object

---
 application/controllers/HistoryController.php | 4 ++--
 application/controllers/HostController.php    | 4 ++--
 application/controllers/ServiceController.php | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/application/controllers/HistoryController.php b/application/controllers/HistoryController.php
index 4f494012..0317bb98 100644
--- a/application/controllers/HistoryController.php
+++ b/application/controllers/HistoryController.php
@@ -30,7 +30,7 @@ class HistoryController extends Controller
             'state'
         ]);
 
-        $url = Url::fromPath('icingadb/history')->setParams($this->params);
+        $url = Url::fromPath('icingadb/history')->setParams(clone $this->params);
         if (! $this->params->has('page') || ($page = (int) $this->params->shift('page')) < 1) {
             $page = 1;
         }
@@ -59,7 +59,7 @@ class HistoryController extends Controller
 
         $showMore = (new ShowMore(
             $history->peekAhead()->execute(),
-            (clone $url)->setParam('page', $page + 1)
+            $url->setParam('page', $page + 1)
                 ->setAnchor('page-' . ($page + 1))
         ))
             ->setLabel('Load More')
diff --git a/application/controllers/HostController.php b/application/controllers/HostController.php
index 867e9fdd..fa271895 100644
--- a/application/controllers/HostController.php
+++ b/application/controllers/HostController.php
@@ -130,7 +130,7 @@ class HostController extends Controller
                 'history.object_type = ?' => 'host'
             ]);
 
-        $url = Url::fromPath('icingadb/history')->setParams($this->params);
+        $url = Url::fromPath('icingadb/history')->setParams(clone $this->params);
         if (! $this->params->has('page') || ($page = (int) $this->params->shift('page')) < 1) {
             $page = 1;
         }
@@ -150,7 +150,7 @@ class HostController extends Controller
 
         $showMore = (new ShowMore(
             $history->peekAhead()->execute(),
-            (clone $url)->setParam('page', $page + 1)
+            $url->setParam('page', $page + 1)
                 ->setAnchor('page-' . ($page + 1))
         ))
             ->setLabel('Load More')
diff --git a/application/controllers/ServiceController.php b/application/controllers/ServiceController.php
index 7d04be89..785104fb 100644
--- a/application/controllers/ServiceController.php
+++ b/application/controllers/ServiceController.php
@@ -137,7 +137,7 @@ class ServiceController extends Controller
                 'history_service.id = ?' => $this->service->id
             ], Sql::ANY);
 
-        $url = Url::fromPath('icingadb/history')->setParams($this->params);
+        $url = Url::fromPath('icingadb/history')->setParams(clone $this->params);
         if (! $this->params->has('page') || ($page = (int) $this->params->shift('page')) < 1) {
             $page = 1;
         }
@@ -157,7 +157,7 @@ class ServiceController extends Controller
 
         $showMore = (new ShowMore(
             $history->peekAhead()->execute(),
-            (clone $url)->setParam('page', $page + 1)
+            $url->setParam('page', $page + 1)
                 ->setAnchor('page-' . ($page + 1))
         ))
             ->setLabel('Load More')