1257 commits

Author	SHA1	Message	Date
Alexander Aleksandrovič Klimov	8ff3d586f9	Merge pull request #10868 from Icinga/fix/openssl4-compat ... Support OpenSSL 4.0, add Fedora 45 to GHA	2026-07-08 12:18:57 +02:00
Johannes Schmidt	78ce827376	Merge pull request #10830 from Icinga/remember-deleted-api-objects ... Track deleted runtime objects to avoid erroneous recreation	2026-07-08 08:39:38 +02:00
Johannes Schmidt	bd7a783c60	Prune runtime-deleted object dictionary every 15 Minutes	2026-07-07 15:48:20 +02:00
Alexander A. Klimov	ee648b3f41	Use i2a_ASN1_INTEGER(), don't access ASN1_INTEGER data directly ... to fix a build error against OpenSSL 4.0. OpenSSL 4.0 made `ASN1_INTEGER` an opaque type. Also, `X509_get0_serialNumber()` must be used now, which returns `const ASN1_INTEGER*`.	2026-07-07 15:36:53 +02:00
Johannes Schmidt	0ccec92c73	Track deleted runtime objects to avoid erroneous recreation	2026-07-06 16:09:16 +02:00
Johannes Schmidt	36d41ac865	Merge pull request #10833 from Icinga/connection-hang ... Fix that NewClientHandler() could hang indefinitely, preventing new connection attempts	2026-07-03 08:51:48 +02:00
Johannes Schmidt	a098800f77	Merge pull request #10862 from Icinga/fix-api-authentication ... Fix API authentication being broken with clients that send an unauthenticated request first	2026-07-03 08:36:43 +02:00
Johannes Schmidt	e0a138ac30	Merge pull request #10883 from Icinga/better-json-error-diagnostic-information ... Fix high response latency with multiple API-requests targeting non-existent hosts or services	2026-07-02 17:41:04 +02:00
Johannes Schmidt	171e9ee37a	Pass std::exception_ptr to SendJsonError ... The `diagnostic_information` string will now generated if and when it is required (i.e. the "verbose" parameter is true).	2026-07-02 14:04:15 +02:00
Johannes Schmidt	393724bb2a	Consistently use std::exception_ptr ... `DiagnosticInformation()` wasn't able to take a `std::exception_ptr` due to the missing conversion on older boost versions, so now everything uses the std::exception_ptr instead. There are still a few reasons to use `boost::exception` in some places, but for exception pointers, the standard one should be better in most cases and almost never requires to include an extra header.	2026-07-02 13:59:48 +02:00
Julian Brost	78a281d918	Fix that NewClientHandler() could hang indefinitely, preventing new connection attempts ... There is some race condition when the `async_write()`/`async_flush()` operation for the `icinga::Hello` message fails (connection reset by peer for example) around the same time the connect timeout fires and calls `cancel()` on the stream, the following call to `async_shutdown()` may block indefinitely. If that happens, the endpoint remains in the connecting state and no new connection attemps are initiated. This commit fixes the issue by removing the `Defer` containing the `async_shutdown()`. The purpose of `async_shutdown()` is to signal a clean termination of the connection to the peer, which really isn't something that makes sense to to in a `Defer` block that is also executed in case of errors. For the one situation where doing a clean TLS shutdown makes some sense (closing anonymous client connections), a call to GracefulShutdown() is added to that specific code path. A large part of the change is just changing the indentation of the code, given that a now unnecessary `try`/`catch` block is removed. The following Go code creates a TLS server that can be used to demonstrate the issue. Note that given that a race condition is involved, this is not reliable and the sleep duration may need some fine-tuning. For this to work, `ApiListener.tls_handshake_timeout` needs to be set to a large-enough value like 60s to disable the timeout for `async_handshake()` itself so that the overall connect timeout is the one that fires. However, changing the timeout is not a prerequisite for the problem, it just makes it easier to reproduce. The error can also happen with the default timeouts if the TCP connect takes long enough so that the handshake is started late enough that its timeout expires after the connect timeout. package main import ( "crypto/tls" "log" "net" "time" ) func main() { cert, err := tls.LoadX509KeyPair("bad-agent.crt", "bad-agent.key") if err != nil { panic(err) } listener, err := tls.Listen("tcp", ":1337", &tls.Config{ Certificates: []tls.Certificate{cert}, }) if err != nil { panic(err) } log.Println("Listening on", listener.Addr()) for { conn, err := listener.Accept() if err != nil { panic(err) } go handle(conn.(*tls.Conn)) } } func handle(conn *tls.Conn) { addr := conn.RemoteAddr().String() log.Println(addr, "new connection") time.Sleep(15*time.Second - 10*time.Millisecond) log.Println(addr, "SetLinger(0)", conn.NetConn().(*net.TCPConn).SetLinger(0)) log.Println(addr, "Handshake()", conn.Handshake()) log.Println(addr, "conn.NetConn().Close()", conn.NetConn().Close()) } With additional logging in the `catch` block for `boost::system::system_error` and `Defer shutdownSslConn` (both removed by this commit), this showed the following. Note that in particular, `async_shutdown()` never returned, indicating that it hangs in there. [2026-04-24 17:32:56 +0200] information/ApiListener: Reconnecting to endpoint 'bad-agent' via host 'host.docker.internal' and port '1337' [2026-04-24 17:33:11 +0200] critical/ApiListener: Timeout while reconnecting to endpoint 'bad-agent' via host 'host.docker.internal' and port '1337', cancelling attempt [2026-04-24 17:33:11 +0200] information/ApiListener: New client connection for identity 'bad-agent' to [172.17.0.1]:1337 [2026-04-24 17:33:12 +0200] information/ApiListener: rethrowing for bad-agent: Error: Connection reset by peer [system:104 at /usr/include/boost/asio/detail/reactive_socket_send_op.hpp:137 in function 'do_complete'] [2026-04-24 17:33:12 +0200] information/ApiListener: doing async_shutdown for bad-agent	2026-07-02 13:46:12 +02:00
Johannes Schmidt	8c59fba97f	Merge pull request #10723 from Icinga/more-compiler-warnings-silenced ... More compiler warnings silenced	2026-07-01 13:58:00 +02:00
Johannes Schmidt	591f968d1c	Check object version on deletion	2026-07-01 13:45:45 +02:00
Julian Brost	165378adae	Merge pull request #10909 from Icinga/filter-expression-permission ... Add filter-expression permission	2026-06-29 20:33:12 +02:00
Julian Brost	fb42312e6c	Merge pull request #10908 from Icinga/json-parsing-recursion-limit ... [GHSA-wh38-wg57-5w7g] Fix stack overflow due to deeply nested data structures	2026-06-29 20:15:53 +02:00
Julian Brost	2c14db1c26	Merge pull request #10907 from Icinga/fix-ca-replacement-vuln ... [GHSA-vj39-ww8j-vvx5] Checking if certificate update request comes from a valid endpoint	2026-06-29 20:13:49 +02:00
Johannes Schmidt	6337b4d57c	Silence -Wtype-limits in HttpUtility::IsValidHeaderValue() ... implicit conversions between signed `char` and `unsigned char` and vice versa should be save and converting to unsigned char first circumvents this warning on platforms where `char` is signed.	2026-06-25 16:02:50 +02:00
Julian Brost	e7d656cf37	Don't shut down JSON-RPC connection if a message fails to parse ... With the limit from the previous commit, if a JSON-RPC now message fails to parse due to being nested to deep, it would have torn down the whole connection. It is still possible to trigger that scenario from DSL config (for example by returning nested structures from a lambda that is used in a check with command_endpoint). In order to fail more gracefully, only discard the single message and don't kill the whole connection.	2026-06-23 15:38:19 +02:00
Julian Brost	4964d2444c	JsonDecode: add depth limit ... Data structures parsed from JSON may be accessed recursively, so deeply nested structures may wreak havoc by overflowing the stack. Thus, enforce a general nesting depth limit of 24 by default (which should be more than enough for reasonable use), with the ability to pass a different limit to JsonDecode() if needed.	2026-06-23 15:38:19 +02:00
Julian Brost	324d5bb815	Add filter-expression permission ... This allows preventing ApiUsers from evaluating their own DSL expressions for improved security.	2026-06-23 10:55:45 +02:00
Julian Brost	91eeb41ff1	Merge pull request #10864 from Icinga/fix-http-message-sendfile-failbit-handling ... Fix handling the `std::ifstream::failbit` in `OutgoingHttpMessage`	2026-06-10 17:17:46 +02:00
Johannes Schmidt	fe469a5455	Guard against assert() failures in SendJsonError() ... Co-authored-by: Julian Brost <julian.brost@icinga.com>	2026-06-03 12:36:24 +02:00
Julian Brost	5d563cb8ca	Merge pull request #10785 from Icinga/url-validate-password ... Url::ParseUserinfo: Actually verify Password	2026-06-02 10:51:18 +02:00
Johannes Schmidt	6a3979fd1f	Fix handling std::ifstream exceptions in ConfigFilesHandler	2026-06-02 08:54:50 +02:00
Johannes Schmidt	281dd133c7	Fix handling the std::ifstream::failbit in OutgoingHttpMessage	2026-05-29 16:05:14 +02:00
Johannes Schmidt	4939c53bd1	Set www_authenticate header field after SendJsonError() ... This is necessary, since `SendJsonError()` also clears the entire response and possible because it doesn't on its own *send* the message yet.	2026-05-28 14:15:35 +02:00
Julian Brost	1b33451665	Fix misleading TLS handshake error logging ... The log message on TLS handshake errors always stated that a client handshake failed, even if if the connection was acting as the server. The commit changes it so that the actual role is taken into account.	2026-04-16 17:49:48 +02:00
Johannes Schmidt	6c2e0db381	Check if client is a valid endpoint before updating CA-certificate	2026-04-15 15:58:26 +02:00
Alvar Penning	e1d8cf487d	Url::ParseUserinfo: Actually verify Password ... In Url::ParseUserinfo, after extracting the password, ValidateToken is incorrectly called upon m_Username instead of m_Password. This commit fixes this and actually verifies the password. The bug was introduced with the surrounding code in 6571ffc2c8. Luckily, this does not seem to have any security impact. However, as being a bug, this commit now fixes the behavior.	2026-04-09 13:28:24 +02:00
Yonas Habteab	415140bc36	Add common OTel type/lib	2026-04-01 12:18:21 +02:00
Yonas Habteab	895dea2dc4	Merge pull request #10770 from Icinga/problem-chars ... Warn on problematic object names	2026-03-27 10:21:58 +01:00
Yonas Habteab	da521203b1	Endpoint: warn if endpoint name exceeds 64 characters	2026-03-26 13:58:57 +01:00
Julian Brost	ed403294a3	OutgoingHttpMessage: don't use shared_ptr for m_CpuBoundWork ... This change just gives clear ownership over the CpuBoundWork to the OutgoingHttpMessage, instead of the previous shared_ptr and weak_ptr combination with an unclear purpose.	2026-03-26 11:47:45 +01:00
Alexander A. Klimov	e03db5f71d	[Refactor] CpuBoundWork#CpuBoundWork(): require an io_context::strand	2026-03-19 14:53:29 +01:00
Alexander A. Klimov	fdc08c2e00	OutgoingHttpMessage#Flush(): release CpuBoundWork slot ... so that `/v1/events` doesn't have to use `IoBoundWorkSlot`. `IoBoundWorkSlot#~IoBoundWorkSlot()` will wait for a free semaphore slot which will be almost immediately released by `CpuBoundWork#~CpuBoundWork()`. Just releasing the already aquired slot manually is more efficient.	2026-03-19 14:51:19 +01:00
Julian Brost	0d376b5d5a	/v1/console: prevent concurrent use of the same session by multiple requests ... If there are such requests, without this change, they would all be allowed and processed, resulting in unsafe concurrent (write) access to these data structures, which can ultimately crash the daemon or lead to other unintended behavior.	2026-03-03 11:32:39 +01:00
William Calliari	11726b741c	Take a mutex before accessing the l_ApiScriptFrames ... Take a mutex to avoid race conditions in the map that lead to segmentation faults. Move the ApiScriptFrame object back behind a shared pointer to avoid holding the mutex for too long. Fixes #10674	2026-02-25 08:37:03 +01:00
Julian Brost	d02cdda5e9	Merge pull request #10716 from Icinga/drop-thread-local-variable-apiuser ... Remove `AuthenticatedApiUser` thread-local variable & pass it as arg instead	2026-02-13 14:43:36 +01:00
Yonas Habteab	3b80153848	Remove AuthenticatedApiUser thread-local variable & pass it as param instead	2026-02-11 11:39:57 +01:00
Yonas Habteab	d4d46a9780	HTTP: stream responses where appropriate	2026-02-11 09:47:39 +01:00
Yonas Habteab	32887884e5	Make ValueGenerator more flexible & easy to use ... This commit refactors the ValueGenerator class to be a template that can work with any container type. Previously, one has to manually take care of the used container by lazily iterating over it within a lambda. Now, the `ValueGenerator` class itself takes care of all the iteration, making it easier to use and less error-prone. The new base `Generator` class is required to allow the `JsonEncoder` to handle generators in a type-erased manner.	2026-02-10 16:57:56 +01:00
Yonas Habteab	91c7e60df8	Replace all existing copyright headers with SPDX headers ... I've used the following command to replace the original copyright header lines in a C-style comment block: ``` $ find . \( -type d \( -name '\..*' -o -name third-party -o -name scripts -o -name prefix -o -name malloc -o -name server -o -name docker -o -name build -o -name doc \) -prune \) -o -type f -exec perl -pi -e 's{/\*[^*]*\(\s*c\s*\)\s*(\d{4})\s*Icinga\s+GmbH[^*]*\*/}{// SPDX-FileCopyrightText: \1 Icinga GmbH <https://icinga.com>\n// SPDX-License-Identifier: GPL-2.0-or-later}gi' {} + ``` For files that use shell-style comments (#) like CMakeLists.txt, I've used this command: ``` $ find . \( -type d \( -name '\..*' -o -name third-party -o -name scripts -o -name prefix -o -name malloc -o -name server -o -name docker -o -name build -o -name doc \) -prune \) -o -type f -exec perl -pi -e 's{#.*\(\s*c\s*\)\s(\d{4})\sIcinga\s+GmbH.*}{# SPDX-FileCopyrightText: \1 Icinga GmbH <https://icinga.com>\n# SPDX-License-Identifier: GPL-2.0-or-later}gi' {} + ``` And for SQL files: ``` $ find . \( -type d \( -name '\..*' -o -name third-party -o -name scripts -o -name prefix -o -name malloc -o -name server -o -name docker -o -name build -o -name doc \) -prune \) -o -type f \( -name '*.sql' \) -exec perl -pi -e 's{--.*\(c\)\s(\d{4})\sIcinga\sGmbH.*}{-- SPDX-FileCopyrightText: \1 Icinga GmbH <https://icinga.com>\n-- SPDX-License-Identifier: GPL-2.0-or-later}gi' {} + $ find . \( -type d \( -name '\..*' -o -name third-party -o -name scripts -o -name prefix -o -name malloc -o -name server -o -name docker -o -name build -o -name doc \) -prune \) -o -type f \( -name '*.sql' \) -exec perl -pi -e 's{-- Copyright \(c\)\s(\d{4})\sIcinga\s+Development\sTeam.*}{-- SPDX-FileCopyrightText: \1 Icinga GmbH <https://icinga.com>\n-- SPDX-License-Identifier: GPL-2.0-or-later}gi' {} + ```	2026-02-04 14:00:05 +01:00
Alexander Aleksandrovič Klimov	9bffe06169	Merge pull request #10388 from Icinga/Registry-Freeze ... Freeze registries at startup, when everything has been registered	2026-01-26 17:28:43 +01:00
Alexander A. Klimov	b4192bd80a	Replace class B : public A { }; with using B = A; (refactor only)	2026-01-26 14:34:29 +01:00
Alexander A. Klimov	74ac0183ca	Registry<U,T>: remove unused template typename U	2026-01-26 10:24:22 +01:00
Alexander A. Klimov	4ba46f9eb2	Silence compiler warnings about unused parameters ... Every of these parameters exists for a reason. The best we can do is to convince the compiler.	2026-01-23 13:31:01 +01:00
Johannes Schmidt	1505f09ed6	Refactor HttpMessage into generalized templated types ... This adds generalized IncomingHttpMessage and OutgoingHttpMessage templates that support different types of streams (via a std::variant) and can both be used for either requests or responses. The tacked on metadata from the old HttpRequest and server connection from the old HttpServerConnection have been moved to HttpApi(Request|Response) classes that derive from the above generalized message types.	2026-01-22 17:20:32 +01:00
Johannes Schmidt	a0f603f608	Update names of HttpRequest and HttpResponse	2026-01-22 12:41:21 +01:00
Egor-OSSRevival	0d32ae3159	docs: Remove 'queue' parameter requirement from event stream document… (#10495) ... * docs: Remove 'queue' parameter requirement from event stream documentation * Update AUTHORS	2026-01-07 14:51:26 +01:00
Julian Brost	dc09713ac4	Merge pull request #10350 from Icinga/unittest-certificate-verification ... Test internal cert generation & verification process	2026-01-07 12:00:28 +01:00